diff options
| author | Jacob Keeler <jacob.keeler@livioradio.com> | 2020-09-02 16:02:38 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-02 16:02:38 -0400 |
| commit | efcf9de782810b83ddde04fff3cabbb5a4c82535 (patch) | |
| tree | 4f2fceae99145789dca97d64bad609860d02aef5 | |
| parent | dcea5e0a1a9d7ad284785a43424067705772ec20 (diff) | |
| download | sdl_core-efcf9de782810b83ddde04fff3cabbb5a4c82535.tar.gz | |
Apply suggestions from code review
Co-authored-by: JackLivio <jack@livio.io>
| -rw-r--r-- | src/components/application_manager/src/application_state.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/components/application_manager/src/application_state.cc b/src/components/application_manager/src/application_state.cc index c444b2264c..28af1b5f32 100644 --- a/src/components/application_manager/src/application_state.cc +++ b/src/components/application_manager/src/application_state.cc @@ -204,7 +204,7 @@ void ApplicationState::RemoveHMIState(const WindowID window_id, void ApplicationState::EraseHMIState(HmiStates& hmi_states, HmiStates::iterator it) { - if (it == hmi_states.begin()) { + if (hmi_states.begin() == it) { (*it)->set_parent(nullptr); } else { HmiStates::iterator next = it; @@ -212,7 +212,7 @@ void ApplicationState::EraseHMIState(HmiStates& hmi_states, next++; prev--; - if (next != hmi_states.end()) { + if (hmi_states.end() != next) { HmiStatePtr next_state = *next; HmiStatePtr prev_state = *prev; next_state->set_parent(prev_state); |