diff options
author | JackLivio <jack@livio.io> | 2018-08-14 11:33:12 -0400 |
---|---|---|
committer | JackLivio <jack@livio.io> | 2018-08-14 11:33:12 -0400 |
commit | 0db99f84ab344b82fab71200e43b67adbb2e2575 (patch) | |
tree | d1d532d0d90dd51a049bdf939460494af4d08ff4 | |
parent | e9c323f25a721ca5367c4ff125e1565dcade33a9 (diff) | |
download | sdl_core-0db99f84ab344b82fab71200e43b67adbb2e2575.tar.gz |
Remove redundant function validate
20 files changed, 41 insertions, 274 deletions
diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/register_app_interface_request.cc b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/register_app_interface_request.cc index 69e602c278..164c854f18 100644 --- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/register_app_interface_request.cc +++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/register_app_interface_request.cc @@ -621,11 +621,11 @@ void RegisterAppInterfaceRequest::SendRegisterAppInterfaceResponseToMobile( utils::SemanticVersion negotiated_version = application->msg_version(); response_params[strings::sync_msg_version][strings::major_version] = - negotiated_version.majorVersion; + negotiated_version.major_version_; response_params[strings::sync_msg_version][strings::minor_version] = - negotiated_version.minorVersion; + negotiated_version.minor_version_; response_params[strings::sync_msg_version][strings::patch_version] = - negotiated_version.patchVersion; + negotiated_version.patch_version_; const smart_objects::SmartObject& msg_params = (*message_)[strings::msg_params]; diff --git a/src/components/smart_objects/include/smart_objects/always_false_schema_item.h b/src/components/smart_objects/include/smart_objects/always_false_schema_item.h index 87e5d31ae9..a7b93012bb 100644 --- a/src/components/smart_objects/include/smart_objects/always_false_schema_item.h +++ b/src/components/smart_objects/include/smart_objects/always_false_schema_item.h @@ -54,14 +54,7 @@ class CAlwaysFalseSchemaItem : public ISchemaItem { * @return Errors::ERROR **/ Errors::eType validate(const SmartObject& Object) OVERRIDE; - /** - * @brief Validate smart object. - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * @return Errors::ERROR - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; + /** * @brief Validate smart object. * @param Object Object to validate. @@ -71,7 +64,8 @@ class CAlwaysFalseSchemaItem : public ISchemaItem { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; private: CAlwaysFalseSchemaItem(); diff --git a/src/components/smart_objects/include/smart_objects/always_true_schema_item.h b/src/components/smart_objects/include/smart_objects/always_true_schema_item.h index ca590fecca..b025723ea6 100644 --- a/src/components/smart_objects/include/smart_objects/always_true_schema_item.h +++ b/src/components/smart_objects/include/smart_objects/always_true_schema_item.h @@ -54,14 +54,6 @@ class CAlwaysTrueSchemaItem : public ISchemaItem { * @return NsSmartObjects::Errors::eType **/ Errors::eType validate(const SmartObject& Object) OVERRIDE; - /** - * @brief Validate smart object. - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * @return NsSmartObjects::Errors::eType - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; /** * @brief Validate smart object. @@ -72,7 +64,8 @@ class CAlwaysTrueSchemaItem : public ISchemaItem { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; private: CAlwaysTrueSchemaItem(); diff --git a/src/components/smart_objects/include/smart_objects/array_schema_item.h b/src/components/smart_objects/include/smart_objects/array_schema_item.h index 69a546b558..4dc416007a 100644 --- a/src/components/smart_objects/include/smart_objects/array_schema_item.h +++ b/src/components/smart_objects/include/smart_objects/array_schema_item.h @@ -76,17 +76,6 @@ class CArraySchemaItem : public ISchemaItem { /** * @brief Validate smart object. - * - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * message if an error occurs - * - * @return NsSmartObjects::Errors::eType - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; - /** - * @brief Validate smart object. * @param Object Object to validate. * @param report__ object for reporting errors during validation * @param MessageVersion to check mobile RPC version against RPC Spec History @@ -94,7 +83,8 @@ class CArraySchemaItem : public ISchemaItem { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; /** * @brief Apply schema. diff --git a/src/components/smart_objects/include/smart_objects/default_shema_item.h b/src/components/smart_objects/include/smart_objects/default_shema_item.h index b094091336..7d5b33b1a6 100644 --- a/src/components/smart_objects/include/smart_objects/default_shema_item.h +++ b/src/components/smart_objects/include/smart_objects/default_shema_item.h @@ -55,14 +55,6 @@ class CDefaultSchemaItem : public ISchemaItem { * @return Errors::ERROR **/ Errors::eType validate(const SmartObject& Object) OVERRIDE; - /** - * @brief Validate smart object. - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * @return Errors::ERROR - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; /** * @brief Validate smart object. @@ -73,7 +65,8 @@ class CDefaultSchemaItem : public ISchemaItem { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; /** * @brief Set default value to an object. @@ -124,7 +117,9 @@ Errors::eType CDefaultSchemaItem<Type>::validate(const SmartObject& Object) { template <typename Type> Errors::eType CDefaultSchemaItem<Type>::validate( - const SmartObject& Object, rpc::ValidationReport* report__) { + const SmartObject& Object, + rpc::ValidationReport* report__, + const utils::SemanticVersion& MessageVersion) { if (getSmartType() != Object.getType()) { std::string validation_info = "Incorrect type, expected: " + SmartObject::typeToString(getSmartType()) + @@ -138,14 +133,6 @@ Errors::eType CDefaultSchemaItem<Type>::validate( } template <typename Type> -Errors::eType CDefaultSchemaItem<Type>::validate( - const SmartObject& Object, - rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) { - return validate(Object, report__); -} - -template <typename Type> bool CDefaultSchemaItem<Type>::setDefaultValue(SmartObject& Object) { Type value; if (mDefaultValue.getValue(value)) { diff --git a/src/components/smart_objects/include/smart_objects/enum_schema_item.h b/src/components/smart_objects/include/smart_objects/enum_schema_item.h index 23532f1bbe..41102933f3 100644 --- a/src/components/smart_objects/include/smart_objects/enum_schema_item.h +++ b/src/components/smart_objects/include/smart_objects/enum_schema_item.h @@ -109,14 +109,6 @@ class TEnumSchemaItem : public CDefaultSchemaItem<EnumType> { * @return NsSmartObjects::Errors::eType **/ Errors::eType validate(const SmartObject& Object) OVERRIDE; - /** - * @brief Validate smart object. - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * @return NsSmartObjects::Errors::eType - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; /** * @brief Validate smart object. @@ -127,7 +119,8 @@ class TEnumSchemaItem : public CDefaultSchemaItem<EnumType> { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; /** * @brief Return the correct history signature based on message version. * @param signatures Vector reference of enums history items. @@ -299,33 +292,6 @@ Errors::eType TEnumSchemaItem<EnumType>::validate(const SmartObject& Object) { } template <typename EnumType> -Errors::eType TEnumSchemaItem<EnumType>::validate( - const SmartObject& Object, rpc::ValidationReport* report__) { - if (SmartType_Integer != Object.getType()) { - std::string validation_info; - if (SmartType_String == Object.getType()) { - validation_info = "Invalid enum value: " + Object.asString(); - } else { - validation_info = "Incorrect type, expected: " + - SmartObject::typeToString(SmartType_Integer) + - " (enum), got: " + - SmartObject::typeToString(Object.getType()); - } - report__->set_validation_info(validation_info); - return Errors::INVALID_VALUE; - } - if (mAllowedElements.find(static_cast<EnumType>(Object.asInt())) == - mAllowedElements.end()) { - std::stringstream stream; - stream << "Invalid enum value: " << Object.asInt(); - std::string validation_info = stream.str(); - report__->set_validation_info(validation_info); - return Errors::OUT_OF_RANGE; - } - return Errors::OK; -} - -template <typename EnumType> const ElementSignature TEnumSchemaItem<EnumType>::getSignature( const std::vector<ElementSignature>& signatures, const utils::SemanticVersion& MessageVersion) { diff --git a/src/components/smart_objects/include/smart_objects/number_schema_item.h b/src/components/smart_objects/include/smart_objects/number_schema_item.h index ee82b87241..0f3246ef5f 100644 --- a/src/components/smart_objects/include/smart_objects/number_schema_item.h +++ b/src/components/smart_objects/include/smart_objects/number_schema_item.h @@ -72,14 +72,6 @@ class TNumberSchemaItem : public CDefaultSchemaItem<NumberType> { * @return Errors::ERROR **/ Errors::eType validate(const SmartObject& Object) OVERRIDE; - /** - * @brief Validate smart object. - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * @return Errors::ERROR - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; /** * @brief Validate smart object. @@ -90,7 +82,8 @@ class TNumberSchemaItem : public CDefaultSchemaItem<NumberType> { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; private: /** @@ -157,7 +150,9 @@ Errors::eType TNumberSchemaItem<NumberType>::validate( template <typename NumberType> Errors::eType TNumberSchemaItem<NumberType>::validate( - const SmartObject& Object, rpc::ValidationReport* report__) { + const SmartObject& Object, + rpc::ValidationReport* report__, + const utils::SemanticVersion& MessageVersion) { if (!isValidNumberType(Object.getType())) { SmartType expectedType = (typeid(double) == typeid(Object.getType())) ? SmartType_Double @@ -205,14 +200,6 @@ Errors::eType TNumberSchemaItem<NumberType>::validate( } template <typename NumberType> -Errors::eType TNumberSchemaItem<NumberType>::validate( - const SmartObject& Object, - rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) { - return validate(Object, report__); -} - -template <typename NumberType> TNumberSchemaItem<NumberType>::TNumberSchemaItem( const TSchemaItemParameter<NumberType>& MinValue, const TSchemaItemParameter<NumberType>& MaxValue, diff --git a/src/components/smart_objects/include/smart_objects/object_schema_item.h b/src/components/smart_objects/include/smart_objects/object_schema_item.h index 1d42034317..4785211694 100644 --- a/src/components/smart_objects/include/smart_objects/object_schema_item.h +++ b/src/components/smart_objects/include/smart_objects/object_schema_item.h @@ -110,14 +110,7 @@ class CObjectSchemaItem : public ISchemaItem { * @return NsSmartObjects::Errors::eType **/ Errors::eType validate(const SmartObject& Object) OVERRIDE; - /** - * @brief Validate smart object. - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * @return NsSmartObjects::Errors::eType - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; + /** * @brief Validate smart object. * @param Object Object to validate. @@ -127,7 +120,8 @@ class CObjectSchemaItem : public ISchemaItem { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; /** * @brief Apply schema. * @param Object Object to apply schema. diff --git a/src/components/smart_objects/include/smart_objects/schema_item.h b/src/components/smart_objects/include/smart_objects/schema_item.h index 828dac33f0..2e951f7f9f 100644 --- a/src/components/smart_objects/include/smart_objects/schema_item.h +++ b/src/components/smart_objects/include/smart_objects/schema_item.h @@ -68,24 +68,13 @@ class ISchemaItem { * @param Object Object to validate. * @param report__ object for reporting errors during validation * message if an error occurs - * - * @return NsSmartObjects::Errors::eType - **/ - virtual Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__); - - /** - * @brief Validate smart object. - * - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * message if an error occurs * @param MessageVersion to check mobile RPC version against RPC Spec Histor * @return NsSmartObjects::Errors::eType **/ - virtual Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion); + virtual Errors::eType validate( + const SmartObject& Object, + rpc::ValidationReport* report__, + const utils::SemanticVersion& MessageVersion = utils::SemanticVersion()); /** * @brief Set default value to an object. diff --git a/src/components/smart_objects/include/smart_objects/smart_object.h b/src/components/smart_objects/include/smart_objects/smart_object.h index f594ad9820..d81e18569f 100644 --- a/src/components/smart_objects/include/smart_objects/smart_object.h +++ b/src/components/smart_objects/include/smart_objects/smart_object.h @@ -682,19 +682,12 @@ class SmartObject FINAL { * @brief Validates object according to attached schema. * * @param report__ object for reporting errors during validation - * @return Result of validation. - */ - Errors::eType validate(rpc::ValidationReport* report__); - - /** - * @brief Validates object according to attached schema. - * - * @param report__ object for reporting errors during validation * @param messageVersion of the mobile app to check against RPC Spec Schema * @return Result of validation. */ - Errors::eType validate(rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion); + Errors::eType validate( + rpc::ValidationReport* report__, + const utils::SemanticVersion& MessageVersion = utils::SemanticVersion()); /** * @brief Sets new schema diff --git a/src/components/smart_objects/include/smart_objects/smart_schema.h b/src/components/smart_objects/include/smart_objects/smart_schema.h index 5ab96e82bd..d3fcc0e28d 100644 --- a/src/components/smart_objects/include/smart_objects/smart_schema.h +++ b/src/components/smart_objects/include/smart_objects/smart_schema.h @@ -76,23 +76,13 @@ class CSmartSchema FINAL { * * @param Object Object to validate. * @param report__ object for reporting errors during validation - * - * @return NsSmartObjects::Errors::eType - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) const; - - /** - * @brief Validate smart object. - * - * @param Object Object to validate. - * @param report__ object for reporting errors during validation * @param MessageVersion to check mobile RPC version against RPC Spec History * @return NsSmartObjects::Errors::eType **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& messageVersion) const; + const utils::SemanticVersion& messageVersion = + utils::SemanticVersion()) const; /** * @brief Set new root schema item. diff --git a/src/components/smart_objects/include/smart_objects/string_schema_item.h b/src/components/smart_objects/include/smart_objects/string_schema_item.h index 4d5f18f711..dcaad364b2 100644 --- a/src/components/smart_objects/include/smart_objects/string_schema_item.h +++ b/src/components/smart_objects/include/smart_objects/string_schema_item.h @@ -66,14 +66,7 @@ class CStringSchemaItem : public CDefaultSchemaItem<std::string> { * @return NsSmartObjects::Errors::eType **/ Errors::eType validate(const SmartObject& Object) OVERRIDE; - /** - * @brief Validate smart object. - * @param Object Object to validate. - * @param report__ object for reporting errors during validation - * @return NsSmartObjects::Errors::eType - **/ - Errors::eType validate(const SmartObject& Object, - rpc::ValidationReport* report__) OVERRIDE; + /** * @brief Validate smart object. * @param Object Object to validate. @@ -83,7 +76,8 @@ class CStringSchemaItem : public CDefaultSchemaItem<std::string> { **/ Errors::eType validate(const SmartObject& Object, rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) OVERRIDE; + const utils::SemanticVersion& MessageVersion = + utils::SemanticVersion()) OVERRIDE; private: /** diff --git a/src/components/smart_objects/src/always_false_schema_item.cc b/src/components/smart_objects/src/always_false_schema_item.cc index acbe15485b..db16640265 100644 --- a/src/components/smart_objects/src/always_false_schema_item.cc +++ b/src/components/smart_objects/src/always_false_schema_item.cc @@ -47,12 +47,6 @@ Errors::eType CAlwaysFalseSchemaItem::validate(const SmartObject& object) { } Errors::eType CAlwaysFalseSchemaItem::validate( - const SmartObject& object, rpc::ValidationReport* report__) { - report__->set_validation_info("Generic error"); - return Errors::ERROR; -} - -Errors::eType CAlwaysFalseSchemaItem::validate( const SmartObject& Object, rpc::ValidationReport* report__, const utils::SemanticVersion& MessageVersion) { diff --git a/src/components/smart_objects/src/always_true_schema_item.cc b/src/components/smart_objects/src/always_true_schema_item.cc index 8a72d606a0..0a3b8be134 100644 --- a/src/components/smart_objects/src/always_true_schema_item.cc +++ b/src/components/smart_objects/src/always_true_schema_item.cc @@ -43,11 +43,6 @@ Errors::eType CAlwaysTrueSchemaItem::validate(const SmartObject& object) { return Errors::OK; } -Errors::eType CAlwaysTrueSchemaItem::validate(const SmartObject& object, - rpc::ValidationReport* report__) { - return Errors::OK; -} - Errors::eType CAlwaysTrueSchemaItem::validate( const SmartObject& Object, rpc::ValidationReport* report__, diff --git a/src/components/smart_objects/src/array_schema_item.cc b/src/components/smart_objects/src/array_schema_item.cc index 108bccce11..60081c5222 100644 --- a/src/components/smart_objects/src/array_schema_item.cc +++ b/src/components/smart_objects/src/array_schema_item.cc @@ -47,48 +47,6 @@ Errors::eType CArraySchemaItem::validate(const SmartObject& Object) { return validate(Object, &report); } -Errors::eType CArraySchemaItem::validate(const SmartObject& Object, - rpc::ValidationReport* report__) { - if (SmartType_Array != Object.getType()) { - std::string validation_info = "Incorrect type, expected: " + - SmartObject::typeToString(SmartType_Array) + - ", got: " + - SmartObject::typeToString(Object.getType()); - report__->set_validation_info(validation_info); - return Errors::INVALID_VALUE; - } - size_t sizeLimit; - const size_t array_len = Object.length(); - - if (mMinSize.getValue(sizeLimit) && (array_len < sizeLimit)) { - std::stringstream stream; - stream << "Got array of size: " << array_len - << ", minimum allowed: " << sizeLimit; - std::string validation_info = stream.str(); - report__->set_validation_info(validation_info); - return Errors::OUT_OF_RANGE; - } - if (mMaxSize.getValue(sizeLimit) && (array_len > sizeLimit)) { - std::stringstream stream; - stream << "Got array of size: " << array_len - << ", maximum allowed: " << sizeLimit; - std::string validation_info = stream.str(); - report__->set_validation_info(validation_info); - return Errors::OUT_OF_RANGE; - } - - for (size_t i = 0u; i < array_len; ++i) { - std::stringstream strVal; - strVal << i; - const Errors::eType result = mElementSchemaItem->validate( - Object.getElement(i), &report__->ReportSubobject(strVal.str())); - if (Errors::OK != result) { - return result; - } - } - return Errors::OK; -} - Errors::eType CArraySchemaItem::validate( const SmartObject& Object, rpc::ValidationReport* report__, diff --git a/src/components/smart_objects/src/object_schema_item.cc b/src/components/smart_objects/src/object_schema_item.cc index 533f3b5e2c..879c280a67 100644 --- a/src/components/smart_objects/src/object_schema_item.cc +++ b/src/components/smart_objects/src/object_schema_item.cc @@ -109,44 +109,6 @@ Errors::eType CObjectSchemaItem::validate(const SmartObject& object) { return validate(object, &report); } -Errors::eType CObjectSchemaItem::validate(const SmartObject& object, - rpc::ValidationReport* report__) { - if (SmartType_Map != object.getType()) { - std::string validation_info = "Incorrect type, expected: " + - SmartObject::typeToString(SmartType_Map) + - ", got: " + - SmartObject::typeToString(object.getType()); - report__->set_validation_info(validation_info); - return Errors::INVALID_VALUE; - } - - std::set<std::string> object_keys = object.enumerate(); - - for (Members::const_iterator it = mMembers.begin(); it != mMembers.end(); - ++it) { - const std::string& key = it->first; - const SMember& member = it->second; - - std::set<std::string>::const_iterator key_it = object_keys.find(key); - if (object_keys.end() == key_it) { - if (member.mIsMandatory) { - std::string validation_info = "Missing mandatory parameter: " + key; - report__->set_validation_info(validation_info); - return Errors::MISSING_MANDATORY_PARAMETER; - } - continue; - } - const SmartObject& field = object.getElement(key); - const Errors::eType result = - member.mSchemaItem->validate(field, &report__->ReportSubobject(key)); - if (Errors::OK != result) { - return result; - } - object_keys.erase(key_it); - } - return Errors::OK; -} - Errors::eType CObjectSchemaItem::validate( const SmartObject& object, rpc::ValidationReport* report__, diff --git a/src/components/smart_objects/src/schema_item.cc b/src/components/smart_objects/src/schema_item.cc index 001aa5fc5d..ae7f3665bb 100644 --- a/src/components/smart_objects/src/schema_item.cc +++ b/src/components/smart_objects/src/schema_item.cc @@ -39,11 +39,6 @@ Errors::eType ISchemaItem::validate(const SmartObject& Object) { return Errors::ERROR; } -Errors::eType ISchemaItem::validate(const SmartObject& object, - rpc::ValidationReport* report__) { - return Errors::ERROR; -} - Errors::eType ISchemaItem::validate( const SmartObject& object, rpc::ValidationReport* report__, diff --git a/src/components/smart_objects/src/smart_object.cc b/src/components/smart_objects/src/smart_object.cc index 527a4308f8..691f45f63b 100644 --- a/src/components/smart_objects/src/smart_object.cc +++ b/src/components/smart_objects/src/smart_object.cc @@ -878,10 +878,6 @@ Errors::eType SmartObject::validate() { return validate(&report); } -Errors::eType SmartObject::validate(rpc::ValidationReport* report__) { - return m_schema.validate(*this, report__); -} - Errors::eType SmartObject::validate( rpc::ValidationReport* report__, const utils::SemanticVersion& MessageVersion) { diff --git a/src/components/smart_objects/src/smart_schema.cc b/src/components/smart_objects/src/smart_schema.cc index 154f9e116f..3ab94caf85 100644 --- a/src/components/smart_objects/src/smart_schema.cc +++ b/src/components/smart_objects/src/smart_schema.cc @@ -45,11 +45,6 @@ Errors::eType CSmartSchema::validate(const SmartObject& Object) const { return validate(Object, &report); } -Errors::eType CSmartSchema::validate(const SmartObject& object, - rpc::ValidationReport* report__) const { - return mSchemaItem->validate(object, report__); -} - Errors::eType CSmartSchema::validate( const SmartObject& object, rpc::ValidationReport* report__, diff --git a/src/components/smart_objects/src/string_schema_item.cc b/src/components/smart_objects/src/string_schema_item.cc index cc6bf79f60..f3c39eff8f 100644 --- a/src/components/smart_objects/src/string_schema_item.cc +++ b/src/components/smart_objects/src/string_schema_item.cc @@ -51,8 +51,10 @@ Errors::eType CStringSchemaItem::validate(const SmartObject& Object) { return validate(Object, &report); } -Errors::eType CStringSchemaItem::validate(const SmartObject& Object, - rpc::ValidationReport* report__) { +Errors::eType CStringSchemaItem::validate( + const SmartObject& Object, + rpc::ValidationReport* report__, + const utils::SemanticVersion& MessageVersion) { if (SmartType_String != Object.getType()) { std::string validation_info = "Incorrect type, expected: " + SmartObject::typeToString(SmartType_String) + @@ -84,13 +86,6 @@ Errors::eType CStringSchemaItem::validate(const SmartObject& Object, return Errors::OK; } -Errors::eType CStringSchemaItem::validate( - const SmartObject& Object, - rpc::ValidationReport* report__, - const utils::SemanticVersion& MessageVersion) { - return validate(Object, report__); -} - SmartType CStringSchemaItem::getSmartType() const { return SmartType_String; } |