diff options
author | jacobkeeler <jacob.keeler@livioradio.com> | 2019-09-20 15:38:16 -0400 |
---|---|---|
committer | jacobkeeler <jacob.keeler@livioradio.com> | 2019-09-20 15:38:16 -0400 |
commit | 649dfcc7eff429f290c14f3264447a0fe8f77a6e (patch) | |
tree | aea5ff01744f443493013d44feb5df2e77e23b1a | |
parent | 7841f67ebe08678b78de15ae98988d0d8d9de94b (diff) | |
download | sdl_core-649dfcc7eff429f290c14f3264447a0fe8f77a6e.tar.gz |
Address commentsfix/gather_consumer_messages
3 files changed, 41 insertions, 22 deletions
diff --git a/src/components/policy/policy_external/src/sql_pt_ext_representation.cc b/src/components/policy/policy_external/src/sql_pt_ext_representation.cc index 30eb7b4f38..c8a1b5d7ea 100644 --- a/src/components/policy/policy_external/src/sql_pt_ext_representation.cc +++ b/src/components/policy/policy_external/src/sql_pt_ext_representation.cc @@ -563,25 +563,23 @@ bool SQLPTExtRepresentation::GatherConsumerFriendlyMessages( msg.message_code = query.GetString(7); std::string language = query.GetString(6); + policy_table::Languages& languages = + (*messages->messages)[msg.message_code].languages; + policy_table::MessageString& specific_message = languages[language]; if (!msg.tts.empty()) { - *(*messages->messages)[msg.message_code].languages[language].tts = - msg.tts; + *(specific_message).tts = msg.tts; } if (!msg.label.empty()) { - *(*messages->messages)[msg.message_code].languages[language].label = - msg.label; + *(specific_message).label = msg.label; } if (!msg.line1.empty()) { - *(*messages->messages)[msg.message_code].languages[language].line1 = - msg.line1; + *(specific_message).line1 = msg.line1; } if (!msg.line2.empty()) { - *(*messages->messages)[msg.message_code].languages[language].line2 = - msg.line2; + *(specific_message).line2 = msg.line2; } if (!msg.text_body.empty()) { - *(*messages->messages)[msg.message_code].languages[language].textBody = - msg.text_body; + *(specific_message).textBody = msg.text_body; } } } else { diff --git a/src/components/policy/policy_external/src/sql_pt_representation.cc b/src/components/policy/policy_external/src/sql_pt_representation.cc index d8f137a52c..5af4cc5440 100644 --- a/src/components/policy/policy_external/src/sql_pt_representation.cc +++ b/src/components/policy/policy_external/src/sql_pt_representation.cc @@ -725,10 +725,33 @@ bool SQLPTRepresentation::GatherConsumerFriendlyMessages( if (query.Prepare(sql_pt::kCollectFriendlyMsg)) { while (query.Next()) { UserFriendlyMessage msg; + + msg.tts = query.GetString(1); + msg.label = query.GetString(2); + msg.line1 = query.GetString(3); + msg.line2 = query.GetString(4); + msg.text_body = query.GetString(5); msg.message_code = query.GetString(7); - std::string language = query.GetString(6); - (*messages->messages)[msg.message_code].languages[language]; + std::string language = query.GetString(6); + policy_table::Languages& languages = + (*messages->messages)[msg.message_code].languages; + policy_table::MessageString& specific_message = languages[language]; + if (!msg.tts.empty()) { + *(specific_message).tts = msg.tts; + } + if (!msg.label.empty()) { + *(specific_message).label = msg.label; + } + if (!msg.line1.empty()) { + *(specific_message).line1 = msg.line1; + } + if (!msg.line2.empty()) { + *(specific_message).line2 = msg.line2; + } + if (!msg.text_body.empty()) { + *(specific_message).textBody = msg.text_body; + } } } else { LOG4CXX_WARN(logger_, "Incorrect statement for select friendly messages."); diff --git a/src/components/policy/policy_regular/src/sql_pt_representation.cc b/src/components/policy/policy_regular/src/sql_pt_representation.cc index eca9b60c72..7b2d01ef53 100644 --- a/src/components/policy/policy_regular/src/sql_pt_representation.cc +++ b/src/components/policy/policy_regular/src/sql_pt_representation.cc @@ -689,25 +689,23 @@ bool SQLPTRepresentation::GatherConsumerFriendlyMessages( msg.message_code = query.GetString(7); std::string language = query.GetString(6); + policy_table::Languages& languages = + (*messages->messages)[msg.message_code].languages; + policy_table::MessageString& specific_message = languages[language]; if (!msg.tts.empty()) { - *(*messages->messages)[msg.message_code].languages[language].tts = - msg.tts; + *(specific_message).tts = msg.tts; } if (!msg.label.empty()) { - *(*messages->messages)[msg.message_code].languages[language].label = - msg.label; + *(specific_message).label = msg.label; } if (!msg.line1.empty()) { - *(*messages->messages)[msg.message_code].languages[language].line1 = - msg.line1; + *(specific_message).line1 = msg.line1; } if (!msg.line2.empty()) { - *(*messages->messages)[msg.message_code].languages[language].line2 = - msg.line2; + *(specific_message).line2 = msg.line2; } if (!msg.text_body.empty()) { - *(*messages->messages)[msg.message_code].languages[language].textBody = - msg.text_body; + *(specific_message).textBody = msg.text_body; } } } else { |