diff options
author | Jacob Keeler <jacob.keeler@livioradio.com> | 2019-10-03 16:36:08 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-10-03 16:36:08 -0400 |
commit | e4b28634bcbf2e52e940704524029f8f48707bf0 (patch) | |
tree | 7bf8e24eb60b5d6e77d0c75206516f7d25e07556 | |
parent | 4332289e7db5e7c4208ef99177631178abebe336 (diff) | |
parent | 4bc94c03e7ed97c73fb8dffd295b77ea70d2e314 (diff) | |
download | sdl_core-e4b28634bcbf2e52e940704524029f8f48707bf0.tar.gz |
Merge pull request #3066 from smartdevicelink/fix/coverity_issues
Fix latest coverity issues
2 files changed, 6 insertions, 6 deletions
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_consent_request.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_consent_request.cc index 819f5c3fef..fd661afd5f 100644 --- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_consent_request.cc +++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_consent_request.cc @@ -231,10 +231,7 @@ void GetInteriorVehicleDataConsentRequest::on_event( hmi_response[app_mngr::strings::msg_params]; std::string info; GetInfo(hmi_response, info); - SendResponse(success_result, - result_code, - info.c_str(), - success_result ? &response_params : nullptr); + SendResponse(success_result, result_code, info.c_str(), &response_params); } std::string GetInteriorVehicleDataConsentRequest::ModuleType() const { diff --git a/src/components/application_manager/src/policies/policy_handler.cc b/src/components/application_manager/src/policies/policy_handler.cc index b92685e278..b0a4c4586d 100644 --- a/src/components/application_manager/src/policies/policy_handler.cc +++ b/src/components/application_manager/src/policies/policy_handler.cc @@ -337,8 +337,11 @@ bool PolicyHandler::LoadPolicyLibrary() { bool PolicyHandler::CreateManager() { void* policy_handle = dlopen(kLibrary.c_str(), RTLD_LAZY); const char* error = dlerror(); - if (error) { - LOG4CXX_ERROR(logger_, error); + if (!policy_handle) { + LOG4CXX_ERROR( + logger_, + (error == NULL ? "Unknown error in dlopen while loading policy table" + : error)); return false; } |