summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Keeler <jacob.keeler@livioradio.com>2021-11-04 11:18:33 -0400
committerGitHub <noreply@github.com>2021-11-04 11:18:33 -0400
commitb8211bc97723ab474c78ffe4972f0494b08789c2 (patch)
tree299be30607af972b7b9f86c60c0c00547300422a
parent31324d58aef55436991fc2bd0a4dce66629146e5 (diff)
downloadsdl_core-b8211bc97723ab474c78ffe4972f0494b08789c2.tar.gz
Update minimum value of MaxSupportedProtocolVersion to 2 (#3801)
If this value is set to 1, no apps can register because SDL Core responds with UNSUPPORTED_VERSION to protocol V1 messages (besides the initial StartService)
-rw-r--r--src/appMain/smartDeviceLink.ini2
-rw-r--r--src/components/config_profile/src/profile.cc4
2 files changed, 3 insertions, 3 deletions
diff --git a/src/appMain/smartDeviceLink.ini b/src/appMain/smartDeviceLink.ini
index 56822db0ef..15bba13b86 100644
--- a/src/appMain/smartDeviceLink.ini
+++ b/src/appMain/smartDeviceLink.ini
@@ -237,7 +237,7 @@ CloudAppRetryTimeout = 1000
CloudAppMaxRetryAttempts = 5
[ProtocolHandler]
-; SDL supported protocol version
+; SDL supported protocol version. Minimum value is 2
MaxSupportedProtocolVersion = 5
; Packet with payload bigger than next value will be marked as a malformed
; for protocol v3 or higher
diff --git a/src/components/config_profile/src/profile.cc b/src/components/config_profile/src/profile.cc
index f318ec98f5..38be86c72f 100644
--- a/src/components/config_profile/src/profile.cc
+++ b/src/components/config_profile/src/profile.cc
@@ -2298,8 +2298,8 @@ void Profile::UpdateValues() {
kProtocolHandlerSection,
kMaxSupportedProtocolVersionKey);
- if (max_supported_protocol_version_ < 1) {
- max_supported_protocol_version_ = 1;
+ if (max_supported_protocol_version_ < 2) {
+ max_supported_protocol_version_ = 2;
} else if (max_supported_protocol_version_ >
kDefaultMaxSupportedProtocolVersion) {
max_supported_protocol_version_ = kDefaultMaxSupportedProtocolVersion;