diff options
| author | Yana Chernysheva (GitHub) <59469418+ychernysheva@users.noreply.github.com> | 2020-10-01 18:24:00 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-01 11:24:00 -0400 |
| commit | 01c9705cf408e010bd9f98c5230347975da69c4a (patch) | |
| tree | 1cdbbddaa054a778f7e09226d826f02e17a01bf8 /src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src | |
| parent | 46f3bfa03c7eeb63499fd6a8c6430cd693646247 (diff) | |
| download | sdl_core-01c9705cf408e010bd9f98c5230347975da69c4a.tar.gz | |
Fix Cppcheck issues (#3453)
* Fix noExplicitConstructor issue
* Fix functionConst issues
* Fix unusedFunction and unusedField issues
* Fix redundantInitialization
* Fix unreadVariable and unusedVariable issues
* Fix postfixOperator issue
* Fix variableScope issue
* Fix invalidPrintfArgType_sint and unsignedLessThanZero issues
* Fix other errors
* Add changes, related to functions marked as unused
* Fix new issues
* Fixe review comment
* Fix codestyle
* Fix constParameter errors
* Fix functionConst errors
* Fix noExplicitConstructor, redundantInitialization errors
* Fix unreadVariable errors
* Fix shadowVariable error
* Fix useStlAlgorithm errors
* Fixe variableScope error, add FIXME comment
* Fix code style
* Fix compile error
* Remove unsued function
* Fix compile error
Co-authored-by: Vladislav Semenyuk <vsemenyuk@luxoft.com>
Diffstat (limited to 'src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src')
| -rw-r--r-- | src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/app_service_rpc_plugin.cc | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/app_service_rpc_plugin.cc b/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/app_service_rpc_plugin.cc index fd7b03fabc..e03973614d 100644 --- a/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/app_service_rpc_plugin.cc +++ b/src/components/application_manager/rpc_plugins/app_service_rpc_plugin/src/app_service_rpc_plugin.cc @@ -107,14 +107,15 @@ void AppServiceRpcPlugin::DeleteSubscriptions( } // namespace app_service_rpc_plugin -extern "C" __attribute__((visibility("default"))) -application_manager::plugin_manager::RPCPlugin* -Create(logger::Logger* logger_instance) { +using RPCPlugin = application_manager::plugin_manager::RPCPlugin; +// cppcheck-suppress unusedFunction +extern "C" __attribute__((visibility("default"))) RPCPlugin* Create( + logger::Logger* logger_instance) { logger::Logger::instance(logger_instance); return new app_service_rpc_plugin::AppServiceRpcPlugin(); } -extern "C" __attribute__((visibility("default"))) void Delete( - application_manager::plugin_manager::RPCPlugin* data) { +// cppcheck-suppress unusedFunction +extern "C" __attribute__((visibility("default"))) void Delete(RPCPlugin* data) { delete data; } |