summaryrefslogtreecommitdiff
path: root/src/components/application_manager/rpc_plugins/rc_rpc_plugin
diff options
context:
space:
mode:
authorConlain Kelly <conlain.k@gmail.com>2018-07-18 11:13:50 -0400
committerConlain Kelly <conlain.k@gmail.com>2018-07-18 11:13:50 -0400
commit5019af50b9a2236dd75e630aae5b82e440be9620 (patch)
treeadd78dac2559a43a8ee7d82159a01fc15a971c19 /src/components/application_manager/rpc_plugins/rc_rpc_plugin
parent4dde9552b3d9ab5fa29502810be48bdf0f793cd7 (diff)
downloadsdl_core-5019af50b9a2236dd75e630aae5b82e440be9620.tar.gz
Replace utils::SharedPtr with std::shared_ptr, remove non-standard usage
Diffstat (limited to 'src/components/application_manager/rpc_plugins/rc_rpc_plugin')
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_app_extension.h4
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/resource_allocation_manager.h2
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/hmi/rc_on_remote_control_settings_notification.cc2
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/on_interior_vehicle_data_notification.cc2
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_rpc_plugin.cc3
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/resource_allocation_manager_impl.cc12
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/button_press_request_test.cc24
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc24
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_interior_vehicle_data_notification_test.cc14
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_remote_control_settings_test.cc14
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/rc_get_interior_vehicle_data_consent_test.cc20
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/set_interior_vehicle_data_request_test.cc18
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/resource_allocation_manager_impl_test.cc28
13 files changed, 85 insertions, 82 deletions
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_app_extension.h b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_app_extension.h
index 05994492c2..72f29c7de1 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_app_extension.h
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_app_extension.h
@@ -35,6 +35,8 @@
#include <string>
#include <set>
+#include <memory>
+#include "utils/macro.h"
#include "application_manager/app_extension.h"
namespace rc_rpc_plugin {
@@ -78,7 +80,7 @@ class RCAppExtension : public application_manager::AppExtension {
resumption_data) OVERRIDE;
};
-typedef utils::SharedPtr<RCAppExtension> RCAppExtensionPtr;
+typedef std::shared_ptr<RCAppExtension> RCAppExtensionPtr;
} // namespace rc_rpc_plugin
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/resource_allocation_manager.h b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/resource_allocation_manager.h
index 20bd438494..91d1b09fca 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/resource_allocation_manager.h
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/resource_allocation_manager.h
@@ -34,7 +34,7 @@
#define SRC_COMPONENTS_REMOTE_CONTROL_INCLUDE_REMOTE_CONTROL_RESOURCE_ALLOCATION_H
#include <string>
#include "utils/macro.h"
-#include "utils/shared_ptr.h"
+
#include "interfaces/HMI_API.h"
#include "application_manager/plugin_manager/rpc_plugin.h"
#include "rc_rpc_plugin/rc_app_extension.h"
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/hmi/rc_on_remote_control_settings_notification.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/hmi/rc_on_remote_control_settings_notification.cc
index ca96b1cf97..7bc72faced 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/hmi/rc_on_remote_control_settings_notification.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/hmi/rc_on_remote_control_settings_notification.cc
@@ -105,7 +105,7 @@ void RCOnRemoteControlSettingsNotification::DisallowRCFunctionality() {
app->app_id(), mobile_apis::HMILevel::eType::HMI_NONE);
const RCAppExtensionPtr extension =
- application_manager::AppExtensionPtr::static_pointer_cast<
+ std::static_pointer_cast<
RCAppExtension>(app->QueryInterface(RCRPCPlugin::kRCPluginID));
if (extension) {
UnsubscribeFromInteriorVehicleDataForAllModules(extension);
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/on_interior_vehicle_data_notification.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/on_interior_vehicle_data_notification.cc
index dfe2feb622..8238e9a943 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/on_interior_vehicle_data_notification.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/on_interior_vehicle_data_notification.cc
@@ -71,7 +71,7 @@ void OnInteriorVehicleDataNotification::Run() {
application_manager::Application& app = **it;
RCAppExtensionPtr extension =
- application_manager::AppExtensionPtr::static_pointer_cast<
+ std::static_pointer_cast<
RCAppExtension>(app.QueryInterface(RCRPCPlugin::kRCPluginID));
DCHECK(extension);
LOG4CXX_TRACE(logger_,
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_rpc_plugin.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_rpc_plugin.cc
index 4378f1ea48..a562e45b1d 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_rpc_plugin.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_rpc_plugin.cc
@@ -35,6 +35,7 @@
#include "rc_rpc_plugin/rc_app_extension.h"
#include "rc_rpc_plugin/resource_allocation_manager_impl.h"
#include "utils/helpers.h"
+#include <memory>
namespace rc_rpc_plugin {
namespace plugins = application_manager::plugin_manager;
@@ -90,7 +91,7 @@ void RCRPCPlugin::OnApplicationEvent(
}
switch (event) {
case plugins::kApplicationRegistered: {
- application->AddExtension(new RCAppExtension(kRCPluginID));
+ application->AddExtension(std::shared_ptr<RCAppExtension>(new RCAppExtension(kRCPluginID)));
resource_allocation_manager_->SendOnRCStatusNotifications(
NotificationTrigger::APP_REGISTRATION, application);
break;
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/resource_allocation_manager_impl.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/resource_allocation_manager_impl.cc
index 450bf79fe7..01c2e3a7c6 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/resource_allocation_manager_impl.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/resource_allocation_manager_impl.cc
@@ -41,7 +41,7 @@
#include "rc_rpc_plugin/rc_module_constants.h"
#include "json/json.h"
#include "utils/helpers.h"
-#include "utils/make_shared.h"
+
namespace rc_rpc_plugin {
@@ -178,7 +178,7 @@ void ResourceAllocationManagerImpl::ProcessApplicationPolicyUpdate() {
if (!disallowed_modules.empty()) {
SendOnRCStatusNotifications(
NotificationTrigger::MODULE_ALLOCATION,
- utils::SharedPtr<application_manager::Application>());
+ std::shared_ptr<application_manager::Application>());
}
}
}
@@ -198,7 +198,7 @@ RCAppExtensionPtr ResourceAllocationManagerImpl::GetApplicationExtention(
}
rc_app_extension =
- application_manager::AppExtensionPtr::static_pointer_cast<RCAppExtension>(
+ std::static_pointer_cast<RCAppExtension>(
app_extension);
return rc_app_extension;
@@ -307,7 +307,7 @@ void ResourceAllocationManagerImpl::SetResourceAquired(
allocated_resources_[module_type] = app_id;
SendOnRCStatusNotifications(
NotificationTrigger::MODULE_ALLOCATION,
- utils::SharedPtr<application_manager::Application>());
+ std::shared_ptr<application_manager::Application>());
}
void ResourceAllocationManagerImpl::SendOnRCStatusNotifications(
@@ -343,7 +343,7 @@ void ResourceAllocationManagerImpl::set_rc_enabled(const bool value) {
is_rc_enabled_ = value;
SendOnRCStatusNotifications(
NotificationTrigger::RC_STATE_CHANGING,
- utils::SharedPtr<application_manager::Application>());
+ std::shared_ptr<application_manager::Application>());
}
void ResourceAllocationManagerImpl::SetResourceFree(
@@ -511,7 +511,7 @@ void ResourceAllocationManagerImpl::OnApplicationEvent(
if (!acquired_modules.empty()) {
SendOnRCStatusNotifications(
NotificationTrigger::MODULE_ALLOCATION,
- utils::SharedPtr<application_manager::Application>());
+ std::shared_ptr<application_manager::Application>());
}
Apps app_list;
app_list.push_back(application);
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/button_press_request_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/button_press_request_test.cc
index 7ab4819002..329f4de5a6 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/button_press_request_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/button_press_request_test.cc
@@ -41,8 +41,8 @@
#include "application_manager/mock_application_manager.h"
#include "application_manager/commands/command_request_test.h"
#include "application_manager/policies/mock_policy_handler_interface.h"
-#include "utils/shared_ptr.h"
-#include "utils/make_shared.h"
+
+
#include "interfaces/HMI_API.h"
#include "interfaces/MOBILE_API.h"
@@ -78,9 +78,9 @@ class ButtonPressRequestTest
public:
ButtonPressRequestTest()
: rc_capabilities_(smart_objects::SmartType_Map)
- , mock_app_(utils::MakeShared<NiceMock<MockApplication> >())
+ , mock_app_(std::make_shared<NiceMock<MockApplication> >())
, rc_app_extention_(
- utils::MakeShared<rc_rpc_plugin::RCAppExtension>(kModuleId)) {}
+ std::make_shared<rc_rpc_plugin::RCAppExtension>(kModuleId)) {}
smart_objects::SmartObject ButtonCapability(
const mobile_apis::ButtonName::eType button_name) {
@@ -147,10 +147,10 @@ class ButtonPressRequestTest
}
template <class Command>
- application_manager::SharedPtr<Command> CreateRCCommand(
+ std::shared_ptr<Command> CreateRCCommand(
MessageSharedPtr& msg) {
InitCommand(kDefaultTimeout_);
- return ::utils::MakeShared<Command>(msg ? msg : msg = CreateMessage(),
+ return std::make_shared<Command>(msg ? msg : msg = CreateMessage(),
app_mngr_,
mock_rpc_service_,
mock_hmi_capabilities_,
@@ -160,8 +160,8 @@ class ButtonPressRequestTest
protected:
smart_objects::SmartObject rc_capabilities_;
- utils::SharedPtr<MockApplication> mock_app_;
- utils::SharedPtr<rc_rpc_plugin::RCAppExtension> rc_app_extention_;
+ std::shared_ptr<MockApplication> mock_app_;
+ std::shared_ptr<rc_rpc_plugin::RCAppExtension> rc_app_extention_;
test::components::policy_test::MockPolicyHandlerInterface
mock_policy_handler_;
testing::NiceMock<rc_rpc_plugin_test::MockResourceAllocationManager>
@@ -195,7 +195,7 @@ TEST_F(ButtonPressRequestTest,
.WillOnce(Return(true));
// Act
- application_manager::SharedPtr<rc_rpc_plugin::commands::ButtonPressRequest>
+ std::shared_ptr<rc_rpc_plugin::commands::ButtonPressRequest>
command = CreateRCCommand<rc_rpc_plugin::commands::ButtonPressRequest>(
mobile_message);
ASSERT_TRUE(command->Init());
@@ -234,7 +234,7 @@ TEST_F(
.WillOnce(DoAll(SaveArg<0>(&command_result), Return(true)));
// Act
- application_manager::SharedPtr<rc_rpc_plugin::commands::ButtonPressRequest>
+ std::shared_ptr<rc_rpc_plugin::commands::ButtonPressRequest>
command = CreateRCCommand<rc_rpc_plugin::commands::ButtonPressRequest>(
mobile_message);
ASSERT_TRUE(command->Init());
@@ -273,7 +273,7 @@ TEST_F(ButtonPressRequestTest, OnEvent_ExpectSuccessfullResponseSentToMobile) {
application_manager::event_engine::Event event(
hmi_apis::FunctionID::Buttons_ButtonPress);
event.set_smart_object(*hmi_message);
- application_manager::SharedPtr<rc_rpc_plugin::commands::ButtonPressRequest>
+ std::shared_ptr<rc_rpc_plugin::commands::ButtonPressRequest>
command = CreateRCCommand<rc_rpc_plugin::commands::ButtonPressRequest>(
mobile_message);
command->on_event(event);
@@ -312,7 +312,7 @@ TEST_F(ButtonPressRequestTest,
application_manager::event_engine::Event event(
hmi_apis::FunctionID::Buttons_ButtonPress);
event.set_smart_object(*hmi_message);
- application_manager::SharedPtr<rc_rpc_plugin::commands::ButtonPressRequest>
+ std::shared_ptr<rc_rpc_plugin::commands::ButtonPressRequest>
command = CreateRCCommand<rc_rpc_plugin::commands::ButtonPressRequest>(
mobile_message);
command->on_event(event);
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc
index 685bc1fd42..8f69b29275 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc
@@ -40,8 +40,8 @@
#include "application_manager/event_engine/event_dispatcher.h"
#include "application_manager/commands/command_request_test.h"
#include "rc_rpc_plugin/mock/mock_resource_allocation_manager.h"
-#include "utils/shared_ptr.h"
-#include "utils/make_shared.h"
+
+
using ::testing::_;
using ::testing::Mock;
@@ -76,8 +76,8 @@ class GetInteriorVehicleDataRequestTest
: public CommandRequestTest<CommandsTestMocks::kIsNice> {
public:
GetInteriorVehicleDataRequestTest()
- : mock_app_(utils::MakeShared<NiceMock<MockApplication> >())
- , rc_app_extention_(utils::MakeShared<RCAppExtension>(kModuleId)) {
+ : mock_app_(std::make_shared<NiceMock<MockApplication> >())
+ , rc_app_extention_(std::make_shared<RCAppExtension>(kModuleId)) {
ON_CALL(*mock_app_, app_id()).WillByDefault(Return(kAppId));
ON_CALL(app_mngr_, hmi_interfaces())
.WillByDefault(ReturnRef(mock_hmi_interfaces_));
@@ -116,10 +116,10 @@ class GetInteriorVehicleDataRequestTest
return message;
}
template <class Command>
- application_manager::SharedPtr<Command> CreateRCCommand(
+ std::shared_ptr<Command> CreateRCCommand(
MessageSharedPtr& msg) {
InitCommand(kDefaultTimeout_);
- return ::utils::MakeShared<Command>(msg ? msg : msg = CreateMessage(),
+ return std::make_shared<Command>(msg ? msg : msg = CreateMessage(),
app_mngr_,
mock_rpc_service_,
mock_hmi_capabilities_,
@@ -129,8 +129,8 @@ class GetInteriorVehicleDataRequestTest
protected:
smart_objects::SmartObject rc_capabilities_;
- utils::SharedPtr<MockApplication> mock_app_;
- utils::SharedPtr<RCAppExtension> rc_app_extention_;
+ std::shared_ptr<MockApplication> mock_app_;
+ std::shared_ptr<RCAppExtension> rc_app_extention_;
testing::NiceMock<rc_rpc_plugin_test::MockResourceAllocationManager>
mock_allocation_manager_;
};
@@ -145,7 +145,7 @@ TEST_F(GetInteriorVehicleDataRequestTest,
hmi_apis::FunctionID::RC_GetInteriorVehicleData)))
.WillOnce(Return(true));
MessageSharedPtr mobile_message = CreateBasicMessage();
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::GetInteriorVehicleDataRequest> command =
CreateRCCommand<rc_rpc_plugin::commands::GetInteriorVehicleDataRequest>(
mobile_message);
@@ -170,7 +170,7 @@ TEST_F(
ManageMobileCommand(
MobileResultCodeIs(mobile_apis::Result::UNSUPPORTED_RESOURCE), _))
.WillOnce(DoAll(SaveArg<0>(&command_result), Return(true)));
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::GetInteriorVehicleDataRequest> command =
CreateRCCommand<rc_rpc_plugin::commands::GetInteriorVehicleDataRequest>(
mobile_message);
@@ -201,7 +201,7 @@ TEST_F(GetInteriorVehicleDataRequestTest,
application_manager::event_engine::Event event(
hmi_apis::FunctionID::RC_GetInteriorVehicleData);
event.set_smart_object(*hmi_message);
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::GetInteriorVehicleDataRequest> command =
CreateRCCommand<rc_rpc_plugin::commands::GetInteriorVehicleDataRequest>(
mobile_message);
@@ -231,7 +231,7 @@ TEST_F(GetInteriorVehicleDataRequestTest,
application_manager::event_engine::Event event(
hmi_apis::FunctionID::RC_GetInteriorVehicleData);
event.set_smart_object(*hmi_message);
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::GetInteriorVehicleDataRequest> command =
CreateRCCommand<rc_rpc_plugin::commands::GetInteriorVehicleDataRequest>(
mobile_message);
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_interior_vehicle_data_notification_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_interior_vehicle_data_notification_test.cc
index 78d20c6b13..690586d0e1 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_interior_vehicle_data_notification_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_interior_vehicle_data_notification_test.cc
@@ -66,7 +66,7 @@ class OnInteriorVehicleDataNotificationTest
: public CommandsTest<CommandsTestMocks::kIsNice> {
public:
OnInteriorVehicleDataNotificationTest()
- : mock_app_(utils::MakeShared<NiceMock<MockApplication> >()) {}
+ : mock_app_(std::make_shared<NiceMock<MockApplication> >()) {}
MessageSharedPtr CreateBasicMessage() {
MessageSharedPtr message = CreateMessage();
@@ -85,10 +85,10 @@ class OnInteriorVehicleDataNotificationTest
}
template <class Command>
- application_manager::SharedPtr<Command> CreateRCCommand(
+ std::shared_ptr<Command> CreateRCCommand(
MessageSharedPtr& msg) {
InitCommand(kDefaultTimeout_);
- return ::utils::MakeShared<Command>(msg ? msg : msg = CreateMessage(),
+ return std::make_shared<Command>(msg ? msg : msg = CreateMessage(),
app_mngr_,
mock_rpc_service_,
mock_hmi_capabilities_,
@@ -97,7 +97,7 @@ class OnInteriorVehicleDataNotificationTest
}
protected:
- utils::SharedPtr<MockApplication> mock_app_;
+ std::shared_ptr<MockApplication> mock_app_;
testing::NiceMock<rc_rpc_plugin_test::MockResourceAllocationManager>
mock_allocation_manager_;
};
@@ -115,7 +115,7 @@ TEST_F(OnInteriorVehicleDataNotificationTest,
EXPECT_CALL(app_mngr_, applications()).WillOnce(Return(accessor));
RCAppExtensionPtr rc_extention_ptr =
- utils::MakeShared<RCAppExtension>(application_manager::AppExtensionUID(
+ std::make_shared<RCAppExtension>(application_manager::AppExtensionUID(
rc_rpc_plugin::RCRPCPlugin::kRCPluginID));
rc_extention_ptr->SubscribeToInteriorVehicleData(enums_value::kClimate);
ON_CALL(*mock_app_, QueryInterface(_))
@@ -126,14 +126,14 @@ TEST_F(OnInteriorVehicleDataNotificationTest,
EXPECT_CALL(mock_rpc_service_, SendMessageToMobile(_, false))
.WillOnce(SaveArg<0>(&message));
// Act
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::OnInteriorVehicleDataNotification> command =
CreateRCCommand<
rc_rpc_plugin::commands::OnInteriorVehicleDataNotification>(
mobile_message);
command->Run();
// Assertions
- ASSERT_TRUE(message);
+ ASSERT_TRUE((bool)message);
Mock::VerifyAndClearExpectations(&app_mngr_);
}
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_remote_control_settings_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_remote_control_settings_test.cc
index f3ac768a4e..907292f150 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_remote_control_settings_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/on_remote_control_settings_test.cc
@@ -67,7 +67,7 @@ class RCOnRemoteControlSettingsNotificationTest
: public CommandsTest<CommandsTestMocks::kIsNice> {
public:
RCOnRemoteControlSettingsNotificationTest()
- : mock_app_(utils::MakeShared<NiceMock<MockApplication> >()) {}
+ : mock_app_(std::make_shared<NiceMock<MockApplication> >()) {}
MessageSharedPtr CreateBasicMessage() {
MessageSharedPtr message = CreateMessage();
(*message)[application_manager::strings::params]
@@ -85,10 +85,10 @@ class RCOnRemoteControlSettingsNotificationTest
}
template <class Command>
- application_manager::SharedPtr<Command> CreateRCCommand(
+ std::shared_ptr<Command> CreateRCCommand(
MessageSharedPtr& msg) {
InitCommand(kDefaultTimeout_);
- return ::utils::MakeShared<Command>(msg ? msg : msg = CreateMessage(),
+ return std::make_shared<Command>(msg ? msg : msg = CreateMessage(),
app_mngr_,
mock_rpc_service_,
mock_hmi_capabilities_,
@@ -97,7 +97,7 @@ class RCOnRemoteControlSettingsNotificationTest
}
protected:
- utils::SharedPtr<MockApplication> mock_app_;
+ std::shared_ptr<MockApplication> mock_app_;
testing::NiceMock<rc_rpc_plugin_test::MockResourceAllocationManager>
mock_allocation_manager_;
};
@@ -116,7 +116,7 @@ TEST_F(RCOnRemoteControlSettingsNotificationTest,
EXPECT_CALL(mock_allocation_manager_,
SetAccessMode(hmi_apis::Common_RCAccessMode::ASK_DRIVER));
// Act
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::RCOnRemoteControlSettingsNotification> command =
CreateRCCommand<
rc_rpc_plugin::commands::RCOnRemoteControlSettingsNotification>(
@@ -141,7 +141,7 @@ TEST_F(RCOnRemoteControlSettingsNotificationTest,
EXPECT_CALL(app_mngr_, applications()).WillOnce(Return(accessor));
RCAppExtensionPtr rc_extention_ptr =
- utils::MakeShared<RCAppExtension>(application_manager::AppExtensionUID(
+ std::make_shared<RCAppExtension>(application_manager::AppExtensionUID(
rc_rpc_plugin::RCRPCPlugin::kRCPluginID));
rc_extention_ptr->SubscribeToInteriorVehicleData(enums_value::kClimate);
ON_CALL(*mock_app_, QueryInterface(_))
@@ -150,7 +150,7 @@ TEST_F(RCOnRemoteControlSettingsNotificationTest,
EXPECT_CALL(mock_allocation_manager_, ResetAllAllocations());
// Act
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::RCOnRemoteControlSettingsNotification> command =
CreateRCCommand<
rc_rpc_plugin::commands::RCOnRemoteControlSettingsNotification>(
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/rc_get_interior_vehicle_data_consent_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/rc_get_interior_vehicle_data_consent_test.cc
index c5a8e54c6d..a1fff199ee 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/rc_get_interior_vehicle_data_consent_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/rc_get_interior_vehicle_data_consent_test.cc
@@ -53,7 +53,7 @@
#include "interfaces/MOBILE_API.h"
#include "include/test/protocol_handler/mock_protocol_handler.h"
#include "test/application_manager/mock_application_manager_settings.h"
-#include "utils/make_shared.h"
+
using ::testing::_;
using ::testing::Return;
@@ -62,7 +62,7 @@ using ::testing::NiceMock;
using ::testing::SaveArg;
using ::testing::Mock;
using ::testing::NiceMock;
-using ::utils::SharedPtr;
+
namespace am = ::application_manager;
using am::ApplicationSet;
using am::commands::MessageSharedPtr;
@@ -99,7 +99,7 @@ class RCGetInteriorVehicleDataConsentTest
: public CommandRequestTest<CommandsTestMocks::kIsNice> {
public:
RCGetInteriorVehicleDataConsentTest()
- : mock_app_(utils::MakeShared<NiceMock<MockApplication> >())
+ : mock_app_(std::make_shared<NiceMock<MockApplication> >())
, command_holder(app_mngr_)
, request_controller(mock_request_controler)
, rpc_service(app_mngr_,
@@ -107,9 +107,9 @@ class RCGetInteriorVehicleDataConsentTest
&mock_protocol_handler,
&mock_hmi_handler,
command_holder)
- , rc_app_extention_(utils::MakeShared<RCAppExtension>(kPluginID))
+ , rc_app_extention_(std::make_shared<RCAppExtension>(kPluginID))
, mock_rpc_plugin_manager(
- utils::MakeShared<NiceMock<MockRPCPluginManager> >())
+ std::make_shared<NiceMock<MockRPCPluginManager> >())
, rpc_plugin(mock_rpc_plugin)
, optional_mock_rpc_plugin(mock_rpc_plugin) {
ON_CALL(*mock_app_, app_id()).WillByDefault(Return(kAppId));
@@ -146,10 +146,10 @@ class RCGetInteriorVehicleDataConsentTest
}
template <class Command>
- application_manager::SharedPtr<Command> CreateRCCommand(
+ std::shared_ptr<Command> CreateRCCommand(
MessageSharedPtr& msg) {
InitCommand(kDefaultTimeout_);
- return ::utils::MakeShared<Command>(msg ? msg : msg = CreateMessage(),
+ return std::make_shared<Command>(msg ? msg : msg = CreateMessage(),
app_mngr_,
rpc_service,
mock_hmi_capabilities_,
@@ -170,7 +170,7 @@ class RCGetInteriorVehicleDataConsentTest
}
protected:
- utils::SharedPtr<MockApplication> mock_app_;
+ std::shared_ptr<MockApplication> mock_app_;
MockRequestControlerSettings mock_request_controler;
MockProtocolHandler mock_protocol_handler;
MockHMIMessageHandler mock_hmi_handler;
@@ -182,8 +182,8 @@ class RCGetInteriorVehicleDataConsentTest
MockCommandFactory mock_command_factory;
am::request_controller::RequestController request_controller;
am::rpc_service::RPCServiceImpl rpc_service;
- utils::SharedPtr<RCAppExtension> rc_app_extention_;
- utils::SharedPtr<am::plugin_manager::MockRPCPluginManager>
+ std::shared_ptr<RCAppExtension> rc_app_extention_;
+ std::shared_ptr<am::plugin_manager::MockRPCPluginManager>
mock_rpc_plugin_manager;
utils::Optional<RPCPlugin> rpc_plugin;
utils::Optional<MockRPCPlugin> optional_mock_rpc_plugin;
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/set_interior_vehicle_data_request_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/set_interior_vehicle_data_request_test.cc
index 1d5e63e2df..fdee55a30c 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/set_interior_vehicle_data_request_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/set_interior_vehicle_data_request_test.cc
@@ -64,8 +64,8 @@ class SetInteriorVehicleDataRequestTest
: public CommandRequestTest<CommandsTestMocks::kIsNice> {
public:
SetInteriorVehicleDataRequestTest()
- : mock_app_(utils::MakeShared<NiceMock<MockApplication> >())
- , rc_app_extention_(utils::MakeShared<RCAppExtension>(kModuleId)) {}
+ : mock_app_(std::make_shared<NiceMock<MockApplication> >())
+ , rc_app_extention_(std::make_shared<RCAppExtension>(kModuleId)) {}
void SetUp() OVERRIDE {
ON_CALL(app_mngr_, hmi_interfaces())
@@ -106,10 +106,10 @@ class SetInteriorVehicleDataRequestTest
}
template <class Command>
- application_manager::SharedPtr<Command> CreateRCCommand(
+ std::shared_ptr<Command> CreateRCCommand(
MessageSharedPtr& msg) {
InitCommand(kDefaultTimeout_);
- return ::utils::MakeShared<Command>(msg ? msg : msg = CreateMessage(),
+ return std::make_shared<Command>(msg ? msg : msg = CreateMessage(),
app_mngr_,
mock_rpc_service_,
mock_hmi_capabilities_,
@@ -120,8 +120,8 @@ class SetInteriorVehicleDataRequestTest
protected:
testing::NiceMock<rc_rpc_plugin_test::MockResourceAllocationManager>
mock_allocation_manager_;
- utils::SharedPtr<MockApplication> mock_app_;
- utils::SharedPtr<RCAppExtension> rc_app_extention_;
+ std::shared_ptr<MockApplication> mock_app_;
+ std::shared_ptr<RCAppExtension> rc_app_extention_;
};
TEST_F(SetInteriorVehicleDataRequestTest,
@@ -147,7 +147,7 @@ TEST_F(SetInteriorVehicleDataRequestTest,
mobile_apis::Result::READ_ONLY),
application_manager::commands::Command::SOURCE_SDL));
// Act
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::SetInteriorVehicleDataRequest> command =
CreateRCCommand<rc_rpc_plugin::commands::SetInteriorVehicleDataRequest>(
mobile_message);
@@ -186,7 +186,7 @@ TEST_F(
application_manager::commands::Command::SOURCE_SDL));
// Act
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::SetInteriorVehicleDataRequest> command =
CreateRCCommand<rc_rpc_plugin::commands::SetInteriorVehicleDataRequest>(
mobile_message);
@@ -217,7 +217,7 @@ TEST_F(
application_manager::commands::Command::SOURCE_SDL));
// Act
- application_manager::SharedPtr<
+ std::shared_ptr<
rc_rpc_plugin::commands::SetInteriorVehicleDataRequest> command =
CreateRCCommand<rc_rpc_plugin::commands::SetInteriorVehicleDataRequest>(
mobile_message);
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/resource_allocation_manager_impl_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/resource_allocation_manager_impl_test.cc
index 28142f0b4e..3842814f84 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/resource_allocation_manager_impl_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/resource_allocation_manager_impl_test.cc
@@ -39,8 +39,8 @@
#include "application_manager/mock_application_manager.h"
#include "application_manager/mock_rpc_service.h"
#include "application_manager/policies/mock_policy_handler_interface.h"
-#include "utils/shared_ptr.h"
-#include "utils/make_shared.h"
+
+
#include "interfaces/HMI_API.h"
#include "interfaces/MOBILE_API.h"
@@ -83,16 +83,16 @@ using namespace rc_rpc_plugin;
class RAManagerTest : public ::testing::Test {
public:
RAManagerTest()
- : message_(utils::MakeShared<Message>(MessagePriority::FromServiceType(
+ : message_(std::make_shared<Message>(MessagePriority::FromServiceType(
protocol_handler::ServiceType::kRpc)))
- , mock_app_1_(utils::MakeShared<NiceMock<MockApplication> >())
- , mock_app_2_(utils::MakeShared<NiceMock<MockApplication> >())
+ , mock_app_1_(std::make_shared<NiceMock<MockApplication> >())
+ , mock_app_2_(std::make_shared<NiceMock<MockApplication> >())
, apps_lock_ptr_(std::make_shared<sync_primitives::Lock>())
, apps_da_(apps_, apps_lock_ptr_) {
ON_CALL(mock_app_mngr_, GetPolicyHandler())
.WillByDefault(ReturnRef(mock_policy_handler_));
auto plugin_id = rc_rpc_plugin::RCRPCPlugin::kRCPluginID;
- app_ext_ptr_ = utils::MakeShared<rc_rpc_plugin::RCAppExtension>(plugin_id);
+ app_ext_ptr_ = std::make_shared<rc_rpc_plugin::RCAppExtension>(plugin_id);
ON_CALL(*mock_app_1_, app_id()).WillByDefault(Return(kAppId1));
OnRCStatusNotificationExpectations();
@@ -114,8 +114,8 @@ class RAManagerTest : public ::testing::Test {
application_manager::MessagePtr message_;
application_manager::AppExtensionPtr app_ext_ptr_;
- utils::SharedPtr<NiceMock<MockApplication> > mock_app_1_;
- utils::SharedPtr<NiceMock<MockApplication> > mock_app_2_;
+ std::shared_ptr<NiceMock<MockApplication> > mock_app_1_;
+ std::shared_ptr<NiceMock<MockApplication> > mock_app_2_;
application_manager::ApplicationSet apps_;
std::shared_ptr<sync_primitives::Lock> apps_lock_ptr_;
DataAccessor<application_manager::ApplicationSet> apps_da_;
@@ -301,7 +301,7 @@ TEST_F(RAManagerTest, AnotherAppExit_NoReleaseResource) {
.WillRepeatedly(Return(mock_app_2_));
RCAppExtensionPtr rc_extention_ptr =
- utils::MakeShared<RCAppExtension>(application_manager::AppExtensionUID(
+ std::make_shared<RCAppExtension>(application_manager::AppExtensionUID(
rc_rpc_plugin::RCRPCPlugin::kRCPluginID));
EXPECT_CALL(*mock_app_2_, QueryInterface(_))
@@ -327,7 +327,7 @@ TEST_F(RAManagerTest, AppUnregistered_ReleaseResource) {
ra_manager.SetAccessMode(hmi_apis::Common_RCAccessMode::eType::AUTO_DENY);
RCAppExtensionPtr rc_extention_ptr =
- utils::MakeShared<RCAppExtension>(application_manager::AppExtensionUID(
+ std::make_shared<RCAppExtension>(application_manager::AppExtensionUID(
rc_rpc_plugin::RCRPCPlugin::kRCPluginID));
EXPECT_EQ(rc_rpc_plugin::AcquireResult::ALLOWED,
@@ -361,7 +361,7 @@ TEST_F(RAManagerTest, AnotherAppUnregistered_NoReleaseResource) {
.WillRepeatedly(Return(mock_app_2_));
RCAppExtensionPtr rc_extention_ptr =
- utils::MakeShared<RCAppExtension>(application_manager::AppExtensionUID(
+ std::make_shared<RCAppExtension>(application_manager::AppExtensionUID(
rc_rpc_plugin::RCRPCPlugin::kRCPluginID));
EXPECT_CALL(*mock_app_2_, QueryInterface(_))
@@ -404,7 +404,7 @@ TEST_F(RAManagerTest, AppsDisallowed_ReleaseAllResources) {
EXPECT_CALL(mock_app_mngr_, applications()).WillRepeatedly(Return(apps_da));
RCAppExtensionPtr rc_extention_ptr =
- utils::MakeShared<RCAppExtension>(application_manager::AppExtensionUID(
+ std::make_shared<RCAppExtension>(application_manager::AppExtensionUID(
rc_rpc_plugin::RCRPCPlugin::kRCPluginID));
EXPECT_CALL(*mock_app_1_, QueryInterface(RCRPCPlugin::kRCPluginID))
@@ -434,7 +434,7 @@ TEST_F(RAManagerTest, AppGotRevokedModulesWithPTU_ReleaseRevokedResource) {
.WillRepeatedly(Return(mock_app_1_));
RCAppExtensionPtr rc_extention_ptr =
- utils::MakeShared<rc_rpc_plugin::RCAppExtension>(
+ std::make_shared<rc_rpc_plugin::RCAppExtension>(
application_manager::AppExtensionUID(
rc_rpc_plugin::RCRPCPlugin::kRCPluginID));
@@ -659,7 +659,7 @@ TEST_F(RAManagerTest, OnRCStatus_ModuleAllocation) {
// Act
ra_manager.SendOnRCStatusNotifications(
NotificationTrigger::MODULE_ALLOCATION,
- utils::SharedPtr<application_manager::Application>());
+ std::shared_ptr<application_manager::Application>());
auto msg_to_mob_params =
(*message_to_mob)[application_manager::strings::msg_params];