summaryrefslogtreecommitdiff
path: root/src/components/smart_objects/include/smart_objects/enum_schema_item.h
diff options
context:
space:
mode:
authorJackLivio <jack@livio.io>2018-08-14 11:33:12 -0400
committerJackLivio <jack@livio.io>2018-08-14 11:33:12 -0400
commit0db99f84ab344b82fab71200e43b67adbb2e2575 (patch)
treed1d532d0d90dd51a049bdf939460494af4d08ff4 /src/components/smart_objects/include/smart_objects/enum_schema_item.h
parente9c323f25a721ca5367c4ff125e1565dcade33a9 (diff)
downloadsdl_core-0db99f84ab344b82fab71200e43b67adbb2e2575.tar.gz
Remove redundant function validate
Diffstat (limited to 'src/components/smart_objects/include/smart_objects/enum_schema_item.h')
-rw-r--r--src/components/smart_objects/include/smart_objects/enum_schema_item.h38
1 files changed, 2 insertions, 36 deletions
diff --git a/src/components/smart_objects/include/smart_objects/enum_schema_item.h b/src/components/smart_objects/include/smart_objects/enum_schema_item.h
index 23532f1bbe..41102933f3 100644
--- a/src/components/smart_objects/include/smart_objects/enum_schema_item.h
+++ b/src/components/smart_objects/include/smart_objects/enum_schema_item.h
@@ -109,14 +109,6 @@ class TEnumSchemaItem : public CDefaultSchemaItem<EnumType> {
* @return NsSmartObjects::Errors::eType
**/
Errors::eType validate(const SmartObject& Object) OVERRIDE;
- /**
- * @brief Validate smart object.
- * @param Object Object to validate.
- * @param report__ object for reporting errors during validation
- * @return NsSmartObjects::Errors::eType
- **/
- Errors::eType validate(const SmartObject& Object,
- rpc::ValidationReport* report__) OVERRIDE;
/**
* @brief Validate smart object.
@@ -127,7 +119,8 @@ class TEnumSchemaItem : public CDefaultSchemaItem<EnumType> {
**/
Errors::eType validate(const SmartObject& Object,
rpc::ValidationReport* report__,
- const utils::SemanticVersion& MessageVersion) OVERRIDE;
+ const utils::SemanticVersion& MessageVersion =
+ utils::SemanticVersion()) OVERRIDE;
/**
* @brief Return the correct history signature based on message version.
* @param signatures Vector reference of enums history items.
@@ -299,33 +292,6 @@ Errors::eType TEnumSchemaItem<EnumType>::validate(const SmartObject& Object) {
}
template <typename EnumType>
-Errors::eType TEnumSchemaItem<EnumType>::validate(
- const SmartObject& Object, rpc::ValidationReport* report__) {
- if (SmartType_Integer != Object.getType()) {
- std::string validation_info;
- if (SmartType_String == Object.getType()) {
- validation_info = "Invalid enum value: " + Object.asString();
- } else {
- validation_info = "Incorrect type, expected: " +
- SmartObject::typeToString(SmartType_Integer) +
- " (enum), got: " +
- SmartObject::typeToString(Object.getType());
- }
- report__->set_validation_info(validation_info);
- return Errors::INVALID_VALUE;
- }
- if (mAllowedElements.find(static_cast<EnumType>(Object.asInt())) ==
- mAllowedElements.end()) {
- std::stringstream stream;
- stream << "Invalid enum value: " << Object.asInt();
- std::string validation_info = stream.str();
- report__->set_validation_info(validation_info);
- return Errors::OUT_OF_RANGE;
- }
- return Errors::OK;
-}
-
-template <typename EnumType>
const ElementSignature TEnumSchemaItem<EnumType>::getSignature(
const std::vector<ElementSignature>& signatures,
const utils::SemanticVersion& MessageVersion) {