diff options
| author | JackLivio <jack@livio.io> | 2018-08-07 11:44:44 -0400 |
|---|---|---|
| committer | JackLivio <jack@livio.io> | 2018-08-07 11:44:44 -0400 |
| commit | 8a5be2b85c5c37b5b2d2b304f0816eda6f05352b (patch) | |
| tree | 2381fc762ca9d0713caa7141dfac7e77a4af85af /src/components/smart_objects/test/CObjectSchemaItem_test.cc | |
| parent | 72db7065480b1596cf8c04065ef066944ead4a2f (diff) | |
| download | sdl_core-8a5be2b85c5c37b5b2d2b304f0816eda6f05352b.tar.gz | |
Update based on comments
Diffstat (limited to 'src/components/smart_objects/test/CObjectSchemaItem_test.cc')
| -rw-r--r-- | src/components/smart_objects/test/CObjectSchemaItem_test.cc | 39 |
1 files changed, 30 insertions, 9 deletions
diff --git a/src/components/smart_objects/test/CObjectSchemaItem_test.cc b/src/components/smart_objects/test/CObjectSchemaItem_test.cc index c49a1bb302..5a0dcefa10 100644 --- a/src/components/smart_objects/test/CObjectSchemaItem_test.cc +++ b/src/components/smart_objects/test/CObjectSchemaItem_test.cc @@ -140,12 +140,32 @@ class ObjectSchemaItemTest : public ::testing::Test { // Create fake param that has breaking history changes std::vector<CObjectSchemaItem::SMember> fake_param_history_vector; - std::shared_ptr<ISchemaItem> fake_param_SchemaItem = CArraySchemaItem::create(CStringSchemaItem::create(TSchemaItemParameter<size_t>(1), TSchemaItemParameter<size_t>(99), TSchemaItemParameter<std::string>()), TSchemaItemParameter<size_t>(1), TSchemaItemParameter<size_t>(100)); - - std::shared_ptr<ISchemaItem> fake_param_history_v1_SchemaItem = CArraySchemaItem::create(CStringSchemaItem::create(TSchemaItemParameter<size_t>(1), TSchemaItemParameter<size_t>(99), TSchemaItemParameter<std::string>()), TSchemaItemParameter<size_t>(1), TSchemaItemParameter<size_t>(100)); - - fake_param_history_vector.push_back(CObjectSchemaItem::SMember(fake_param_history_v1_SchemaItem, true, "", "4.5.0", false, false)); - schemaMembersMap["fakeParam"] = CObjectSchemaItem::SMember(fake_param_SchemaItem, false, "4.5.0", "", false, false, fake_param_history_vector); + std::shared_ptr<ISchemaItem> fake_param_SchemaItem = + CArraySchemaItem::create( + CStringSchemaItem::create(TSchemaItemParameter<size_t>(1), + TSchemaItemParameter<size_t>(99), + TSchemaItemParameter<std::string>()), + TSchemaItemParameter<size_t>(1), + TSchemaItemParameter<size_t>(100)); + + std::shared_ptr<ISchemaItem> fake_param_history_v1_SchemaItem = + CArraySchemaItem::create( + CStringSchemaItem::create(TSchemaItemParameter<size_t>(1), + TSchemaItemParameter<size_t>(99), + TSchemaItemParameter<std::string>()), + TSchemaItemParameter<size_t>(1), + TSchemaItemParameter<size_t>(100)); + + fake_param_history_vector.push_back(CObjectSchemaItem::SMember( + fake_param_history_v1_SchemaItem, true, "", "4.5.0", false, false)); + schemaMembersMap["fakeParam"] = + CObjectSchemaItem::SMember(fake_param_SchemaItem, + false, + "4.5.0", + "", + false, + false, + fake_param_history_vector); CObjectSchemaItem::Members rootMembersMap; rootMembersMap[S_PARAMS] = CObjectSchemaItem::SMember( @@ -180,7 +200,7 @@ TEST_F(ObjectSchemaItemTest, validation_correct_with_new_version) { obj[S_MSG_PARAMS][Keys::INFO] = "0123456789"; obj[S_MSG_PARAMS][Keys::SUCCESS] = true; - utils::SemanticVersion messageVersion(4,5,0); + utils::SemanticVersion messageVersion(4, 5, 0); rpc::ValidationReport report("RPC"); EXPECT_EQ(Errors::OK, schema_item->validate(obj, &report, messageVersion)); EXPECT_EQ(std::string(""), rpc::PrettyFormat(report)); @@ -195,9 +215,10 @@ TEST_F(ObjectSchemaItemTest, validation_invalid_data_with_old_version) { obj[S_MSG_PARAMS][Keys::INFO] = "0123456789"; obj[S_MSG_PARAMS][Keys::SUCCESS] = true; - utils::SemanticVersion messageVersion(3,0,0); + utils::SemanticVersion messageVersion(3, 0, 0); rpc::ValidationReport report("RPC"); - EXPECT_EQ(Errors::MISSING_MANDATORY_PARAMETER, schema_item->validate(obj, &report, messageVersion)); + EXPECT_EQ(Errors::MISSING_MANDATORY_PARAMETER, + schema_item->validate(obj, &report, messageVersion)); } TEST_F(ObjectSchemaItemTest, validation_correct_skip_not_mandatory) { |