diff options
Diffstat (limited to 'src/components/hmi_message_handler/src')
5 files changed, 51 insertions, 52 deletions
diff --git a/src/components/hmi_message_handler/src/dbus_message_adapter.cc b/src/components/hmi_message_handler/src/dbus_message_adapter.cc index a79674df67..c08f090f1d 100644 --- a/src/components/hmi_message_handler/src/dbus_message_adapter.cc +++ b/src/components/hmi_message_handler/src/dbus_message_adapter.cc @@ -86,7 +86,7 @@ void DBusMessageAdapter::SendMessageToHMI(MessageSharedPointer message) { break; case hmi_apis::messageType::INVALID_ENUM: default: - LOG4CXX_INFO(logger_, "Message type is invalid"); + LOG4CXX_WARN(logger_, "Message type is invalid"); } } @@ -156,7 +156,7 @@ void DBusMessageAdapter::SubscribeTo() { } void DBusMessageAdapter::SendMessageToCore(const smart_objects::SmartObject& obj) { - LOG4CXX_INFO(logger_, "DBusMessageAdapter::SendMessageToCore"); + LOG4CXX_AUTO_TRACE(logger_); if (!handler()) { LOG4CXX_WARN(logger_, "DBusMessageAdapter hasn't handler"); diff --git a/src/components/hmi_message_handler/src/hmi_message_adapter.cc b/src/components/hmi_message_handler/src/hmi_message_adapter.cc index 343f13f00a..d8c280bea7 100644 --- a/src/components/hmi_message_handler/src/hmi_message_adapter.cc +++ b/src/components/hmi_message_handler/src/hmi_message_adapter.cc @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2013, Ford Motor Company * All rights reserved. * diff --git a/src/components/hmi_message_handler/src/hmi_message_handler_impl.cc b/src/components/hmi_message_handler/src/hmi_message_handler_impl.cc index ed37ee677c..887d145617 100644 --- a/src/components/hmi_message_handler/src/hmi_message_handler_impl.cc +++ b/src/components/hmi_message_handler/src/hmi_message_handler_impl.cc @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2013, Ford Motor Company * All rights reserved. * diff --git a/src/components/hmi_message_handler/src/messagebroker_adapter.cc b/src/components/hmi_message_handler/src/messagebroker_adapter.cc index 8779d2ea6d..d0dd5c09ba 100644 --- a/src/components/hmi_message_handler/src/messagebroker_adapter.cc +++ b/src/components/hmi_message_handler/src/messagebroker_adapter.cc @@ -1,4 +1,4 @@ -/** +/* * Copyright (c) 2013, Ford Motor Company * All rights reserved. * @@ -74,17 +74,17 @@ void MessageBrokerAdapter::SendMessageToHMI( void MessageBrokerAdapter::processResponse(std::string method, Json::Value& root) { - LOG4CXX_INFO(logger_, "MessageBrokerAdapter::processResponse"); + LOG4CXX_AUTO_TRACE(logger_); ProcessRecievedFromMB(root); } void MessageBrokerAdapter::processRequest(Json::Value& root) { - LOG4CXX_INFO(logger_, "MessageBrokerAdapter::processRequest"); + LOG4CXX_AUTO_TRACE(logger_); ProcessRecievedFromMB(root); } void MessageBrokerAdapter::processNotification(Json::Value& root) { - LOG4CXX_INFO(logger_, "MessageBrokerAdapter::processNotification"); + LOG4CXX_AUTO_TRACE(logger_); ProcessRecievedFromMB(root); } @@ -137,13 +137,15 @@ void MessageBrokerAdapter::SubscribeTo() { void* MessageBrokerAdapter::SubscribeAndBeginReceiverThread(void* param) { PassToThread(threads::Thread::CurrentId()); + // For PASA we don't need to subscribe and register controller + // this will prevent from errors on start up registerController(); SubscribeTo(); return MethodForReceiverThread(param); } void MessageBrokerAdapter::ProcessRecievedFromMB(Json::Value& root) { - LOG4CXX_INFO(logger_, "MessageBrokerAdapter::ProcessRecievedFromMB"); + LOG4CXX_AUTO_TRACE(logger_); if (root.isNull()) { // LOG return; diff --git a/src/components/hmi_message_handler/src/mqueue_adapter.cc b/src/components/hmi_message_handler/src/mqueue_adapter.cc index b1524b5f03..825c27c048 100644 --- a/src/components/hmi_message_handler/src/mqueue_adapter.cc +++ b/src/components/hmi_message_handler/src/mqueue_adapter.cc @@ -1,34 +1,34 @@ /* -* Copyright (c) 2014, Ford Motor Company -* All rights reserved. -* -* Redistribution and use in source and binary forms, with or without -* modification, are permitted provided that the following conditions are met: -* -* Redistributions of source code must retain the above copyright notice, this -* list of conditions and the following disclaimer. -* -* Redistributions in binary form must reproduce the above copyright notice, -* this list of conditions and the following -* disclaimer in the documentation and/or other materials provided with the -* distribution. -* -* Neither the name of the Ford Motor Company nor the names of its contributors -* may be used to endorse or promote products derived from this software -* without specific prior written permission. -* -* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" -* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE -* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE -* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE -* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR -* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF -* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS -* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN -* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) -* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE -* POSSIBILITY OF SUCH DAMAGE. -*/ + * Copyright (c) 2014, Ford Motor Company + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following + * disclaimer in the documentation and/or other materials provided with the + * distribution. + * + * Neither the name of the Ford Motor Company nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + */ #include "hmi_message_handler/mqueue_adapter.h" #include "hmi_message_handler/hmi_message_handler.h" @@ -61,7 +61,7 @@ class ReceiverThreadDelegate : public threads::ThreadDelegate { continue; } const std::string message_string(buffer, buffer + size); - LOG4CXX_INFO(logger_, "Message: " << message_string); + LOG4CXX_DEBUG(logger_, "Message: " << message_string); MessageSharedPointer message(new application_manager::Message( protocol_handler::MessagePriority::kDefault)); message->set_json_message(message_string); @@ -78,7 +78,7 @@ MqueueAdapter::MqueueAdapter(HMIMessageHandler* hmi_message_handler) : HMIMessageAdapter(hmi_message_handler), sdl_to_hmi_mqueue_(-1), hmi_to_sdl_mqueue_(-1), - receiver_thread_() { + receiver_thread_(NULL) { mq_attr mq_attributes; mq_attributes.mq_maxmsg = kMqueueSize; mq_attributes.mq_msgsize = kMqueueMessageSize; @@ -96,18 +96,17 @@ MqueueAdapter::MqueueAdapter(HMIMessageHandler* hmi_message_handler) << kHmiToSdlQueue << ", error " << errno); return; } - ReceiverThreadDelegate* receiver_thread_delegate = - new ReceiverThreadDelegate(hmi_to_sdl_mqueue_, hmi_message_handler); - receiver_thread_ = - threads::CreateThread("MqueueAdapter", receiver_thread_delegate); + receiver_thread_delegate_ = new ReceiverThreadDelegate(hmi_to_sdl_mqueue_, + hmi_message_handler); + receiver_thread_ = threads::CreateThread("MqueueAdapter", + receiver_thread_delegate_); receiver_thread_->start(); } MqueueAdapter::~MqueueAdapter() { - if (receiver_thread_) { - receiver_thread_->stop(); - threads::DeleteThread(receiver_thread_); - } + receiver_thread_->join(); + delete receiver_thread_delegate_; + threads::DeleteThread(receiver_thread_); if (-1 != hmi_to_sdl_mqueue_) mq_close(hmi_to_sdl_mqueue_); if (-1 != sdl_to_hmi_mqueue_) mq_close(sdl_to_hmi_mqueue_); mq_unlink(kHmiToSdlQueue); @@ -115,7 +114,7 @@ MqueueAdapter::~MqueueAdapter() { } void MqueueAdapter::SendMessageToHMI(const MessageSharedPointer message) { - LOG4CXX_TRACE_ENTER(logger_); + LOG4CXX_AUTO_TRACE(logger_); if (-1 == sdl_to_hmi_mqueue_) { LOG4CXX_ERROR(logger_, "Message queue is not opened"); @@ -131,8 +130,6 @@ void MqueueAdapter::SendMessageToHMI(const MessageSharedPointer message) { LOG4CXX_ERROR(logger_, "Could not send message, error " << errno); return; } - - LOG4CXX_TRACE_EXIT(logger_); } void MqueueAdapter::SubscribeTo() { |