summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix/Clear endpoint_properties in policy DB if empty properties recieved in ↵8.1-RC1Shobhit Adlakha2022-03-156-0/+32
| | | | | | | | | PTU (#3880) * Clear endpoint_properties from policy DB if empty endpoint_properties are recieved in a PTU * Add check to only overwrite endpoint_properties if parameter is defined and empty * Add is_initialized check for external proprietary
* Remove empty check in SaveConsumerFriendlyMessages to clear messages when ↵Shobhit Adlakha2022-03-142-6/+2
| | | | core receives PTU with no consumer messages(with key defined) (#3879)
* Fix crash on shutdown during streaming (#3876)JackLivio2022-03-113-4/+7
| | | | | * Fix crash on shutdown during streaming * Fix iterative erase
* Fix/8.1.0 RC1 Coverity fixes (#3877)Shobhit Adlakha2022-03-114-28/+14
| | | | | * Fix reported coverity issues * Add null check for message_ptr
* Add additional case to openssl_to_internal_error for local issuer ↵Shobhit Adlakha2022-03-113-2/+3
| | | | certificate (#3875)
* Add missed locks (#3864)Olha Vorobiova (GitHub)2022-03-098-6/+66
|
* Update coverity build process to account for different tool versions (#3873)Jacob Keeler2022-03-041-1/+1
|
* Check if app id exists in cloud_app_id_map_ (#3870)JackLivio2022-03-032-2/+99
| | | | | | | | | * Check if app id exists in cloud_app_id_map_ * Update cloud_app_id_map_ if does not exist or endpoint changed * Fix style * Expand unit tests for connection handler
* Fix typos in HMI API (#3867)theresalech2022-02-251-2/+2
|
* Set Last PTU App ID when forwarding on system request in HTTP policy mode ↵Collin2022-02-215-9/+14
| | | | | | | (#3863) * set last_ptu_app_id_ when forwarding on system request in HTTP policy mode * fixup! set last_ptu_app_id_ when forwarding on system request in HTTP policy mode
* Fix result code for PrepareAudioPassThru (#3854)Olha Vorobiova (GitHub)2022-02-143-21/+31
| | | | | * Fix result code for PrepareAudioPassThru * Fix result code for PrepareAudioPassThru in error structure
* reject PTU system request when PTU not in progress (#3853)Collin2022-02-116-9/+51
| | | | | | | | | | | | | | | * reject PTU system request when PTU not in progress * track last_ptu_app_id_ in ext prop policy mode * fix style * Apply suggestions from code review Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> * fix style Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* Fix perform interaction close pop up (#3844)Iryna Lytvynenko (GitHub)2022-02-112-45/+32
| | | | | | | | | | * fix for rejected Perform Interaction * avoid close popup for VR_ONLY PI Co-authored-by: Yana Chernysheva (GitHub) <59469418+ychernysheva@users.noreply.github.com> fixup Co-authored-by: Vadym Luchko (gitHub) <vluchko@luxoft.com>
* Check that message code exists before accessing (#3852)Jacob Keeler2022-02-042-4/+14
| | | An empty entry in the messages table would be created if the key being searched for didn't exist. This adds a check before accessing this data so that an entry isn't created accidentally
* remove unused param FileName from OnPutFile in HMI API (#3850)Collin2022-02-031-4/+0
|
* lock read and write operations (#3851)RomanReznichenkoLuxoft2022-02-032-0/+4
| | | Co-authored-by: Yana Chernysheva <ychernysheva@luxoft.com>
* [SDL 0334] Feature/Transform SetDisplayLayout to UI.Show (#3849)Shobhit Adlakha2022-02-0212-372/+91
| | | | | | | | | | | | | * Add changes to transform SetDisplayLayout into UI.Show * Remove deprecated RPC UI.SetDisplayLayout from the HMI API * Style fix * Add HMI capabilities to SetDisplayLayout response * Fix failed unit tests * Address review comments
* Replase clusterModeStatus with clusterModes when this parameter is ↵Olha Vorobiova (GitHub)2022-02-011-3/+8
| | | | disallowed by policies (#3847)
* Resolve a deadlock (#3828)Olha Vorobiova (GitHub)2022-01-255-85/+19
| | | | | * Fixed deadlock * Delete useless members in EventDispatcher
* Fix PerformInteractionChoiceSet request behavior (#3826)Yana Chernysheva (GitHub)2022-01-259-11/+152
| | | | | | | | | | * Fix PerformInteractionChoiceSet request behavior * Update src/components/application_manager/src/application_data_impl.cc Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: Iryna Lytvynenko (GitHub) <ILytvynenko@luxoft.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Fix invalid iterator usage (#3843)Jacob Keeler2022-01-191-2/+1
|
* Send lock screen dismissal info with DD_OFF notification (#3842)Jacob Keeler2022-01-192-5/+2
|
* Move app launcher stop before unregister app (#3825)Yana Chernysheva (GitHub)2022-01-196-0/+42
| | | | | | | | | | | * Move app launcher stop before unregister app The applauncher has to be stopped before appropriate application will be unregistered. Otherwise it could lead to core crash, when Launch controller will try to run already non existed application Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com> Co-authored-by: VladSemenyuk <vsemenyuk@luxoft.com>
* Avoid processing streaming data packets after streaming stopping (#3816)Yana Chernysheva (GitHub)2022-01-192-27/+31
| | | | | | | | | | | | | | | | | | * Avoid processing streaming data packets after streaming stopping In some situations streaming data packets may be received during streaming stopping. In this case processing of such packet will be performed right after completion of streaming stopping process due to streaming_stop_lock_. So in this case we need to skip processing of such packet, that's why new flags are added for both services, and also removed outdated comments and locks, which now are redundant due to streaming_stop_lock_. * Changed the text in the logs. The flag setting line above the Stop method has been moved * Move flag setting to the top of the method Co-authored-by: RomanReznichenkoLuxoft <85177915+RomanReznichenkoLuxoft@users.noreply.github.com> Co-authored-by: LitvinenkoIra <ilytvynenko@luxoft.com>
* Cyclic UpdateDeviceList and UpdateAppList in case device is connected (#3835)RomanReznichenkoLuxoft2022-01-132-10/+37
| | | * Added a check to make the script does not work when there is not device
* SDL doesn't send up_to_date (#3834)Olha Vorobiova (GitHub)2022-01-132-0/+3
| | | | | * Correct UpdateStatusManager behavior after kOnValidUpdateReceived * Added an initialization of flags in external proprietary mode
* Convert Common_SamplingRate and Common_BitsPerSample enums to uint (#3837)Olha Vorobiova (GitHub)2022-01-113-22/+63
|
* fix/sdl_did_not_read_correctly_value_of_hmicapabilities_from_hmicapabilities ↵RomanReznichenkoLuxoft2022-01-119-10/+139
| | | | | | | | | | | cachefile (#3820) * sdl_read_value_navigation_and_phonecall_from_hmicapabilities_and_did_not_from_systemcapabilities * Update src/appMain/hmi_capabilities.json Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Fix JSON validation for QUERY_APPS (#3827)Vadym Luchko (GitHub)2022-01-111-31/+41
| | | fix validation of synonyms in QUERY_APPS system request
* changed the way you add soft buttons in the subscription method (#3839)RomanReznichenkoLuxoft2022-01-114-6/+2
|
* use files from the rps_spec folder without copying to the sdl_core (#3778)RomanReznichenkoLuxoft2022-01-105-12/+9
|
* Replace clusterModeStatus with clusterModes and vise versa (#3830)Yana Chernysheva (GitHub)2022-01-073-6/+19
|
* state_controller subscription (#3836)Vadym Luchko (GitHub)2022-01-061-5/+12
|
* Fix rare crash during streaming switching (#3833)Olha Vorobiova (GitHub)2021-12-221-2/+3
|
* Ensure valid application pointer in RAI::CheckLanguage and ↵Collin2021-11-232-5/+17
| | | | | | | | | | | FinishSendingResponseToMobile (#3815) * don't use null application ptr in RAI::CheckLanguage or FinishSendingResponseToMobile * prevent application nullptr deref in SendRegisterAppInterfaceResponseToMobile * check application valid in ApplicationDataShouldBeResumed * restore ResumeCtrlImpl DCHECKs
* added an ontimeout method to handle a timeout request (#3803)RomanReznichenkoLuxoft2021-11-102-0/+10
|
* Do not modify application list while iterating it (#3806)Collin2021-11-0910-109/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * do not modify applications array while iterating it * remove unnecessary and dangerous iterator++ * fixup! do not modify applications array while iterating it restore sending on language change to mobile * deref app ptr while holding app list lock * SendNotificationToMobile can also invalidate apps list iterator by calling unregister application * apply fix to TTS and VR on language change * Revert "Fix early IsRegistered() state of application (#3796)" This reverts commit 0ed38e8d2f7cb3a61a303cca2806a06ce9a1d58d. * revert #3799 * prevent crash with null app in rai response * do not deactivate app before unregistering in case of vr language change * make copy of ApplicationSet instead of pushing app_ids to vector * address failure of 3797_3798 atf test in extprop policy mode * fixup! address failure of 3797_3798 atf test in extprop policy mode only send NO_APPS_REGISTERED when no apps are registered * fix ext prop unit test and APPLICATION_NOT_REGISTERED log message * fixup! fix ext prop unit test and APPLICATION_NOT_REGISTERED log message fix style * simplify code copying applicationset
* Fix ThreadedSocket disconnect logic (#3566)Andrii Kalinich (GitHub)2021-11-092-25/+46
| | | | | | | | | | | | | | | | | | | | | | | | | * Fix ThreadedSocket disconnect logic There was noticed an issue with ThreadedSocket connection which often closes connection like an "unexpected disconnect" calling `ConnectionAborted()` every time even if it is handled disconnect. Also, there were no any events raised to Transport Manager for rare cases when disconnect is expected. To fix that, flow has been separated for handling expected and unexpected disconnect. Expected disconnect will be handled in case when external component calls `Disconnect()` and socket thread is alive. In that case should be called `DisconnectDone()` when thread is stopped. Unexpected disconnect will be handled in case when internal thread has been aborted and `Abort()` was called. In that case internal thread `ConnectionAborted()` will be called from internal thread to notify Transport Manager that physical disconnect has happened. This issue is pretty hard to detect just because business logic handles both disconnect types in the same way for now, but this might be changed in the future. * Update Boost Download URL Co-authored-by: JackLivio <jack@livio.io>
* Reset display_capabilities_ pointer after merging capabilities (#3812)Jacob Keeler2021-11-081-3/+5
|
* Fix unstable policy handler test (#3810)Andrii Kalinich (GitHub)2021-11-081-29/+25
| | | | | | | | | | | | * Fix unstable policy handler unit tests Looks like there was a missing async waiter in some unit tests so Async thread is still working when unit test is already finalized. That causes a core crashes and random unit tests failures. Was added `UnloadPolicyLibrary()` call to stop the async thread before finalizing the unit test. * Increase timeout for tests
* Fix unstable unit test (#3809)Andrii Kalinich (GitHub)2021-11-051-0/+4
| | | | | | | Looks like we have to properly shutdown message queue in the unit test which emulates data sending over the secured websocket session. Otherwise, unit test might be terminated earlier and data sending will be failed which causes a core crash.
* Update minimum value of MaxSupportedProtocolVersion to 2 (#3801)Jacob Keeler2021-11-042-3/+3
| | | If this value is set to 1, no apps can register because SDL Core responds with UNSUPPORTED_VERSION to protocol V1 messages (besides the initial StartService)
* Merge remote-tracking branch 'origin/master' into developJackLivio2021-10-271-0/+0
|\
| * Merge pull request #3775 from smartdevicelink/release/8.0.08.0.0JackLivio2021-10-27620-10863/+10778
| |\ | | | | | | Release 8.0.0
| | * Update rpc spec commitrelease/8.0.0JackLivio2021-10-271-0/+0
| | |
* | | Merge branch 'release/8.0.0' into developcollin2021-10-2646-234/+482
|\ \ \ | | |/ | |/|
| * | Fix issues with web app activation (#3799)8.0.0-RC2Andrii Kalinich (GitHub)2021-10-214-41/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add initial states for pending applications This would prevent crashes for cases when app will be attempted to be activated. * Fix UpdateAppList content * Fix checks in SDL.ActivateApp * Fix unit tests
| * | Removed the unit that interrupted the sequence of closing the connect… (#3785)RomanReznichenkoLuxoft2021-10-151-49/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Removed the unit that interrupted the sequence of closing the connection to the device via usb * Update logic for USB in transfer * fixup! Update logic for USB in transfer Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
| * | Fix early IsRegistered() state of application (#3796)Andrii Kalinich (GitHub)2021-10-148-39/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix early IsRegistered state of application Mark application as registered only when app registration was finalized and all corresponding requests were sent to HMI. This prevents data races in case when language has been changed by HMI and application is in intermediate registration state yet. * fixup! Fix early IsRegistered state of application
| * | Fix/crash after ptu for another app hmi type (#3795)Andrii Kalinich (GitHub)2021-10-1427-121/+186
| | | | | | | | | | | | | | | | | | | | | * Added RC plugin extension after PTU * Add new event `kAppHmiTypesChanged` Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>