| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| |
| | |
fix/cover_protocol_and_connection_handlers_with_unit_tests
|
| | |\ |
|
| | | |\
| | | |
| | | | |
7.0.0 Release
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* remove cloud app exception from StateControllerImpl::OnApplicationRegistered
* Fix/ Postpone application activation if registration is not complete yet (#3557)
* Postpone application activation if registration is not complete yet
* fixup! Postpone application activation if registration is not complete yet
* fixup! Postpone application activation if registration is not complete yet
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* fix style
* fix unit tests
Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There were noticed two issues related to a/v streaming:
1. Due to object self destruction after TerminateRequest() call
any attempt to access member field of that object may cause an
undefined behavior - it might be a core crash or corrupted value
sometimes. In this particular case, SDL tries to access `message_`
field through `application_id()` function after object destruction.
As a result, sometimes SDL crashes and sometimes this function just
returns 0. Because of that, SDL was not able to find application by
zero id and broke the retry sequence. This causes random failures
of some ATF scripts. To avoid that issue, all retry logic was
extracted into the separate function and `TerminateRequest` was
moved after that function. This will guarantee that there is no
attempts to access object fields after its destruction.
2. There was noticed that SDL makes one redundant retry attempt.
That was because of late retry value increment. To fix that issue,
increment has been placed before retry amount check.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* fix issue 2808:SDL Crash seen in SDL upon receiving rpc - OnEmergencyEvent with enabled:true
* change code stype
* Fix conflicts
* Fix log
* Fix crash
* Address comments
Co-authored-by: zhangwenqin <zhangwenqin@iauto.com>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Rework processing of the OnExitApplication
(RESOURCE_CONSTRAINT) notification
* Update UTs according to changes
Co-authored-by: sniukalov <sniukaov@luxoft.com>
Co-authored-by: Aleksandr Kutsan <AKutsan@luxoft.com>
Co-authored-by: jacobkeeler <jacob.keeler@livioradio.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
* Fix formatting for logs after logger overhaul
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
|
| | | | |
| | | |
| | | | |
* Add missed NACK reasons, update UTs and add minor changes
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
* Set is_resuming flag to false
* Change return value in RestoreAppHMIState and StartAppHmiStateResumption
|
| | | | |
| | | |
| | | | |
* Add defvalue to policy table schema
|
| | | | |\
| | | | |
| | | | | |
Fix broken Mobile API link in README
|
| | | | |/
| | |/| |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
* Add check for non-existent parent ID to AddSubMenuRequest
* fixup! Add check for non-existent parent ID to AddSubMenuRequest
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There was a problem with duplicate subscriptions to shared data
due to time gap between check for already subscribed apps in
SDLRPCPlugin and further processing of corresponding requests in
WayPointsPendingResumptionHandler. That's why this check was moved
to WayPointsPendingResumptionHandler.
Also refactoring of some methods WayPointsPendingResumptionHandler
class was done to make their logic clearer and easier to understand.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Add the DialNumber RPC to the Base-4 and Base-6 functional groups
* Move DialNumber into a separate functional group
* Fix added functional group
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Wait for UsbHandler thread end in UsbHandler dtor
The Thread dedicated for handling libusb events should exit
successfully on it's own.
This guarantees that `libusb_close()` being called on all
devices, as well as `libusb_exit()` call is properly sequenced.
Thread exits in recommended by libusb doc way:
1. set exit flag
2. deregister hotplug callbacks, which will wake up
`libusb_handle_events()` once again.
But this commit changes the way the Thread being joined. It
ensures that `join()` is called with `kNoStop` flag, which
prevents force stop using `pthread_cancel()`.
* Using atomic bool for shutdown_requested_ flag
Making UsbHandler::shutdown_requested_ flag atomic to guarantee
mutual access to it.
exchange() call is needed for helgrind to feel sure that there is
no data race.
* Remove redundant DCHECK
This assertion has been exposed by the current fix
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Re-order rai logic for plugins
* style
* Add mock method
* Add method descriptions
* Add timing content
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Fix 3173 bug:multi-thread access one pointer at same time caused a wild pointer problem in HMICapabilitiesImpl class
* modify test code for 3173
* fix Unit tests
* Fix merge conflicts
Co-authored-by: zhangwenqin <zhangwenqin@iauto.com>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In a while called method locks mutex for protecting
data and if USB connection is failed it means that
method will call and will try to lock the same mutex
again. That's why this mutex should be recursive.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Fix streamer activity in case of suspend
The problem of the current implementation is that SDL
kills streaming thread responsible for sending a/v
streaming data to HMI when streaming timeout expires.
This issue is observed when mobile app dumps 10-seconds
audio file to SDL during 2 seconds and after that app
does not send any data. In that case HMI will play
audio file during 2 seconds + timeout = 5 seconds. At
the 5th second SDL just kills streaming thread with all
pending messages, however audio service is still open.
As a result not a whole audio file is played.
The correct behavior from SDL side in that case is not
kill streaming thread when streaming timeout was expired.
SDL should kill streaming thread only when service is
actually stopped.
Current SDL behavior was updated to align with a correct
behavior described above.
* Adjust fix to work with audio socket streaming
* Revert "[WIP] initial fix of socket streaming by guessing playback time (#3057)"
This reverts commit 7c442abce73c462e7724a64b3ce037bcb8e9093e.
* Remove unused code after revert
* Fix style issues
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
GetInteriorVehicle request RPC should process the next result codes as success:
WRONG_LANGUAGE, RETRY, SAVED.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit makes no functional or insecure changes.
It only prevents possible SIGSEGVs.
Don't use raw pointers to WebsocketSession in almost all cases.
For function arguments, pointers changed to references
for preventing null pointer occurrence.
For containers pointers changed to weak_ptr for preventing
expired references.
Removed wrong inheritance for CMessageBroker
|
| | | | |\
| | | | |
| | | | |
| | | | |
| | | | | |
LuxoftSDL/fix/move_duplicate_conversion_functions_to_message_helper
Move duplicate conversion functions to Message Helper
|
| | | | | | |
|
| | | | | |\
| | | | |/
| | | |/|
| | | | | |
fix/move_duplicate_conversion_functions_to_message_helper
|
| | | | | |
| | | | |
| | | | |
| | | | | |
corresponding unit test (#3389)
|
| | | | |\ \
| | | | | |
| | | | | | |
Ignore playTone if provided without TTSChunks
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* Fix noExplicitConstructor issue
* Fix functionConst issues
* Fix unusedFunction and unusedField issues
* Fix redundantInitialization
* Fix unreadVariable and unusedVariable issues
* Fix postfixOperator issue
* Fix variableScope issue
* Fix invalidPrintfArgType_sint and unsignedLessThanZero issues
* Fix other errors
* Add changes, related to functions marked as unused
* Fix new issues
* Fixe review comment
* Fix codestyle
* Fix constParameter errors
* Fix functionConst errors
* Fix noExplicitConstructor, redundantInitialization errors
* Fix unreadVariable errors
* Fix shadowVariable error
* Fix useStlAlgorithm errors
* Fixe variableScope error, add FIXME comment
* Fix code style
* Fix compile error
* Remove unsued function
* Fix compile error
Co-authored-by: Vladislav Semenyuk <vsemenyuk@luxoft.com>
|
| | | | |/ /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Regarding of Helgrind report.
Changed type of TcpClientListener::thread_stop_requested_
from bool to std::atomic_bool.
The same for remove_devices_on_terminate_
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Replace bool flag 'is_stopping_' in class
ApplicationManagerImpl and remove mutex
'stopping_application_mng_lock_'.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There was found a few places inside of ApplicationManager
where `applications_` and `apps_to_register_` members were
used without locks however these members are commonly used
and must be synchronized in all places.
To avoid potential data races, direct usage of these elements
were replaced with accessor for read-only operations.
Also was added a missing lock.
|
| | | | |\ \
| | |_|/ /
| |/| | | |
|
| | | | | | |
|
| | | | |\ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
LuxoftSDL/fix/fix_enums_conversion_in_hmi_capabilities
Fix/fix enums conversion in hmi capabilities
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
There were found a couple of hardcoded HMI capabity enum to
string values and some of them were outdated. This legacy
code can be easily replaced with the templated function
supplied from generated API.
By that reason, all hardcoded pairs and maps were removed
and replaced with a common function.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* add webengine_websocket to TransportTypeProfileStringFromDeviceHandle
* differentiate transport name from cloud
* add WEBSOCKET and WEBENGINE devices to ini file
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* Replace check for already existed subscriptions
* Delete unused enum
* Update unit tests and add new unit test
|
