summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix style issuesfix/coverity_issues_4.4.0jacobkeeler2017-09-213-9/+12
|
* Fix resource leaks introduced in RC baselinejacobkeeler2017-09-212-9/+4
| | | Fixed CIDs 174941 and 174934
* Fix coverity issues related to protocol changesjacobkeeler2017-09-213-7/+8
| | | Fixes CIDs 174942, 174939, 174936, 174936
* Merge pull request #1760 from ↵JackLivio2017-09-1916-48/+82
|\ | | | | | | | | AKalinich-Luxoft/fix/fix_core_crash_on_nonrc_app_exit Fix SDL crash on exit/unregistering of non-RC application
| * Fix affected mocks and unit tests logicAKalinich-Luxoft2017-09-185-10/+23
| | | | | | | | | | After adding new method to few classes some of unit tests and mocks have to be updated.
| * Fix possible NULL pointer assignment in Resource Allocation ManagerAKalinich-Luxoft2017-09-181-3/+5
| | | | | | | | | | | | | | | | One of the reasons of this defect is that shared_ptr was initied with NULL pointer so it causes DCHECK fatal error. ResourceAllocationManagerImpl::GetApplicationExtention() returns NULL pointer in some cases what is not correct. It was replaced with default constructed shared pointers.
| * Fix SDL crash on exit/unregistering of non-RC applicationAKalinich-Luxoft2017-09-1811-35/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SDL plugin manager is receiving notifications from application manager when any application was deactivated or unregistered. This notification will be transfered from plugin manager to RC plugin. However RC plugin processes events from any application so when it try to process event from non-RC application, SDL crashes. RC plugin should process events only from applications with RC functionality. Also there is another problem when application is unregistering its app_id() is removing from applications list in AM before OnApplicationEvent() call so when some of plugins will try to get shared_ptr using app_id, it will receive null pointer, however in AM still exists shared_ptr to this app. So it will be better to pass shared_ptr of application instead of accessing to it every time from plugins using app_id parameter. Moreover, some of plugins could require more information about application in future. Following changes were done: - Updated OnApplicationEvent() with application shared_ptr param for plugin manager and all related plugins - RC plugin now triggers OnApplicationEvent only for events from RC applications
* | Merge pull request #1761 from JackLivio/fix/metadata_unit_test_fixJackLivio2017-09-181-0/+7
|\ \ | | | | | | Fix unit test failure
| * | Fix unit test failureJackLivio2017-09-181-0/+7
|/ / | | | | | | This unit test was seen to fail on some machines. This fix makes sure that HMIToMobileResult does not return an older cached value defined earlier in the show_test class.
* | Merge pull request #1752 from ↵Jacob Keeler2017-09-111-1/+1
|\ \ | |/ |/| | | | | LuxoftAKutsan/hotfix/extended_policy_tests_build_issue Replace Functional module library
| * Replace Functional module libraryAlexander Kutsan2017-09-081-1/+1
|/ | | | | Replace Adding functional module libaries before application manager library in message helper test It fixes linkage issue.
* Merge remote-tracking branch ↵jacobkeeler2017-09-082-12/+21
|\ | | | | | | 'LuxoftAKutsan/fix/SDL_respond_ACK_with_protocol_version_4_for_video_and_audio_services_instead_of_negotiatied_version_protocol' into develop
| * fixup! Fix incorrect behaviour of SDL during respose ACK whenr video and ↵Alex Kutsan2017-06-232-5/+8
| | | | | | | | audio services starts
| * Fix incorrect behaviour of SDL during respose ACK whenr video and audio ↵okozlovlux2017-06-201-2/+5
| | | | | | | | | | | | | | | | | | | | services starts - added condition in SendStartSessionAck to avoid sending max supported protocol version when video or audio services start. SDL must send negotiated protocol_version from message from mobile app Related to Issue-1365
* | Merge pull request #1750 from JackLivio/fix/remove_equipment_rc_artifactJackLivio2017-09-071-1/+0
|\ \ | | | | | | Remove RC artifact
| * | Remove RC artifactJackLivio2017-09-071-1/+0
|/ /
* | Merge pull request #1624 from ↵Jacob Keeler2017-09-074-6/+19
|\ \ | | | | | | | | | | | | AKalinich-Luxoft/fix/fix_messages_default_language_checking Fix Consumer friendly message default language checking
| * | Fix Consumer friendly message default language checkingAKalinich-Luxoft2017-06-194-6/+19
| | | | | | | | | | | | | | | | | | | | | | | | If “en-us” is not present for any message, the table shall be rejected, PM should log error and shut SDL down. However this works only for external policies. Added missed checks for regular policies. kMandatoryLanguage was renamed to default_language_
* | | Merge pull request #1746 from ChrisB-Elektrobit/feature/metadata_taggingJacob Keeler2017-09-077-2/+358
|\ \ \ | | | | | | | | Feature/metadata tagging
| * | | - adding a test to cover the case where metadata tagging is provided but no ↵ChrisB-Elektrobit2017-08-211-12/+61
| | | | | | | | | | | | | | | | accompanying field data exists; this should result in a 'WARNINGS' result code
| * | | - performed renamings suggested in smartdevicelink/sdl_evolution#239ChrisB-Elektrobit2017-08-176-31/+30
| | | |
| * | | - changing Show Request metadata but no data warning result code from ↵ChrisB-Elektrobit2017-08-171-1/+1
| | | | | | | | | | | | | | | | IGNORED to WARNINGS
| * | | - adding warning result code and info message to ShowResponse to handleChrisB-Elektrobit2017-08-142-4/+21
| | | | | | | | | | | | | | | | | | | | the case where metadata tags are provided without a corresponding mainField entry.
| * | | - removed some extraneous logging to clean up the code a bitChrisB-Elektrobit2017-08-111-12/+4
| | | |
| * | | - added some additional unit tests to show_test.cc to test translation ofChrisB-Elektrobit2017-08-091-0/+130
| | | | | | | | | | | | | | | | metadata tags from input format to the HMI output format
| * | | - added new ShowRequest::HandleMetadata function for the Show RPC toChrisB-Elektrobit2017-08-084-0/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | handle mapping metadata values from incoming mobile protocol to outgoing HMI protocol - hooked HandleMetadata() into ShowRequest::run() for the four mainFields - added new metadata json string entries to smart_object_keys.h/.cc
| * | | - modified HMI_API.xml to support the changes needed for metadata taggingChrisB-Elektrobit2017-08-041-0/+42
| | | |
| * | | - modified MOBILE_API.xml to support the changes needed for metadataChrisB-Elektrobit2017-08-041-0/+62
| | | | | | | | | | | | | | | | tagging
* | | | Merge pull request #1615 from ↵Jacob Keeler2017-09-072-63/+70
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | AKalinich-Luxoft/fix/fix_consumer_friendly_messages_saving Fix Consumer Friendly Messages removing from PT
| * | | | Fixed logger messages contextAKalinich-Luxoft2017-06-162-8/+8
| | | | |
| * | | | Refactoring in SaveConsumerFriendlyMessages functionAKalinich-Luxoft2017-06-152-65/+70
| | | | | | | | | | | | | | | | | | | | Removed nested if's.
| * | | | Fix consumer friendly messages removing from PTAKalinich-Luxoft2017-06-151-3/+5
| | |/ / | |/| | | | | | | | | | | | | | | | | | In case PTU comes with omitted consumer_friendly_messages param SDL should maintain current consumer_friendly_messages section in Local PT.
* | | | Merge pull request #1620 from AByzhynar/fix/FixFactoryDefaultsJacob Keeler2017-09-078-13/+57
|\ \ \ \ | | | | | | | | | | Clear persistent data of all registered applications after FACTORY_DEFAULTS and MASTER_RESET
| * | | | Fix SDL behavior in case of MASTER_RESET & FACTORY_DEFAULTSVeronica Veremjova2017-06-218-13/+57
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After SDL receives - BC.OnExitAllApplications(MASTER_RESET) : SDL should clear stored persistent data of all registered applications and revert local PT to preloaded state. - BC.OnExitAllApplications(FACTORY_DEFAULTS): SDL should clear stored persistent data of all registered applications and remove all user consents from local PT.
* | | | Merge pull request #1631 from ↵Jacob Keeler2017-09-072-0/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | LitvinenkoIra/fix/SDL_does_not_set_timeout_for_OnSystemRequest_with_url Add function descriptions for TimeoutExchangeSec and TimeoutExchangeMSec
| * | | | Add const and description to some methods of PolicyHandlerSergey Levchenko (GitHub)2017-09-072-0/+20
|/ / / /
* | | | Merge pull request #1634 from ↵Jacob Keeler2017-09-061-2/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | LitvinenkoIra/fix/SDL_sends_BC.UpdateDeviceList_without_of_upper_bound_size_of_deviceList Add limitation of size for deviceList in BC.UpdateDeviceList RPC
| * | | | Add limitation of size for deviceList in BC.UpdateDeviceList RPCSergey Levchenko (GitHub)2017-06-211-2/+5
| |/ / / | | | | | | | | | | | | | | | | | | | | According to requirements, SDL should send info about 100 devices at maximum, even if SDL has more devices connected.
* | | | Merge pull request #1708 from LuxoftAKutsan/feature/sdl_remote_control_baselineJackLivio2017-09-06270-24303/+21203
|\ \ \ \ | | | | | | | | | | Remote control baseline
| * | | | Add functional module library to message_helpter tests only if remote ↵Alexander Kutsan2017-09-061-1/+7
| | | | | | | | | | | | | | | | | | | | controll is on
| * | | | Remove unused function GatherAppGroupPrimaryAlexander Kutsan2017-09-062-4/+0
| | | | |
| * | | | Removed unused CheckHMILevel functionAlexander Kutsan2017-09-062-28/+0
| | | | |
| * | | | Add missed descriptionsAlexander Kutsan2017-09-062-0/+24
| | | | |
| * | | | Removed redundanr HMI subscriptionsAlexander Kutsan2017-09-061-1/+0
| | | | |
| * | | | Add missed DCHECKsAlexander Kutsan2017-09-063-0/+5
| | | | |
| * | | | Merge pull request #268 from ↵Alexander Kutsan (GitHub)2017-09-061-5/+7
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | LuxoftAKutsan/fix/remove_hardoced_mobile_and_hmi_function_ids Remove hardcoded HMI and mobile function ids
| | * | | | Remove hardcoded HMI and mobile function idsAlexander Kutsan2017-09-061-5/+7
| | | | | |
| * | | | | Merge pull request #267 from LuxoftAKutsan/fix/add_description_fr_fake_parameterAlexander Kutsan (GitHub)2017-09-051-1/+1
| |\ \ \ \ \ | | |/ / / / | | | | | | Add description to RemoveHMIFakeParameters function
| | * | | | Add description to RemoveHMIFakeParameters functionAlexander Kutsan2017-09-051-1/+1
| |/ / / /
| * | | | Merge pull request #266 from LuxoftAKutsan/fix/remove_redudant_settings_classAlexander Kutsan (GitHub)2017-09-0510-298/+35
| |\ \ \ \ | | | | | | | | | | | | Fix/remove redudant settings class
View Lorry Controller Status