summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix build errors with GCC6+fix/gcc6_buildjacobkeeler2018-01-172-1/+2
|
* Merge pull request #1938 from smartdevicelink/feature/deprecated_method_macrofeature/send_location_for_mobile_navJacob Keeler2018-01-1722-74/+100
|\ | | | | Add DEPRECATED macro, and fix resulting deprecation warnings
| * Address review commentsfeature/deprecated_method_macrojacobkeeler2018-01-178-11/+14
| | | | | | | | | | | | Remove C style casts Add comments for pragma directives Remove redundant DEPRECATED macro usages
| * Add DEPRECATED macro, and fix resulting deprecated warningsjacobkeeler2017-12-0423-83/+106
| |
* | Merge pull request #1604 from AKalinich-Luxoft/fix/fix_data_resumption_flowJackLivio2018-01-1628-65/+342
|\ \ | | | | | | Fix SUSPEND -> OnSDLAwake -> SUSPEND -> IGN_OFF sequence for resumption data saving
| * | Updated description, added deprecated methodsAKalinich-Luxoft2017-12-1912-29/+91
| | |
| * | Fix tests and mocks after rebaseAKalinich-Luxoft2017-12-122-2/+3
| | |
| * | Removed is_suspended setter.AKalinich-Luxoft2017-12-126-33/+21
| | | | | | | | | | | | | | | is_suspended flag was encapsulated inside resumption controller Updated mocks
| * | Added FINALAKalinich-Luxoft2017-12-122-2/+2
| | |
| * | Renamed methods, updated briefs, removed deep nestingAKalinich-Luxoft2017-12-125-35/+37
| | |
| * | Added missed implementation of OnAwakeSDLNotificationAKalinich-Luxoft2017-12-125-2/+94
| | | | | | | | | | | | | | | | | | | | | | | | This notification works in pair with OnExitAllApplications(SUSPEND) notification. However first one is present in code but second one was ommited. There was just empty file. File with implementation was added to CMakeLists. Message broker was subscribed to OnAwake notification from HMI. Added command creation in HMI Command Factory.
| * | Added new bool flag to ApplicationImpl classAKalinich-Luxoft2017-12-123-10/+50
| | | | | | | | | | | | | | | | | | | | | | | | This flag is needed for checking, is SDL should send OnHashChange notification after OnAwake notification. During suspend state SDL must not send OnHashChange according to requirements. If some of RPC's triggers OnHashChange notification sending during suspend, this flag will be set to true and after OnAwake notification if this flag was set, SDL will send OnHashChange notification.
| * | Added OnIgnitionOff() and new bool flag to ResumeCtrl classAKalinich-Luxoft2017-12-128-4/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SDL should distinct ignition off and suspend notifications. SDL should not increment ignition off count in case of suspended notification, only in case of ignition off. This logic was separated by appending new function OnIgnitionOff() which will be called from application manager on ignition off instead of OnSuspend(). Also was added is_suspended flag and related getter/setter. This flag is used in: - ApplicationImpl to check should SDL send OnHashChange or not - In OnAwakeSDLNotification to check should SDL do OnAwake actions or not - OnExitAllApplicationsNotification and OnAwakeSDLNotification switches this flag Also was fixed some related UT expectations and mocks.
| * | Renamed OnSuspend->IncrementIgnOffCount and OnAwake->DecrementIgnOffCountAKalinich-Luxoft2017-12-129-52/+51
| | | | | | | | | | | | | | | This functions of ResumptionData class was renamed according to their exact logic. Also renamed in mock class and in unit tests.
* | | Merge pull request #1966 from ↵JackLivio2018-01-163-6/+39
|\ \ \ | | | | | | | | | | | | | | | | AKalinich-Luxoft/fix/fix_default_permissions_apply_after_ptu Fix PTU apply for applications with default permissions
| * | | Fix PTU apply for applications with default permissionsAKalinich-Luxoft2017-12-123-6/+39
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a problem in PROPRIETARY flow that SDL does not update permissions for applications with default policies after PTU if application functional group was updated indirectly (through updating of "default" section). Also SDL does not send OnPermissionChange notification in described above case. This fix adds extra check if "default" functional group was updated and there are registered applications with default policies group and also updates them. Similar check was added for sending OnPermissionChange notification.
* | | Merge pull request #1864 from APCVSRepo/feature/enhance_video_streamingJackLivio2017-12-122-2/+15
|\ \ \ | |/ / |/| | Feature/enhance video streaming
| * | add the TRANSPORT_USB_BUFFER_MAX_SIZE Macro commentBrandonHe2017-11-211-1/+2
| | |
| * | change usb buffer size for optimize sdl transportwangxh772017-11-212-2/+14
| | |
* | | Merge pull request #1934 from LitvinenkoIra/fix/build_with_USE_COTIRE_OFFJacob Keeler2017-12-0550-518/+107
|\ \ \ | |_|/ |/| | Fix SDL buid with USE_COTIRE=OFF
| * | Move mock_message_helper to the CommandsTest classIra Lytvynenko2017-11-3050-518/+107
| | | | | | | | | | | | Move mock_message_helper to the base class of commands
* | | Merge pull request #1929 from ↵Jacob Keeler2017-11-3024-148/+120
|\ \ \ | |/ / |/| | | | | | | | LuxoftAKutsan/fix/subscribe_vehicle_data_cashing_results Fix/subscribe vehicle data cashing results
| * | Create correct structure of SubscriveVehicleData ResponseAlexander Kutsan2017-11-271-2/+15
| | | | | | | | | | | | | | | Convert to string keys of already subscribed vehicle data Add data type of already subscribed vehicle data
| * | Use VehicleDataType from MOBILE APi xml imstead of hardcoded valuesAlexander Kutsan2017-11-2724-146/+105
|/ / | | | | | | | | | | Delete include of application_manager/vehicle_info_data.h Fix unit tests
* | Merge pull request #1855 from ↵Jacob Keeler2017-11-222-12/+20
|\ \ | |/ |/| | | | | AKalinich-Luxoft/fix/fix_streaming_retry_sequence_logic Fix application start streaming retry sequence
| * Fix application start streaming retry sequenceAKalinich-Luxoft2017-11-152-12/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a problem with retry sequence which is triggered when user rejecets/ignores prompt regarding starting audio streaming on HMI. The problem is when user clicks Cancel then SDL sends new request in the sequence and not removes old one from queue. As a result we have two identical requests and each of them could trigger next iteration of retry sequence at the same time. As a result, next try could be started earlier than expected. For example if streaming retry sequence has 3 retries with 1 second timeout: - MOB -> SDL Request to start audio streaming - SDL -> HMI Prompt user to start streaming for active app (request 1) - User clicks "No" during 1 sec - HMI -> SDL User has clicked No (request 1 still in queue!) - SDL starts streaming retry sequence - SDL -> HMI First retry and waiting for result during 1 sec (request 2) - No answer from user during 1 sec - Tiemout from request 1: trird retry - Tiemout from request 2: retry limit reached. Streaming not allowed In this update was added request termination in case user rejects or accepts the request.
* | Merge pull request #1640 from ↵Jacob Keeler2017-11-1572-559/+1021
|\ \ | |/ |/| | | | | LuxoftAKutsan/fix/send_correct_info_parameter_in_case_if_some_hmi_interface_is_not_available_or_do_not_respond Fix/send correct info parameter in case if some hmi interface is not available or do not respond
| * Optimize using of CheckResultCodeAlexander Kutsan2017-11-151-5/+8
| | | | | | | | Move additional checks from PrepareResultForMobileResponse to CheckResultCode
| * Removed not actual unit testAlexander Kutsan2017-11-131-8/+0
| |
| * Unify Converting HMI to Mobile result code in unit testAlexander Kutsan2017-11-1328-206/+54
| | | | | | | | | | | | Mapping Fix converion HMI to mobile result in GetVehicleDataRequestTest
| * Fix Perform interfaction test after adding funcitonality of avaiting interfacesAlexander Kutsan2017-11-131-35/+43
| | | | | | | | In Unit tests after adding functionality of avaiting interfaces required execute Run() method before on_event
| * Unit tests fixesAlexander Kutsan2017-11-137-40/+47
| |
| * Process multiple HMI interfaces of change registration requestAlexander Kutsan2017-11-133-46/+120
| | | | | | | | Chage registration
| * Process result codes and infos from multiple HMI interfacesAlexander Kutsan2017-11-1320-201/+578
| | | | | | | | | | | | | | Created ResponseParams structure with couple of help functions to merge result codes from HMI, infos from HMI and generate success for mobile response Unit tests for checking Is state is available
| * Common functionality awaiting of certain HMI requestsAlexander Kutsan2017-11-1337-31/+184
|/ | | | | | | | Add private methods in CommandImpl: - StartAwaitForInterface - EndAwaitForInterface - IsInterfaceAwaited Add usage of this methods across of commands that splited to multiple HMI interfaces
* Merge pull request #1627 from ↵Jacob Keeler2017-11-022-9/+29
|\ | | | | | | | | LuxoftAKutsan/fix/SDL_responds_GENERIC_ERROR_instead_of_INVALID_DATA_when_soft_button_has_Type_is_Image_or_Both Fix issue with incorrect behaviour in AlertManeuver
| * Fix typosAndriy Byzhynar (GitHub)2017-09-081-3/+3
| |
| * fixup! Fix issue with incorrect behaviour in AlertManeuverAlex Kutsan2017-06-221-12/+11
| | | | | | | | | | | | Review changes : Changes Unappropriate variables names Add using definitions
| * Fix issue with incorrect behaviour in AlertManeuverokozlovlux2017-06-192-4/+25
| | | | | | | | | | | | | | | | | | | | | | | | - fixed issue when in AlertManeuver SDL responds GENERIC_ERROR instead of INVALID_DATA when soft button has Type is Image or Both and Text is whitespace or \t or \n or empty - fixed failed UTs - added DCHECK condition - used local variable Related to Issue-980
* | Merge pull request #1625 from LuxoftAKutsan/fix/system_request_with_filename_IVSJacob Keeler2017-11-023-14/+139
|\ \ | | | | | | Fix SystemRequest with filename=IVSU but w/o binary data
| * | Fix SystemRequest with filename=IVSU but w/o binary dataIvo Stoilov (GitHub)2017-06-243-14/+139
| |/ | | | | | | The fix removes legacy support for 'IVSU' files.
* | Merge remote-tracking branch 'dev-gh/fix/Memory_leaks' into developjacobkeeler2017-11-027-18/+43
|\ \
| * | Replaces raw member pointer with utils::SharedPtrAndrey Oleynik2017-09-085-13/+38
| | |
| * | Fix minor memory leaksSergey Levchenko (GitHub)2017-09-084-9/+7
| | |
* | | Fixes responses 'success' value in case of UNSUPPORTED_RESOURCE (#1576)Andrey Oleynik (GitHub)2017-11-027-41/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixes 'success' value in case of UNSUPPORTED_RESOURCE There is only one case for 'success' to have 'false' with UNSUPPORTED_RESOURCE - when there is single-interface RPC comes and that specific interface is not available i.e. <interface>.IsReady returned 'false' Changes done for base class and unit tests with wrong expectations. * Fix response to mobile result Fixed result to mobile in case of GENERIC_ERROR from hmi and iface does not response * Fix ut tests according to code changes * Fix regression
* | | Fix case sensitive app name and id comparison (#1614)Andrii Kalinich (GitHub)2017-11-0211-59/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add COLLATE NOCASE property for application_id and nickname columns and indices Added COLLATE NOCASE property for application_id and nickname columns and indices related to them in order to make them case insensitive for query select/insert/update. Changed policy id case to lower. Because of case sensitive file path all files and directories which contains policy id of related application, will be saved in lower case to keep SDL applications path case insensitive. * Fix loading preloaded PT from JSON file There was additional case when policy table is loading from preloaded JSON file. In this case there was case sensitive loading of app groups.
* | | Merge pull request #1611 from ↵JackLivio2017-11-022-2/+17
|\ \ \ | | | | | | | | | | | | | | | | AKalinich-Luxoft/fix/fix_subscribevehicledata_subscriptions Fix SubscribeVehicleData request subscriptions
| * | | Fix SubscribeVehicleData request subscriptionsAKalinich-Luxoft2017-06-142-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | The main idea here is to perform subscriptions only after SDL receives successful result from HMI. In case of erroneous result code SDL should not subscribe to requested VehicleData.
* | | | Merge branch 'master' into developJackLivio2017-10-3072-6544/+6887
|\ \ \ \
| * \ \ \ Merge pull request #1751 from smartdevicelink/release/4.4.04.4.0JackLivio2017-10-30430-32095/+36384
| |\ \ \ \ | | | | | | | | | | | | Release/4.4.0