summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Restructure how moduleIds are filtered in the forwarded HMI request and ↵fix/givd_different_allowmultipleaccess_valuesShobhit Adlakha2019-09-242-116/+153
| | | | readded for the mobile_response
* Add case for handling multipleAccessAllowed=falseShobhit Adlakha2019-09-242-45/+24
|
* Restructure how the consent array is createdShobhit Adlakha2019-09-241-98/+89
|
* Merge pull request #3045 from smartdevicelink/fix/dial_number_descriptionJacob Keeler2019-09-231-1/+4
|\ | | | | Fix DialNumber description in HMI API
| * Fix DialNumber description in HMI APIjacobkeeler2019-09-231-1/+4
| |
* | Merge pull request #3025 from smartdevicelink/fix/gather_consumer_messagesJacob Keeler2019-09-233-14/+58
|\ \ | | | | | | Fix reading of Consumer Friendly Messages in PROPRIETARY mode
| * | Address commentsfix/gather_consumer_messagesjacobkeeler2019-09-203-22/+41
| | |
| * | Fix reading of Consumer Friendly Messages in PROPRIETARY modejacobkeeler2019-09-101-2/+27
| | |
* | | Add condition check for policy ResetRetrySequence (#3035)Jacob Keeler2019-09-232-3/+6
| | |
* | | GetInteriorVehicleDataConsent user location check (#3039)Shobhit Adlakha2019-09-232-43/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Create function to check if user location is in module service area * Use location consents in GetCalculatedVehicleDataConsent * Filter(based on location) the moduleIds sent to hmi for consent * Removed unnecessary logs * Add checks for validating hmi_response * Check result code for hmi response before checking allowed param
* | | Merge pull request #3040 from ↵Jacob Keeler2019-09-232-6/+12
|\ \ \ | |_|/ |/| | | | | | | | smartdevicelink/fix/maximum_change_velocity_definition Fix definition of maximumChangeVelocity in HMI API
| * | Fix definition of maximumChangeVelocity in HMI APIfix/maximum_change_velocity_definitionjacobkeeler2019-09-182-6/+12
| | |
* | | Fix merge module data incorrect behavior (#3017)Yaroslav Mamykin (GitHub)2019-09-208-92/+521
| | | | | | | | | | | | | | | | | | | | | | | | * Fix MergeModuleData invalid behavior * Rework MergeModuleData and MergeArray logic * Add unit tests
* | | Add fix to update RC capabilities on ↵Shobhit Adlakha2019-09-201-14/+28
| | | | | | | | | | | | OnSystemCapabilityUpdated(REMOTE_CONTROL) (#3032)
* | | Make usage logger stabilization (#3022)Serhii Niukalov (GitHub)2019-09-1912-49/+94
| | | | | | | | | | | | | | | | | | | | | | | | Added custom deleter for logger Added flush logger during each handle deleting Added deleting logger thread during destroy each plugin This changes are necessary to avoid deadlock during work with log4cxx.
* | | Fix coverity issues (#3036)Jacob Keeler2019-09-1911-29/+34
| | | | | | | | | | | | | | | | | | | | | | | | * Fix coverity issues Fixes CIDs 203808, 203807, 203806, 203804, 203803, 203802, 203800, 203798, 203797, 203795, and 203793 * Add virtual destructor
* | | Fix dcheck on max dtls record size exceeded (#3021)Maksym Ked (GitHub)2019-09-191-1/+6
| | |
* | | Fix build with USE_COTIRE = OFF (#3012)Ira Lytvynenko (GitHub)2019-09-191-1/+1
|/ /
* | Merge pull request #3028 from ↵Jacob Keeler2019-09-138-149/+28
|\ \ | | | | | | | | | | | | smartdevicelink/revert-3015-fix/sdl_versioning_for_vehicle_data Revert "Fix sdl versioning for vehicle data"
| * | Revert "Fix sdl versioning for vehicle data (#3015)"revert-3015-fix/sdl_versioning_for_vehicle_dataJacob Keeler2019-09-138-149/+28
|/ / | | | | | | This reverts commit 73b34832829650834ea69b3606ce8127a93ef973.
* | Fix sdl versioning for vehicle data (#3015)Yaroslav Mamykin (GitHub)2019-09-138-28/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix versioning appliance for vehicle data SDL applied SyncMsgVersion=4.5.1 in case mobile app version was < 5.0 With this commit SDL applies SyncMsgVersion respectively to mobile app * Add unit test * Fix existing unit tests * fixup! Fix existing unit tests * fixup! Fix versioning appliance for vehicle data * fixup! Fix versioning appliance for vehicle data * fixup! Add unit test * fixup! Fix existing unit tests * fixup! Add unit test * fixup! Fix existing unit tests * fixup! Fix versioning appliance for vehicle data
* | Error message processing from HMI (#3016)Mykola Korniichuk (GitHub)2019-09-139-34/+76
| | | | | | | | | | | | | | | | * git error message processing from HMI * Fix comments and signed-unsigned conversion * fixup! Fix comments and signed-unsigned conversion
* | Fix SDL's core crash during retry sequence (#3020)Igor Gapchuk (GitHub)2019-09-1214-9/+79
|/ | | | | | | | | | | | | | * Fix SDL crash during retry sequence In case, when lust application is unregistered, SDL has to stop retry sequence, because doesn't exist any mobile connection and these actions are redundant. Also SDL should check if exist registered applications before sending PolicySnapshotNotification. * fixup! Fix SDL crash during retry sequence * fixup! Fix SDL crash during retry sequence
* Re-add minlength attribute for templateTitle parameter (#3023)Shobhit Adlakha2019-09-101-1/+1
|
* re add CancelInteraction to preloaded_pt json (#3018)Collin2019-09-061-0/+7
| | | was removed accidentally in generic network signal data
* Fix redundant OnPermissionChanged notification (#3007)Mykola Korniichuk (GitHub)2019-09-056-84/+67
| | | | | | * Fix redundant OnPermissionChanged notification * fixup! Fix redundant OnPermissionChanged notification
* Merge pull request #3013 from smartdevicelink/fix/build_with_disabled_loggerJacob Keeler2019-09-043-0/+3
|\ | | | | Fix build with disabled logger.
| * Fix build with disabled logger.fix/build_with_disabled_loggerMykola Korniichuk2019-09-043-0/+3
| |
* | Merge pull request #3005 from ↵Jacob Keeler2019-09-032-0/+16
|\ \ | | | | | | | | | | | | smartdevicelink/fix/PTU_trigger_on_ignition_cycles_doesnt_work_properly Add check for already stored vehicle data item params
| * | Add check for already stored vehicle data item paramsfix/PTU_trigger_on_ignition_cycles_doesnt_work_properlyMykola Korniichuk2019-09-022-0/+16
| |/
* | Fix failing build with enable_security=off (#3006)Maksym Ked (GitHub)2019-09-036-10/+24
|/
* Feature/Remote Control - Allow Multiple Modules per Module Type (#2984)Ira Lytvynenko (GitHub)2019-08-30111-1246/+7946
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add new functionality to the interfaces * Add moduleId processing to the resource allocation manager Add GetResources function to helpers to get a list of resources Update unit tests with moduleID param Update command tests after updating the resource allocation manager * Add GetAcquiredModuleTypes and ReleaseModuleType functions for policy checking * Remove redundant SetResourceState call and fix UTs SetResourceState is called in RCCommandRequest::on_event function so it makes no sense to call it again RCCommandRequest::on_event * Add moduleInfo to default capabilities * Add ModuleId method to RCCommandRequest Add ModuleId method to RCCommandRequest for extracting module_id from command message. Update all inherited commands from RCCommandRequest. * Add ReleaseInteriorVehicleDataModule RPC Add ReleaseInteriorVehicleDataModuleRequest. Add ReleaseInteriorVehicleDataModuleResponse. Update ResourceAllocationManager interface: - add method ReleaseResource(); Update ResourceAllocationManagerImpl: - move ReleaseResource() from private section to public for implementing interface; * Add GetInteriorVehicleDataConsentRequest RPC Add GetInteriorVehicleDataConsentRequest without logic. Add GetInteriorVehicleDataConsentResponse. Update RCCommandFactory. * Refactor RC capabilities checking Create RCCapabilities manager, move all functions related to capabilities checking from commands into it. Move auxiliary functions to the rc_helpers. Create mock for RC capabilities manager Update UTs after RC capabilities manager adding * Use range based loop for smart objects with array type * Add ModuleId() function implementation Add const to the ModuleType() function Add function to get the moduleId from hmi capabilities Process missing moduleId param in HMI response In case if HMI doesn't provide the moduleId in response SDL will consider such response as invalid and send generic error response to the mobile Add moduleId to the hmi request * Add moduleId validation by capabilities and button_name for ButtonPress * Add moduleId validation by capabilities for GetIVD and SetIVD Add capabilities check to the rc_command_request * Add const to the capabilities check functions * Add function to get list of all available resources from hmi capabilities * Fix UTs after updating the capabilities check Update unit tests after obtaining available resources from capabilities * Add new HMI RPC SetGlobalProperties and save user_location of application Update SetGlobalPropertiesRequest - update PrepareResponseParameters method according to third new parameter "rc_properties"; * Add new parameter to ini file Add period for module_id consent expiring * Update interior vehicle data caching with moduleId processing Update unit tests that are related to caching with moduleId processing * Add separate file for RCRpcTypes * Add RCConsentManager - add interface RCConsetnManager - add implementation RCConsentManagerImpl - add new rc constants - add mock class for RCConsentManager Remove all consents after RC disabling Add checking ModuleConsent to RCCommandRequest Add logic for GetInteriorVehicleDataConsentRequest from Mobile Save the driver's decision when SDL sends the GIVDConsent request * Define Grid, add functions for getting moduleServiceArea and allowMultipleAccess values Add Seat Location capabilities checking and function for getting driver's location Check if the user location area and the service area has something in common, or the user location is driver, otherwise - reject the module reallocation request Fix UTs after adding the location check * Update SEAT module type processing Add converting id to moduleId: If the vehicle support at least one seat control, seat control capability includes at least two items. 1st for driver’s seat. 2nd for front passenger’s seat * Add SetGlobalProperties Unit tests Add Unit test for PrepareResultCodeForResponse method Add Unit test for PrepareResultForMobileResponse method * Add ReleaseInteriorVehicleDataModuleRequest Unit tests * Set resource to free if SIVD request is invalid * Add Grid Unit tests * Add ResourceAllocationManager Unit tests * Add MockRCHelpers. * Add ResourceAllocationManager Unit tests * Allocate resource after receiving successful response from HMI Send OnRCStatus notification only in case resource allocation state was changed * Rename function to indicate that it returns a list of module types * Rename typedef to indicate that it defines a pair moduleType and capabilitiesStatus * Fix functions descriptions * Rename function to indicate that it returns data related to the module type * Fix CheckIfModuleExistsInCapabilities function name * Update cached consents logic for GIVDC Behavior for cache consents has been updated according to the following comment: 1. If accessMode=AUTO_ALLOW, return true by default 2. If accessMode=AUTO_DENY, check if another app is using the resource a. If the resource is IN_USE, return false b. If the resource is FREE, return true 3. If accessMode=ASK_DRIVER, check if the consent is cached a. If it is cached, return that result b. If it is NOT cached, then prompt the driver for consent * Update logic for allowMultipleAccess=false
* [SDL 0173] - Read Generic Network Signal Data Implementation (#2977)Alexander Kutsan (GitHub)2019-08-30247-7458/+12287
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Generate policy enums from MOBILE_API Policy manager HMI level enum reorder * Add RPC vehicle data and endpoint_properties to sdl_preloaded_pt Set default version of custom vehicle data mapping * Add VehicleDataItem to policy table SQL storage implementation for VehicleDataItems Fix validation of double values in policy table Change isDouble to isNumeric during validation double values "0" should be validated as correct double value Add validation vehicle data during PTU Send in PT snapshot only version of custom VDI - During snapshot generation remove vehicle data items section - Add validation for Policy table depended on PT type Fix wrong check for vehicle data snapshot Allow empty vehicle data in PTU Change max value of string for URL from 255 to INT_MAX * Make Policy Handler forward declared to avoid high coupling * Add vehicle_info_command_params for vehicle info plugin Vehicle info params added to hmi commands * Process CustomVehicleData in GetVehicleData request * CustomVehicleDataManager implementation * Process Custom vehicle data subscriptions Refactored code. Extracted CheckFrequency to separate method in class * Check update of content of functional groups Fixes https://github.com/smartdevicelink/sdl_core/issues/2962 Add additional check for functional group content before OnPermissionChangeNotification. * rename comparing functions to make more clear their return value sense * change variable names * extra check for null values in HasNewGroups() New unit test to cover changes within functional group * Add GetPolicyConfigurationData GetPolicyCOnfigurationData Implementation * Add CustomVehicleData functionality for POLICY_EXTERNAL flow Change max value url for external policy fixes for external flow * since unti validation for the database * empty vehicle data validation * Convert data_type to VehicleDataType enum value * Validation of VehicleDataItem name and key Introduces validation of vehicle_data_item name and key validation: * they should not contain spaces; * they should not be empty or consist only spaces; * they should not contain invalid chars like '!@#$%^&*'. * Add engineOilLife to HMI_API * Remove deprecated RPC GetUrls due to major version update * Add ability to extend Smart schema with parameters Extract SMember from CObjectSchemaItem Add methods to ISchemaItem (Using composite pattern) - GetMemberSchemaItem - AddMemberSchemaItem Add implementation of VehicleDataItemSchema class Add appropriate unit tests Add creation of vehicle_data items schemes on policy event
* Fixed app activation during resumption (#3001)Andriy Byzhynar (GitHub)2019-08-303-33/+31
| | | | | Fixed application activation/reactivation during resumption process Fixed related unit tests
* Feature/service status update to hmi (#2921)Maksym Ked (GitHub)2019-08-2982-205/+2230
| | | | | | | | | | | | | | | | | | | | | | | | | * Added OnServiceUpdate notification * Added handling of service status update - introduced ServiceStatusUpdateHandler and ServiceStatusUpdateHandlerListener interfaces - added lacking interface functions to corresponding entities - added notification of listeners - introduced ServiceStatusUpdateNotificationBuilder - replaced shared_ptr with unique_ptr - moved SERVICE_RECEIVED * Add UT's for service status update to HMI feature * Added ServiceStatusUpdateDocumentation * Added sending error on PTU retries exceed allowed count * Fix OnServiceUpdate for unsecure force protected service * Updates according to proposal changes Added new result codes for ServiceStatusUpdateReasonStructure
* Feature/rpc message protection (#2951)Maksym Ked (GitHub)2019-08-2985-193/+2442
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Added encryption required flag to policy table. Also added RPC Encryption Manager Interface for comfortable access to policy table. * Added logic for processing RPC according to the proposal. * The permission change notification has been expanded. * Fixed UTs after implementation feature RPC message protection. * Fix multiframe issue * Fix style * Added storage of encryption required rpcs * Fix CI build * Extended logic adding encryption flag in message helper * Added permission check of encryption required for PROP * Added permission check of encryption required for EXT * Fixes after rebase * Answer PR comments - fixed typos - fixed 3rd party cmake * fixup! Added logic for processing RPC according to the proposal. * fixup! The permission change notification has been expanded. * Answer PR comments - renamed functions - added encryption_required flag to sql_pt_ext* source files - added condition and logging to CacheManager::GetApplicationParams * fixup! Added logic for processing RPC according to the proposal. * fixup! Added encryption required flag to policy table. * fixup! Added permission check of encryption required for EXT * fixup! Added permission check of encryption required for PROP * Fixes after rebase
* Fix/reject register too many requests (#2993)Collin2019-08-281-10/+18
| | | | | | | | * still init the RAI when we cannot find a session for the connection send a response to mobile when it tries to register no matter what * style script
* Merge pull request #2956 from smartdevicelink/fix/pipe_audiostream_cutoffShobhit Adlakha2019-08-284-0/+35
|\ | | | | Pipe audio streaming cutoff issue
| * Merge remote-tracking branch 'origin/develop' into fix/pipe_audiostream_cutofffix/pipe_audiostream_cutoffJackLivio2019-08-28288-5181/+18769
| |\ | |/ |/|
* | Merge pull request #2980 from smartdevicelink/feature/widget_supportJackLivio2019-08-26139-1155/+8885
|\ \ | | | | | | Feature/widget support
| * | fixup! Implement Resumption for widgetsfeature/widget_supportAndriy Byzhynar (GitHub)2019-08-257-5/+40
| | |
| * | Remove redundant condition lead to core crashAndriy Byzhynar2019-08-231-1/+7
| | |
| * | fixup! Fixes after rebaseAndriy Byzhynar (GitHub)2019-08-212-3/+6
| | |
| * | Fix nickname validation issue appeared after rebaseAndriy Byzhynar (GitHub)2019-08-211-3/+4
| | |
| * | Remove redundant policy handler code left after rebaseAndriy Byzhynar (GitHub)2019-08-211-5/+0
| | |
| * | fixup! Update Mobile & HMI API with new data types and parametersAndriy Byzhynar (GitHub)2019-08-211-4/+12
| | |
| * | Add app version check to SetDisplayLayout RPCAndriy Byzhynar (GitHub)2019-08-213-14/+78
| | | | | | | | | | | | | | | Added app version check and appropriate result code generation Updated old/added new unit tests
| * | Fix policy manager unit tests after rebaseAndriy Byzhynar (GitHub)2019-08-211-0/+4
| | |
| * | fixup! Send one OnSystemCapabilitiesUpdated on resumptionmked-luxoft2019-08-201-1/+1
| | |
| * | Fixes after rebasemked-luxoft2019-08-203-11/+5
| | |