summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* trigger ptu on startup only in proprietary policy modefix/issue_3396collin2020-06-021-1/+1
|
* Fix defect: revoked app still be resumed as FULL. (#2546)Igor Gapchuk (GitHub)2020-05-294-8/+51
| | | | | | App was resumed with Full HMI Level when it has been flagged as revoked in the policy table. This PR adds a check that app is not revoked to continue with HMI Level resumption.
* Fix onsystemrequest retry logic (#3400)JackLivio2020-05-2811-25/+100
| | | | | | | | | * Fix onsystemrequest retry logic * Cache policy update file from HMI for retries * Fix issues with previous commit Co-authored-by: jacobkeeler <jacob.keeler@livioradio.com>
* ensure delegates are destroyed before their threads (#3388)Collin2020-05-282-1/+4
|
* Fix style (#3398)Mykhailo Vorobiov (GitHub)2020-05-274-27/+36
| | | The style has been broken on develop branch - commit f5cfd151d82
* Increase policy unit-tests speed (#2315)Pavel Zhdanov (GitHub)2020-05-228-271/+755
| | | | | | | | | | | * Increase speed for Policy unit-tests: External policy Increase speed for unit-tests: - External policy tests - Regular policy tests * Increase speed for Policy unit-tests: Regular policy Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Rewrite unit tests for PolicyManagerImpl from External flow (#3353)Yana Chernysheva (GitHub)2020-05-2149-61422/+5217
| | | | | | | | | | | | | * Add new file with unit tests for CacheManager * Add new tests for PolicyManagerImpl * Add new preloaded tables * Add changes in CMakeLists.txt * Delete unused files * Re-add file with test
* Rewrite unit tests for PolicyManagerImpl from Proprietary flow (#3352)Yana Chernysheva (GitHub)2020-05-2123-24251/+6389
| | | | | | | | | | | | | * Add new file with unit tests for CacheManager * Add new tests for PolicyManagerImpl * Add changes in CMakeLists.txt * Add new preloaded tables * Delete unused files * Re-add test files
* Fix messages protocol version check (#2771)Stanislav Kobziev (GitHub)2020-05-217-17/+62
| | | | | | | | | | | | * Fix messages protocol version check Fixed the messages protocol version check and name of ProcessData method parameter 'result' was changed to 'out_result' for more clarity * fix copy-paste error and fix style Co-authored-by: Collin <iCollin@users.noreply.github.com> Co-authored-by: collin <collin+i@collinmcqueen.com>
* unsubscripe app from waypoints when it is unregistered (#3373)Collin2020-05-214-19/+71
| | | | | | | * unsubscripe app from waypoints when it is unregistered * address review comments * fix style
* Forward OnButtonPressNotifications where HMI specifies appID to apps in ↵Collin2020-05-202-3/+5
| | | | | | | | | LIMITED HMI Level (#3378) * initialize app in non custom button path of on_button_press run * fixup! initialize app in non custom button path of on_button_press run fix unit tests with changes in run
* Fix/gufm check syntax (#3369)Collin2020-05-206-28/+72
| | | | | | | | | | | * Fix implementation for SDLGetUserFriendlyMessage * Unit test for SDLGetUserFriendlyMessage: checking syntax * Changes according to comments * add invalid syntax error response info Co-authored-by: ZhdanovP <pzhdanov@luxoft.com>
* fix memory error in TcpDevice::IsSameAs (#3386)Collin2020-05-201-2/+2
|
* Release delegate only after full thread stopping (#2534)Pavel Zhdanov (GitHub)2020-05-201-1/+1
|
* Fix SendUpdateAppList and SendOnAppUnreg order (#2517)Kostiantyn Grygoriev2020-05-191-5/+7
| | | Co-authored-by: collin <collin@livio.io>
* Add RPCService unit tests (#3250)Yana Chernysheva (GitHub)2020-05-184-0/+900
| | | | | | | | | | | * Add RPCService unit tests * Add prerequisites for execution of unit tests * Rearrange and delete unused includes * Add minor changes Co-authored-by: JackLivio <jack@livio.io>
* Change reason to IGNITION_OFF only if reason wasn't defined before (#3274)Yana Chernysheva (GitHub)2020-05-181-2/+6
|
* Fix/issue 1951 (#3371)Collin2020-05-184-19/+56
| | | | | | | | | | | | | | | * remove deadlock danger when removing Connections from a ConnectionMap * fix style, use log debug instead of trace for singular messages * Revert "fix style, use log debug instead of trace for singular messages" This reverts commit c83288ec9fc9007e48044b09ad038edbf612e038. * fix style, use log debug instead of trace for singular messages * restore condition updates lost with merge of old versions Co-authored-by: Frank <fronneburg@xevo.com>
* Fix/Add Startup PTU trigger check (#3363)Shobhit Adlakha2020-05-189-0/+43
| | | | | | | * Add Startup PTU check * Reset Stop PTU etry when first app is registered * Address review comment
* Merge pull request #2553 from smartdevicelink/fix/start_stream_retry_countJacob Keeler2020-05-182-8/+8
|\ | | | | Fix Start Stream retry count
| * Fix Start Stream retry countfix/start_stream_retry_countjacobkeeler2018-08-292-8/+8
| |
* | ResetGlobalProperties doesn't reset HELPPROMPT and VRHELPITEMS to default ↵Collin2020-05-185-8/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | values (#3357) * Fix bug `ResetGlobalProperties` (#2337) Fix bug `ResetGlobalProperties` does't reset `HELPPROMPT` and `VRHELPITEMS` to default values Fix UT's after bugfixing - Fix `ResetGlobalPropertiesRequestTest` - Add mock function into `MockApplicationManagerSettings` Github issue #1306 Co-authored-by: v-malko4 <vmalkov@luxoft.com> * fix vr_help_title SO type, rename help_prompt_ in unit tests to so_help_prompt * fix style Co-authored-by: v-malko4 <vmalkov@luxoft.com>
* | only return if we are sure we are out of space (#3361)Collin2020-05-131-5/+0
| |
* | Revert "RAI reply DUPLICATE_NAME when app has same id and name as existing app"collin2020-05-133-69/+8
| | | | | | | | This reverts commit 236bdbaa283147044a6144f8c96cc43b82ff1014.
* | RAI reply DUPLICATE_NAME when app has same id and name as existing appcollin2020-05-133-8/+69
| |
* | Fix Compile Warnings (#3356)Collin2020-05-112-2/+5
| | | | | | | | | | | | | | * fix warning:maybe-uninitialized in CStringToEnum * fix out of buffer write warning in unit tests * Apply suggestions from code review
* | [SDL4.0]SDL does not create icons folder in case it was removed (#2649) (#3359)Collin2020-05-111-0/+8
| | | | | | | | | | | | | | | | The check for existence directory of app icons folder has been added to SetAppIconRequest. Co-authored-by: ValeriiMalkov <vmalkov@luxoft.com> Co-authored-by: ValeriiMalkov <vmalkov@luxoft.com>
* | Add missing ssl_context.h include in security_manager_listener (#2775)Stanislav Kobziev (GitHub)2020-05-111-0/+1
| |
* | Fixing problem with validation of array (#2669)Oleksandr Nyzhnyk (GitHub)2020-05-083-17/+47
| | | | | | * Fixing problem with validation of array
* | SDL crash during cleanup. (#2621)Mykola Korniichuk (GitHub)2020-05-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | * SDL crash during StopComponents() if StartComponents() failed. If resumption_storage_ in ResumeCtrlImpl is failed to initialize, SDL will try to stop components and exit with error code. At this time application manager tries to unregister all applications and call ResumeCtrlImpl::OnIgnitionOff() where resumption_storage_ is used. As a result, a crash will occur. As an example, if AppStorageFolder have no read/write access, resumption_storage_ fails to initialize. Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Update HMI_API.xml (#3354)Collin2020-05-071-1/+1
| | | | | | | | | | | | | | | | | | * Update HMI_API.xml * Update src/components/interfaces/HMI_API.xml Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Merge remote-tracking branch 'origin/master' into developJackLivio2020-05-012-0/+8
|\ \
| * \ Merge pull request #3351 from smartdevicelink/release/6.1.16.1.1вумудщзJackLivio2020-05-012-0/+8
| |\ \ |/ / / | | | Hotfix Release 6.1.1
| * | Init usage_and_error_counts on startup (#3349)release/6.1.1JackLivio2020-04-301-0/+4
| | |
| * | do not retry ptu if no apps are connected (#3350)Collin2020-04-301-0/+4
|/ / | | | | | | | | * do not retry ptu if no apps are connected * no URL should be returned if there is no app to do PTU
* | Update submodule commit after RPC Spec release6.1.0release/6.1.0jacobkeeler2020-04-291-0/+0
| |
* | Add permission checking for all messages to and from mobile (#3344)6.1.0_RC2Jacob Keeler2020-04-2712-107/+152
| | | | | | * Add permission checking for all messages to and from mobile
* | Fix capability window update when window_id is missing (#3342)JackLivio2020-04-221-9/+16
| | | | | | | | | | | | | | | | | | | | | | * Fix capability window update when window_id is missing * Refactor comments * Update src/components/application_manager/src/application_data_impl.cc Co-Authored-By: Collin <iCollin@users.noreply.github.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* | Fix result code generic error while subscribing to vehicle data (#3264)Yana Chernysheva (GitHub)2020-04-222-12/+31
| | | | | | | | | | | | | | | | | | * Fix iteration on set with possible erase * Add and process set with skiped result codes * fixup! Add and process set with skiped result codes * fixup! Add and process set with skiped result codes
* | Merge pull request #3341 from smartdevicelink/fix/external_policy_buildJacob Keeler2020-04-216-87/+75
|\ \ | | | | | | Move cached app logic to ChoosePTUApplication
| * | Move cached app logic to ChoosePTUApplicationfix/external_policy_buildjacobkeeler2020-04-216-87/+75
| | | | | | | | | | | | Also add macro guards for uses of last_ptu_app_id_
* | | Fix UpdateAppList/UpdateDeviceList spam (#3339)Andrii Kalinich (GitHub)2020-04-214-10/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix UpdateAppList/UpdateDeviceList spam There was noticed a continuous spam of update app and device list requests from SDL to HMI even if thre is no any devices connected and apps registered. After analysis, there was found a couple of places where logic should be updated: - In OnHMIStartedCooperation don't send update app list after refreshing cloud app information as this function able to trigger the same request itself when needed - When update app list timer is expired, don't send update app list if no any apps were registered or unregistered while timer was running - In transport manager, don't raise OnDeviceListUpdated event if no any devices were added/removed - When WebEngine device is created, it makes sense to connect it automatically and set its status to CONNECTED as its internal communication between SDL and HMI - In transport adapter, don't notify listeners via OnConnectionStatusUpdated() callbacks if device connection status was not actually changed All these actions together prevents all possible reasons of UpdateAppList/UpdateDeviceList spam observed before fix. * fixup! Fix UpdateAppList/UpdateDeviceList spam * fixup! fixup! Fix UpdateAppList/UpdateDeviceList spam * fixup! fixup! fixup! Fix UpdateAppList/UpdateDeviceList spam
* | | StartEndStreamTimer in StopNaviService (#3325)Collin2020-04-211-1/+1
|/ /
* | Fix PROPRIETARY and HTTP retry sequences (#3329)Jacob Keeler2020-04-2012-178/+253
| | | | | | | | | | | | | | | | | | | | | | | | * Fix PROPRIETARY and HTTP retry sequences For PROPRIETARY policy updates, Core is responsible for the retry sequence and cycling through update URLs. This fixes the PROPRIETARY flow with a few specific changes: 1. Apps for PTU are chosen randomly using the existing process, but after an application is chosen, all URLs that are associated with that application will be attempted before moving onto the next application. 2. When an OnSystemRequest(PROPRIETARY) is received from the HMI, Core will ignore the `appID` and `url` properties and populate them itself. This is because Core is responsible for providing these fields in PROPRIETARY mode. * Add caching for PTU URLs if provided by HMI * Fix bug in HTTP mode
* | Do not send two END_SERVICE requests during streaming switching between apps ↵Ira Lytvynenko (GitHub)2020-04-202-31/+58
| | | | | | | | | | | | | | | | | | | | | | (#3334) * Protect navi_app_to_stop_ * Prevent EndService double sending Remove app_id from navi_service_status_ before unregistering the app in case EndServiceAck did not come for at least one of the services, in order to avoid sending the EndService again during unregistration
* | Hotfix/3327 sdl sends generic error if vehicle data not available (#3335)Yaroslav Mamykin (GitHub)2020-04-172-43/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix response message structure of GetVehicleData request In case of GetVehicleData error response from HMI, SDL put only part of message to event. This way event was not processed properly and GENERIC_ERROR was sent to HMI. This commit fixes error response message structure. * Update existing unit tests * fixup! Update existing unit tests Co-authored-by: YarikMamykin <ymamykin@gmail.com>
* | Fix/Deadlock during transport re-connect via USB (#3332)Serhii Niukalov (GitHub)2020-04-172-49/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rework the use of AbortConnection for a usb connection Sometimes we get a deadlock because we use the same lock in the same thread. The situation is possible when calling the SendData, OnOutTransfer or AbortConnection functions. They block the mutex at the start. If in the PostOutTransfer function, which is called in SendData or indirectly in OnOutTransfer via PopOutMessage, we get the error LIBUSB_ERROR_NO_DEVICE, this will call AbortConnection. Which will cause a deadlock. * fixup! Rework the use of AbortConnection for a usb connection Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | Fix/Send OnAppPropertiesChange in case one of nicknames is removed (#3336)Serhii Niukalov (GitHub)2020-04-162-5/+29
| | | | | | | | | | | | | | * Update compare for the nicknames * UTs update Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | fix APTDisplayText covert bug (#3291)Jim-Nexty2020-04-071-4/+6
| | | | | | Co-authored-by: xiatian <xiatian@iauto.com>
* | Fix SDL doesn't send EndService for Video/Audio Service upon IGNITION_OFF ↵Yurii Postolov2020-04-061-0/+2
| | | | | | | | | | #1409 (#2425) * Fix SDL doesn't send EndService for Video/Audio Service upon IGNITION_OFF