summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Source capabilities from both app and hmi datafix/replace_create_window_dcheckJackLivio2019-10-102-1/+7
|
* Update ↵JackLivio2019-10-101-1/+1
| | | | | src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/create_window_request.cc Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
* Replace dcheck in create windowJackLivio2019-10-081-1/+4
|
* Add handling for unknown enum values in vehicle data schema (#3062)6.0.0_RCJacob Keeler2019-10-034-18/+14
|
* Merge pull request #3066 from smartdevicelink/fix/coverity_issuesJacob Keeler2019-10-032-6/+6
|\ | | | | Fix latest coverity issues
| * Fix CID 204315, 204316jacobkeeler2019-10-032-6/+6
| |
* | ensure correct order of stream length calculations (#3064)Collin2019-10-031-5/+6
|/ | | OnMessageReceived is called with data before StartStream is called
* [WIP] initial fix of socket streaming by guessing playback time (#3057)Collin2019-10-019-13/+91
| | | | | | | | | | | | | | | | | | | | * initial fix of socket streaming by guessing playback time * isolate custom timer logic to socket audio streaming * add half second latency compensation * add mocks for changed and new methods * make DataSizeToMilliseconds const method * fix unit tests * update server_type checks * address review comments * fix namespace of ServiceType
* Add HMICapabilities Params (#3058)JackLivio2019-10-014-0/+18
| | | | | | * Add appServices param to HMICapabilities * Add hmiCapabilities params
* Fix PTU notifications order (#3051)Andrii Kalinich (GitHub)2019-10-0114-205/+427
| | | | | | | | | | | | | * Fix order of actions taken during PTU The existing order of actions were changed to make it more obvious for external systems like HMI and mobile apps. The main concern was that SDL is sending OnStatusUpdate(UP_TO_DATE) when policy table update was not actually done. The order of actions done during PTU was updated to perform sending of UP_TO_DATE only when all policy actions were actually done. Related unit tests were updated respectively.
* Merge pull request #3056 from smartdevicelink/fix/fix_random_sdl_crashJacob Keeler2019-09-271-5/+13
|\ | | | | Fix SDL crash on app service unpublishing
| * Fix SDL crash on app service unpublishingfix/fix_random_sdl_crashAndrii Kalinich2019-09-271-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | There was found an unsafe work with STL map in AppServiceManager - during service unpublishing there might be a possibility when component iterates over published_services_ and another function indirectly erases the same element from the same map what may cause an undefined behavior during iteration over the map. To make this safer - iteration over the map and erasure of element in the map were splitted onto two separate atomic actions.
* | Fix/Set mandatory=false for optional response params (#3052)Shobhit Adlakha2019-09-272-5/+8
| | | | | | | | | | | | * Set mandatory=false for all response params(other than resultCode and success) in the MOBILE_API * Add moduleData key check in RCHelpers::RemoveRedundantGPSDataFromIVDataMsg
* | Merge pull request #2501 from IGapchuk/sdl_not_send_UnsubscribeVehicleDataJacob Keeler2019-09-262-12/+35
|\ \ | |/ |/| SDL does not send UnsubscribeVehicleData request to HMI after unregister last app.
| * Fix SDL does not send UnsubscribeVehicleData request to HMIIgor Gapchuk2019-09-262-12/+35
|/ | | | | Fix SDL does not send UnsubscribeVehicleData request to HMI after unregister last app.
* Fix/crash on ign off (#3048)Maksym Ked (GitHub)2019-09-267-0/+31
| | | | | | * Shutdown message queues in rpc service on sdl close * fixup! Shutdown message queues in rpc service on sdl close
* Fix IAP device transport switching sequence (#3034)Andrii Kalinich (GitHub)2019-09-2513-72/+147
| | | | | | | | | | | | | | | | | | | | | | * Add reregister wait list accessor and fix IsApplicationSwitched in RAI * Update CommandHolder class After introduction CommandSource enum there was possible to specify any different source for HMI and mobile commands. However, CommandHolder class logic was not updated to reflect these changes and still working with the hardcoded values. As a result commands factory of plugins may not able to create commands which were suspended during device transport switching and then restored back. This commit contains updated CommandHolder impl which reflects changes done and properly handles initial command source. * Fix affected UT * Fix style
* Fix/GetInteriorVehicleDataConsent for modules with different ↵Shobhit Adlakha2019-09-252-182/+189
| | | | | | | | | | allowMultipleAccess values (#3050) * Restructure how the consent array is created * Add case for handling multipleAccessAllowed=false * Restructure how moduleIds are filtered in the forwarded HMI request and readded for the mobile_response
* move MenuLayoutsAvailable to WindowCapability (#3043)Collin2019-09-2413-100/+67
| | | | | | | | | | | | | | | | * move MenuLayoutsAvailable to WindowCapability * cleanup style script + make is_supported function const * reverse comparables rvalue on left side is good practice * cleanup2 * main window can have window_id = 0
* Fix SDL behavior during LOW_VOLTAGE (#3029)Andrii Kalinich (GitHub)2019-09-2424-118/+323
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There were found a several problems during SDL testing with ATF scripts: 1. SDL does not ignore messages from mobile/HMI during low voltage and processes them on wake up 2. Sometimes SDL ignores messages on wake up due to timings 3. SDL low voltage process is not stopping properly by exit() function 4. SDL does not send OnAppUnregistered after wake up to HMI To solve mentioned problems, the following changes were done: 1. exit() was replaced with _Exit() which allow to force close the process 2. Suspend transport events processing threads during low voltage, such as unexpected disconnect etc. These events should be processed when SDL wakes up completely. 3. Suspend all client listening threads and shut down sockets for a TCP connections to prevent any possibility to receive message during low voltage. These threads will be resumed on wake up. 4. Set low_voltage flag to false in the end of wakeup() function to prevent any timing issues. 5. Don't add pending requests/notifications into request controller if low voltage event has happened, as it may happen at any moment 6. Don't handle received pending messages from mobile/HMI in RPC handler if low voltage event has happened as it may happen at any moment 7. Updated logic of few test case scenarios. Updated unit tests according to code changes
* Merge pull request #3047 from ↵Jacob Keeler2019-09-246-26/+1
|\ | | | | | | | | smartdevicelink/feature/remove_deprecated_methods_6.0.0 Remove deprecated methods from project
| * Remove deprecated methods from projectjacobkeeler2019-09-236-26/+1
| |
* | Merge pull request #3045 from smartdevicelink/fix/dial_number_descriptionJacob Keeler2019-09-231-1/+4
|\ \ | |/ |/| Fix DialNumber description in HMI API
| * Fix DialNumber description in HMI APIjacobkeeler2019-09-231-1/+4
| |
* | Merge pull request #3025 from smartdevicelink/fix/gather_consumer_messagesJacob Keeler2019-09-233-14/+58
|\ \ | | | | | | Fix reading of Consumer Friendly Messages in PROPRIETARY mode
| * | Address commentsfix/gather_consumer_messagesjacobkeeler2019-09-203-22/+41
| | |
| * | Fix reading of Consumer Friendly Messages in PROPRIETARY modejacobkeeler2019-09-101-2/+27
| | |
* | | Add condition check for policy ResetRetrySequence (#3035)Jacob Keeler2019-09-232-3/+6
| | |
* | | GetInteriorVehicleDataConsent user location check (#3039)Shobhit Adlakha2019-09-232-43/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Create function to check if user location is in module service area * Use location consents in GetCalculatedVehicleDataConsent * Filter(based on location) the moduleIds sent to hmi for consent * Removed unnecessary logs * Add checks for validating hmi_response * Check result code for hmi response before checking allowed param
* | | Merge pull request #3040 from ↵Jacob Keeler2019-09-232-6/+12
|\ \ \ | |_|/ |/| | | | | | | | smartdevicelink/fix/maximum_change_velocity_definition Fix definition of maximumChangeVelocity in HMI API
| * | Fix definition of maximumChangeVelocity in HMI APIfix/maximum_change_velocity_definitionjacobkeeler2019-09-182-6/+12
| | |
* | | Fix merge module data incorrect behavior (#3017)Yaroslav Mamykin (GitHub)2019-09-208-92/+521
| | | | | | | | | | | | | | | | | | | | | | | | * Fix MergeModuleData invalid behavior * Rework MergeModuleData and MergeArray logic * Add unit tests
* | | Add fix to update RC capabilities on ↵Shobhit Adlakha2019-09-201-14/+28
| | | | | | | | | | | | OnSystemCapabilityUpdated(REMOTE_CONTROL) (#3032)
* | | Make usage logger stabilization (#3022)Serhii Niukalov (GitHub)2019-09-1912-49/+94
| | | | | | | | | | | | | | | | | | | | | | | | Added custom deleter for logger Added flush logger during each handle deleting Added deleting logger thread during destroy each plugin This changes are necessary to avoid deadlock during work with log4cxx.
* | | Fix coverity issues (#3036)Jacob Keeler2019-09-1911-29/+34
| | | | | | | | | | | | | | | | | | | | | | | | * Fix coverity issues Fixes CIDs 203808, 203807, 203806, 203804, 203803, 203802, 203800, 203798, 203797, 203795, and 203793 * Add virtual destructor
* | | Fix dcheck on max dtls record size exceeded (#3021)Maksym Ked (GitHub)2019-09-191-1/+6
| | |
* | | Fix build with USE_COTIRE = OFF (#3012)Ira Lytvynenko (GitHub)2019-09-191-1/+1
|/ /
* | Merge pull request #3028 from ↵Jacob Keeler2019-09-138-149/+28
|\ \ | | | | | | | | | | | | smartdevicelink/revert-3015-fix/sdl_versioning_for_vehicle_data Revert "Fix sdl versioning for vehicle data"
| * | Revert "Fix sdl versioning for vehicle data (#3015)"revert-3015-fix/sdl_versioning_for_vehicle_dataJacob Keeler2019-09-138-149/+28
|/ / | | | | | | This reverts commit 73b34832829650834ea69b3606ce8127a93ef973.
* | Fix sdl versioning for vehicle data (#3015)Yaroslav Mamykin (GitHub)2019-09-138-28/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix versioning appliance for vehicle data SDL applied SyncMsgVersion=4.5.1 in case mobile app version was < 5.0 With this commit SDL applies SyncMsgVersion respectively to mobile app * Add unit test * Fix existing unit tests * fixup! Fix existing unit tests * fixup! Fix versioning appliance for vehicle data * fixup! Fix versioning appliance for vehicle data * fixup! Add unit test * fixup! Fix existing unit tests * fixup! Add unit test * fixup! Fix existing unit tests * fixup! Fix versioning appliance for vehicle data
* | Error message processing from HMI (#3016)Mykola Korniichuk (GitHub)2019-09-139-34/+76
| | | | | | | | | | | | | | | | * git error message processing from HMI * Fix comments and signed-unsigned conversion * fixup! Fix comments and signed-unsigned conversion
* | Fix SDL's core crash during retry sequence (#3020)Igor Gapchuk (GitHub)2019-09-1214-9/+79
|/ | | | | | | | | | | | | | * Fix SDL crash during retry sequence In case, when lust application is unregistered, SDL has to stop retry sequence, because doesn't exist any mobile connection and these actions are redundant. Also SDL should check if exist registered applications before sending PolicySnapshotNotification. * fixup! Fix SDL crash during retry sequence * fixup! Fix SDL crash during retry sequence
* Re-add minlength attribute for templateTitle parameter (#3023)Shobhit Adlakha2019-09-101-1/+1
|
* re add CancelInteraction to preloaded_pt json (#3018)Collin2019-09-061-0/+7
| | | was removed accidentally in generic network signal data
* Fix redundant OnPermissionChanged notification (#3007)Mykola Korniichuk (GitHub)2019-09-056-84/+67
| | | | | | * Fix redundant OnPermissionChanged notification * fixup! Fix redundant OnPermissionChanged notification
* Merge pull request #3013 from smartdevicelink/fix/build_with_disabled_loggerJacob Keeler2019-09-043-0/+3
|\ | | | | Fix build with disabled logger.
| * Fix build with disabled logger.fix/build_with_disabled_loggerMykola Korniichuk2019-09-043-0/+3
| |
* | Merge pull request #3005 from ↵Jacob Keeler2019-09-032-0/+16
|\ \ | | | | | | | | | | | | smartdevicelink/fix/PTU_trigger_on_ignition_cycles_doesnt_work_properly Add check for already stored vehicle data item params
| * | Add check for already stored vehicle data item paramsfix/PTU_trigger_on_ignition_cycles_doesnt_work_properlyMykola Korniichuk2019-09-022-0/+16
| |/
* | Fix failing build with enable_security=off (#3006)Maksym Ked (GitHub)2019-09-036-10/+24
|/