| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
|
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Add the new ApplicationEvent.
Add the new ApplicationEvent (kRCStatusChanged) for informing RcRPCPlugin
that OnRCStatus notification should be sent.
Split adding RcExtension to application and sending OnRCStatus notification
to the separate actions.
* Fix SDL crash during application registration.
There is an issue when SDL crashes during registration second application
in the time when already exists a registered other one application.
In the current implementation ApplicationManager during application
registering by the ApplicationManager::RegisterApplication method creates
a new instance of the application and adds it to the collection of all
registered applications. This method calls in the
RegisterAppInterfaceRequest, but all needed extensions will be added only
by the ApplicationManager::OnApplicationRegistered method during sending
RegisterAppInterface Response to the mobile.
According to the described behavior could appear case when a first
application is registered successfully and all needed application
extensions are successfully added too. The second application starts
the registration process in someone thread, but in the other one thread,
SDL receives PolicyEvent::kApplicationPolicyUpdated event and tries to
unsubscribe all applications from removed in policy table Vehicle Data
Items. All actions go on in the next sequence:
Precondition:
The first application is successfully registered and all needed
extensions are added.
The first thread:
1. The Mobile device sends RegisterAppInterfaceRequest RPC to the SDL for
registration of the second application.
2. SDL receives the RegisterAppInterfaceRequest and calls method Run.
Within method RegisterAppInterfaceRequest::Run ApplicationManager runs
3. the method RegisterApplication.
The second thread:
4. The SDL receives the PolicyEvent::kApplicationPolicyUpdated event and
forwards the event to each plugin for processing it.
5. VehicleInfoPlugin tries to unsubscribe all registered applications
from removed in policy table Vehicle Data Items.
The plugin finds the first application and unsubscribes it from all
removed Vehicle Data Items.
The plugin finds the second application and doesn't find any extensions
for the application and crashes on the DCHECK with an uninitialized
pointer to the extension.
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check for conflicting app resumption level
* Change variable name
* Restore widgets before HMI level conflict check
* Add check for number of restored widget windows
* Address comments
* Fix active app check
* Fix typo
* Fix style
* Add helper method
* Add new app manager predicate finder
|
|\
| |
| | |
Release 6.0.0
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Add unit tests
* Fix subscription to app services
* fixup! Fix subscription to app services
* fixup! Add unit tests
* fixup! Add unit tests
* fixup! Fix subscription to app services
* fixup! Fix subscription to app services
* fixup! Add unit tests
* fixup! Add unit tests
* fixup! Add unit tests
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Provide operation result to function file_system::CreateDirectory
The function CreateDirectory signature (return value) was changed
in file_system.h
* Added const cv for the creating directory path
into unit tests(when uses file_system::CreateDirectory)
* Fix merge conflict
|
| |\
| | |
| | | |
Fix custom vehicle data limits
|
| | | |
|
| |\ \
| | | |
| | | |
| | | |
| | | | |
smartdevicelink/fix/fix_synchronize_backup_and_reset_functions_in_cache
Synchronize backup and reset policy functions
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is an issue specific for EXTERNAL_PROPRIETARY flow
only. This issue is exposed by PolicyHandlerTest unit test:
ResetPolicyTable_WithPreloadedFile_ExpectPolicyTableReset
which sometimes is failing.
The main problem was that database reset(drop) and backup
can be done simultaneously in different threads which were
not synchronized. In that case, database drop often may be
failed because another thread is trying to write something
into the DB table which is going to be dropped. This causes
above unit test to fail sometimes.
To make that unit test and policy component more stable,
these two threads were synchronized by additing a waiting
function, so one thread will be able to wait for another
thread to finish its own staff.
|
| |\ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
smartdevicelink/fix/custom_vehicle_data_array_key_translation
Fix custom VD key translation for struct arrays
|
| | | | | |
|
| | | |/
| | |/| |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Fix log severity level in on_vehicle_data_notification.cc
Fixed log severity level in on_vehicle_data_notification.cc:
LOG4CXX_ERROR is changed on LOG4CXX_DEBUG and corrected a
mistake in string.
* Resolve merge conflict
* Fix Connection Typo
* Revert disabled unit test
|
| |\ \ \
| | | | |
| | | | | |
Update copyrights for generated files
|
| | | | | |
|
| | | | | |
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
StartService (#3082)
* Fix HMI level on StartServiceNAck
* fixup! Fix HMI level on StartServiceNAck
|
| | | | |
|
| |\ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There was found one corner case when SDL does
not change the internal status when service
start was refused due to current HMI level of
application. Was added missing check to set
status properly and send expected notification.
|
| | | |/
| | |/|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Fix revoked VD items subscription after PTU
There was found an issue that SDL still kept
subscriptions for custom vehicle data items even
for case when they were removed during PTU. By
that reason, SDL was crashing with DCHECK on
attempt to unsubscribe from non existing custom
data.
There was added missing logic of internal
unsubscribe in case some custom vehicle data
was removed by policies.
* Fix sending of UnsubscribeVehicleData
Was added a missing part of logic of subscriptions
control - cache manager was updated to keep the
vehicle data which was removed by last PTU.
Custom vehicle data manager was updated to
consider the removed vehicle data and also prepare
and send unsubscribe requests to HMI for case when
some vehicle data was removed and some application
was subscribed on it.
* fixup! Fix sending of UnsubscribeVehicleData
* fixup! Fix sending of UnsubscribeVehicleData
* fixup! Fix sending of UnsubscribeVehicleData
* fixup! Fix sending of UnsubscribeVehicleData
|
| | |/
| |/| |
|
| |\ \
| | |/ |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
(#3085)
* Resolve conflicts between the MOBILE_API in Core versus the official rpc_spec
* Remove Ford references
* Rearrange response parameters to be consistent
* Fix SystemCapabilityType order in HMI API
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Fix SDL timeout logic for RPCs with own timer
SDL must send GENERIC_ERROR to app in case HMI
does NOT respond during <DefaultTimeout>+<RPCs_internal_timeout>
for all RPCs with own timer
* Fix default timeout for HMI requests
For RPS with own timers SDL should apply default+internal timeout for mobile and HMI requests
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Add select function to pipe write call
* Address dropping frames comment
* Use temp var for write result
|
| | | |
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Fix SSL handshake for a secondary connection
There was found a several places in SDL code where
SSL handshake was working wrong when secured service
was started from a secondary connection like WIFI.
All these places were updated to consider primary
connection as a source for an SSL context and other
attributes for case when the current connection is
secondary.
This is a part which was not considered during
initial implementation of the secondary transport
feature.
* fixup! Fix SSL handshake for a secondary connection
* fixup! Fix SSL handshake for a secondary connection
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Replace dcheck in create window
* Update src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/create_window_request.cc
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
* Source capabilities from both app and hmi data
|
| | | |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
/resource_allocation_manager_tests testing binary . (#3070)
* ResourceAllocationManagerImpl Unit tests don't run
* Fix style
|
| | |
|
| |\
| | |
| | | |
Fix latest coverity issues
|
| | | |
|
| |/
| |
| | |
OnMessageReceived is called with data before StartStream is called
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* initial fix of socket streaming by guessing playback time
* isolate custom timer logic to socket audio streaming
* add half second latency compensation
* add mocks for changed and new methods
* make DataSizeToMilliseconds const method
* fix unit tests
* update server_type checks
* address review comments
* fix namespace of ServiceType
|
| |
| |
| |
| |
| |
| | |
* Add appServices param to HMICapabilities
* Add hmiCapabilities params
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Fix order of actions taken during PTU
The existing order of actions were changed to
make it more obvious for external systems like
HMI and mobile apps. The main concern was that
SDL is sending OnStatusUpdate(UP_TO_DATE) when
policy table update was not actually done.
The order of actions done during PTU was updated
to perform sending of UP_TO_DATE only when all
policy actions were actually done.
Related unit tests were updated respectively.
|
| |\
| | |
| | | |
Fix SDL crash on app service unpublishing
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There was found an unsafe work with STL map
in AppServiceManager - during service unpublishing
there might be a possibility when component
iterates over published_services_ and another
function indirectly erases the same element from
the same map what may cause an undefined behavior
during iteration over the map.
To make this safer - iteration over the map and
erasure of element in the map were splitted onto
two separate atomic actions.
|
| | |
| | |
| | |
| | |
| | |
| | | |
* Set mandatory=false for all response params(other than resultCode and success) in the MOBILE_API
* Add moduleData key check in RCHelpers::RemoveRedundantGPSDataFromIVDataMsg
|
| |\ \
| | |/
| |/| |
SDL does not send UnsubscribeVehicleData request to HMI after unregister last app.
|