| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Copies the contents of `vi_waiting_for_unsubscribe_` and iterate through the copy to prevent editing the container while iterating
|
| |
|
|
|
|
|
|
|
| |
* include endian conversions in protocol handler tests even when security is off
* exclude transport manager tests expecting call to ws_server_ca_cert_path when security is off
* require ENABLE_SECURITY for ProcessFailedCertDecrypt
* add return with assert for release mode
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix getting SSL context in CryptoManager
This PR fixes way of getting SSL context from SSL connection.
Direct access works well in 1.0.2 version, however this field
became unavailable in 1.1.1 version which causes SDL build to
fail. In order to make this change working on all lib versions
as expected, direct access has been replaced with convenient
getter function from the same library.
* Update certificate generation script
* Change hash function from md5 to sha256
Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* SYNC-73520: Fixed Issue related to SetAppIcon Path
SYNC-73520
Removed the call to the function ConvertPathForURL() which was modifying the path as a URL
Converting "!#$&'()*+,:;=?@[] " to there corresponding hex values. This function is
not required for path.
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
Co-authored-by: LitvinenkoIra <ilytvynenko@luxoft.com>
Co-authored-by: Sidhartha <ssing314@ford.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix for a potential SDL crash on boot
One of the reasons why SDL is crashing on start is
related to lazy initialization of the HMI/Mobile/v4
API classes.
These classes are initializated on demand when some
of threads are trying to get the object of that class
first time. Most likely, at SDL start might be a
situation when HMI/Mobile/v4 API classes are
constructing in the one thread and at that moment another
thread is trying to get access to the inner data of
not-yet-fully-constructed object and this causes a core
crash with ~ISchemaItem() calls in stack trace. That is
possible because access to these factories is not
synchronized.
To avoid such situation, factory creation was moved to
AM ctor and all other sub components just use getters
when they need to get access to API instances.
* fixup! Fix for a potential SDL crash on boot
Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
Co-authored-by: LitvinenkoIra <ilytvynenko@luxoft.com>
|
| |
|
| |
* Update the descriptions
|
| |
|
|
| |
cycle (#3608)
|
| |
|
| |
* Add countRate to HMI API
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* Add permissions check in OnAllowSDLFunctionalityNotification for application revoked case
* Fix unit tests
* Fix unit tests
* Use IsApplicationRevoked instead of GetAppPermissionChanges
* Fix IsApplicationRevoked check
* Add check to prevent setting last_activated_app_id_ for revoked app
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix applying heart_beat_timeout_ms from PreDataConsent
After sending SDL.OnAllowSDLFunctionality(allowed = false) application is assigned to PreDataConsent group.
After this HB timeout is set to timeout from PreDataConsent
* Updated logs messages and simplify vars after review
* Update unit tests
* Fix syntax errors after rebase
* fixup! Fix syntax errors after rebase
Co-authored-by: Veronica Veremjova <vveremjova@luxoft.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
| |
|
|
|
| |
* Fix success=false after UNSUPPORTED_RESOURCE response for multiple RPCs
Fixes issue for PerformInteraction, Alert, SubtleAlert, AlertManeuver, and PerformAudioPassThru
|
| |
|
|
|
| |
* Fix build failure with ENABLE_LOG=OFF
Also fix unused variable warnings caused by the same configuration
|
| |\
| |
| | |
Fix variable usage in OnVehicleDataNotification
|
| | | |
|
| |\ \
| | |
| | | |
Check for revoked apps when reading mandatory policy fields
|
| | |/ |
|
| |\ \
| | |
| | | |
Fix failing unit tests in hmi_notifications_test
|
| | |/ |
|
| |\ \
| |/
|/|
| |
| | |
smartdevicelink/fix/bind_protocol_version_at_registration
Bind protocol version when app registers
|
| |/ |
|
| |\
| |
| | |
Handle omitted parameter permissions properly in OnVehicleData notification
|
| | | |
|
| | | |
|
| |/
|
|
|
| |
* Add OnWayPointChange handling for NAVIGATION app services
* Only send OnWayPointChange to mobile from active waypoints provider
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
smartdevicelink/fix/gpcd_consumer_friendly_messages
Re-add messages field in policy table json
|
| |/
|
|
| |
consumer_friendly_messages.messages was being omitted from the policy table json rather than just the snapshot, this reintroduces this field (this field is still cleared out when generating the snapshot in `CheckSnapshotInitialization`)
|
| |
|
|
|
|
|
| |
* Fix policy validation of OnVehicleData message
* Fix unit tests
Co-authored-by: Mykola Korniichuk <mkorniichuk@luxoft.com>
|
| |\
| |
| | |
Fix session heartbeat starting
|
| | | |
|
| | | |
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
fix/fix_session_heartbeat_starting
# Conflicts:
# src/components/connection_handler/include/connection_handler/heartbeat_monitor.h
# src/components/connection_handler/src/connection.cc
# src/components/connection_handler/src/heartbeat_monitor.cc
# src/components/protocol_handler/src/protocol_handler_impl.cc
|
| | | |
| | |
| | |
| | |
| | | |
This prevents SDL from starting HB session tracking every
time SDL receives HB request from mobile.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In the current implementation SDL starts session
heartbeat right after application registration.
However the correct behavior is to start session
heartbeat after first heartbeat request from mobile app.
Following changes were done:
- Removed starting session heartbeat on app registration
- Added session heartbeat start on frist heartbeat request
from mobile app
- Added check to prevent starting of session heartbeat if
it was disabled in settings
|
| | |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Cover connection handler and policy handler with unit tests
Few tests added to connection_handler_impl_test.cc and to
connection_test.cc
There were 2 mocks for telemetry observer. So, one is removed
(src/components/include/test/protocol_handler/mock_telemetry_observer.h)
Fixed mock_telemetry_observer.h (src/components/protocol_handler/
test/include/protocol_handler/mock_telemetry_observer.h)
Added tests to protocol_handler_tm_test.cc
set_hash_id and get_hash_id are covered with unit tests.
set_hash_id, get_hash_id, ConvertPacketDataToString,
get_protocol_observers_count declarations are added to
protocol_handler_impl.h under BUILD_TEST flag.
Resolves: #2449
* fix according to comments
* Unit test for get_hash_id and set_hash_id
Removed declarations for internal functions get_hash_id and set_hash_id
ConvertPacketDataToString moved to convert_utils
as ConvertBinaryDataToString
Fixed unit tests for get_hash_id and set_hash_id
* replace dcheck or return to if in ConvertBinaryDataToString
due to issue in smoke tests
* minor UT fixes
* Update doxygen for convert_utils
* Address comments and fix UT
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
| |\ \ |
|
| | |\ \
| | | |
| | | | |
7.0.0 Release
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* remove cloud app exception from StateControllerImpl::OnApplicationRegistered
* Fix/ Postpone application activation if registration is not complete yet (#3557)
* Postpone application activation if registration is not complete yet
* fixup! Postpone application activation if registration is not complete yet
* fixup! Postpone application activation if registration is not complete yet
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* fix style
* fix unit tests
Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There were noticed two issues related to a/v streaming:
1. Due to object self destruction after TerminateRequest() call
any attempt to access member field of that object may cause an
undefined behavior - it might be a core crash or corrupted value
sometimes. In this particular case, SDL tries to access `message_`
field through `application_id()` function after object destruction.
As a result, sometimes SDL crashes and sometimes this function just
returns 0. Because of that, SDL was not able to find application by
zero id and broke the retry sequence. This causes random failures
of some ATF scripts. To avoid that issue, all retry logic was
extracted into the separate function and `TerminateRequest` was
moved after that function. This will guarantee that there is no
attempts to access object fields after its destruction.
2. There was noticed that SDL makes one redundant retry attempt.
That was because of late retry value increment. To fix that issue,
increment has been placed before retry amount check.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* fix issue 2808:SDL Crash seen in SDL upon receiving rpc - OnEmergencyEvent with enabled:true
* change code stype
* Fix conflicts
* Fix log
* Fix crash
* Address comments
Co-authored-by: zhangwenqin <zhangwenqin@iauto.com>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Rework processing of the OnExitApplication
(RESOURCE_CONSTRAINT) notification
* Update UTs according to changes
Co-authored-by: sniukalov <sniukaov@luxoft.com>
Co-authored-by: Aleksandr Kutsan <AKutsan@luxoft.com>
Co-authored-by: jacobkeeler <jacob.keeler@livioradio.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
* Fix formatting for logs after logger overhaul
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
|
| | | | |
| | | |
| | | | |
* Add missed NACK reasons, update UTs and add minor changes
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
* Set is_resuming flag to false
* Change return value in RestoreAppHMIState and StartAppHmiStateResumption
|
