summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Remove extraneous logsfix/updateapplist_on_hmi_reconnectShobhit Adlakha2020-03-251-2/+0
|
* Send updateapplist when hmi cooperation startsShobhit Adlakha2020-03-251-0/+3
|
* move submodule to own orgcollin2020-03-241-1/+1
|\
| * Update .gitmodules (#3301)Collin2020-03-241-1/+1
| |
| * Fix OnSystemRequest(LOCK_SCREEN_ICON_URL) sending (#3271)Andrii Kalinich (GitHub)2020-03-1332-228/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was noticed an issue that sometimes Policy Manager component is returning an empty url for lock screen icon. The root cause of that is the data races between thread which is sending OnSystemRequest notification and backupper thread which overwrites data in the database. As these two threads may have an intersection, there could be a possible situation that backuper thread erased data from `endpoints` table and another thread is using SQL query to select the data from the same table. As a result, second thread receives an empty result as the data was erased and the new one was not inserted yet by backupper thread. After that, SDL just does not send OnSystemRequest as the URL is empty. To fix that issue, policy component has been updated to use internal policy cache instead of direct access to policy database each time to get URL. This will guarantee that a sending thread will get an up-to-date infromation required for OnSystemRequest notification. Also, code cleanup has been done in order to remove all functions which become unused after this fix.
* | maintain signature for GetLockScreenIconUrl (#3303)Collin2020-03-232-2/+2
| |
* | Update start_external_proprietary.sh (#3299)Collin2020-03-231-3/+5
| | | | | | | | | | | | | | | | | | * Update start_external_proprietary.sh * Update src/appMain/start_external_proprietary.sh Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* | Fix sdl crash when policies disabled (#3292)Yaroslav Mamykin (GitHub)2020-03-232-50/+267
| | | | | | | | | | | | | | * Fix usage non-valid policy_manager pointer in case of EnablePolicy=false * Add unit tests for modified methods Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Fix/Checking PTU triggers when no apps are registered in regular policy mode ↵Shobhit Adlakha2020-03-191-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#3294) * Trigger PTExchange when Device consent is enabled * Move StartPTExchange call to BC.OnReady * StartPTExchange is a protected function. Add TriggerPTUIfNeeded to the policy_manager as well * Fixed GetPolicyHandler call in BC.OnReady * Add mock definitions * Fix failed ut * Handle PolicyUpdate error response * Add reset retry sequence * Revert "Move StartPTExchange call to BC.OnReady" This reverts commit 7c53978b2e7a42ed51cb856d054dce88e040e8ea. Co-authored-by: JackLivio <jack@livio.io>
* | Fix/consider timeouts during streaming switching (#3293)Serhii Niukalov (GitHub)2020-03-196-9/+79
| | | | | | | | | | * Consider video and audio status before send end of service Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | Fix OnSystemRequest(LOCK_SCREEN_ICON_URL) sending (#3271) (#3289)Collin2020-03-1632-228/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was noticed an issue that sometimes Policy Manager component is returning an empty url for lock screen icon. The root cause of that is the data races between thread which is sending OnSystemRequest notification and backupper thread which overwrites data in the database. As these two threads may have an intersection, there could be a possible situation that backuper thread erased data from `endpoints` table and another thread is using SQL query to select the data from the same table. As a result, second thread receives an empty result as the data was erased and the new one was not inserted yet by backupper thread. After that, SDL just does not send OnSystemRequest as the URL is empty. To fix that issue, policy component has been updated to use internal policy cache instead of direct access to policy database each time to get URL. This will guarantee that a sending thread will get an up-to-date infromation required for OnSystemRequest notification. Also, code cleanup has been done in order to remove all functions which become unused after this fix. Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
* | fix/Move AppProperties struct to the Common interface (#3286)Shobhit Adlakha2020-03-121-61/+35
| | | | | | | | | | | | | | | | | | * Move AppProperties struct to the Common interface * Remove unnecessary response params from SetAppProperties and GetAppProperties response * Add missing description tag * Fix description tag in last commit
* | Fix/Perform hash check before copying over mobile api files (#3288)Shobhit Adlakha2020-03-121-2/+6
| | | | | | | | | | | | | | * Compare MOBILE_API files in the submodule directory against the ones in the interfaces directory before copying * Use cmake copy_if_different command instead of cmp * Remove trailing whitespace
* | Fix/SDL does not send BC.PolicyUpdate to HMI if no apps are registered (#3280)Shobhit Adlakha2020-03-117-2/+34
|/ | | | | | | | | * Temporary fix for allowing core to send the policyupdate rpc * Remove CanUpdate call in PolicyManagerImpl::StartPTExchange and restore CanUpdate behavior * Fix regular policy unit tests * Fix extern policy unit tests
* Use Mobile_API files from RPC Spec submodule (#3270)JackLivio2020-03-044-8628/+11
| | | | | | | | | | | | | | | | | | | | | | * Remove MOBILE_API xml and xsd Use the files pulled from the rpc spec submodule instead * Add interfaces/MOBILE_API to .gitignore * Remove extra line * Use mobile_api.xml from the rpc_spec directory * Revert "Use mobile_api.xml from the rpc_spec directory" This reverts commit a089e018e968cad2f83660a3a27833f93ad362cf. * Update src/components/interfaces/CMakeLists.txt Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* Remove branches from submodules (#3272)JackLivio2020-03-032-2/+0
|
* Remove intendation for policy table snapshot (#3262)JackLivio2020-03-032-0/+2
|
* Add the missing attributes to the schema (#3266)Shobhit Adlakha2020-03-021-0/+6
|
* Add function UnwrapAppPolicies to CacheManager::Init() method (#3244)Yana Chernysheva (GitHub)2020-03-022-0/+9
| | | | | | | | | | | | | | | | | | * Add function UnwrapAppPolicies to CacheManager::Init() method * Add UnwrapAppPolicies to external flow * Delete return after unsuccessful unwrapping * Make result variable independent from result of execution UnwrapAppPolicies * Add update for external flow * Fix style * Add changes to external flow (remove dependency from result) * Add newline
* Start the new PTU after a failed retry sequence (#3208)Yevhenii Dementieiev (GitHub)2020-02-2820-33/+229
| | | | | | * Start the new PTU after a failed retry sequence in case some trigger occurs during the retry sequence Co-authored-by: Dmytro Boltovskyi (GitHub) <dboltovskyi@luxoft.com>
* Merge pull request #3261 from smartdevicelink/fix/readme_getting_started_linkJacob Keeler2020-02-281-1/+1
|\ | | | | Fix README link to Getting Started guide
| * Fix new README linkJacob Keeler2020-02-281-1/+1
|/
* Merge pull request #3120 from smartdevicelink/feature/readme_overhaulwebengineJacob Keeler2020-02-271-127/+22
|\ | | | | Update README to reference updated startup guides
| * Merge branch 'develop' into feature/readme_overhaulJacob Keeler2020-02-27548-21343/+13734
| |\ | |/ |/|
* | Feature/Web Engine support (#3221)Alexander Kutsan (GitHub)2020-02-270-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add ini file parameters for WebEngineSupport Issue : #3197 * Add Server WebSocket transport * Policy changes for Web Engine support Issue : #3197 * Changes in HMI_API for WebEngineSupport Issue : #3197 * Add application manager implementation for WebEngineSupport Add appropriate commands Make changes in application manager Issue : #3197 * Bug fix : Do not override message params if request setups it * Update SDD * fixup! Add application manager implementation for WebEngineSupport * fixup! Add Server WebSocket transport * Rename websocket dir to websocket_server * Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Update SDD * Fix/update app list after unregistration (#3252) * fixup! Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Rename websocket dir to websocket_server * Don't remove enabled WebEngine apps from pending apps * Rework WebEngine device ID generation * Fix build after back merge * Fix get app properties (#3258) Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> * Remove unused vin_code variable Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> Co-authored-by: Andriy Byzhynar (GitHub) <AByzhynar@luxoft.com> Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com> Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
* | Feature/Web Engine support (#3221)Alexander Kutsan (GitHub)2020-02-270-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add ini file parameters for WebEngineSupport Issue : #3197 * Add Server WebSocket transport * Policy changes for Web Engine support Issue : #3197 * Changes in HMI_API for WebEngineSupport Issue : #3197 * Add application manager implementation for WebEngineSupport Add appropriate commands Make changes in application manager Issue : #3197 * Bug fix : Do not override message params if request setups it * Update SDD * fixup! Add application manager implementation for WebEngineSupport * fixup! Add Server WebSocket transport * Rename websocket dir to websocket_server * Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Update SDD * Fix/update app list after unregistration (#3252) * fixup! Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Rename websocket dir to websocket_server * Don't remove enabled WebEngine apps from pending apps * Rework WebEngine device ID generation * Fix build after back merge * Fix get app properties (#3258) Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> * Remove unused vin_code variable Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> Co-authored-by: Andriy Byzhynar (GitHub) <AByzhynar@luxoft.com> Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com> Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
* | Feature/Web Engine support (#3221)Alexander Kutsan (GitHub)2020-02-27121-1135/+7307
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add ini file parameters for WebEngineSupport Issue : #3197 * Add Server WebSocket transport * Policy changes for Web Engine support Issue : #3197 * Changes in HMI_API for WebEngineSupport Issue : #3197 * Add application manager implementation for WebEngineSupport Add appropriate commands Make changes in application manager Issue : #3197 * Bug fix : Do not override message params if request setups it * Update SDD * fixup! Add application manager implementation for WebEngineSupport * fixup! Add Server WebSocket transport * Rename websocket dir to websocket_server * Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Update SDD * Fix/update app list after unregistration (#3252) * fixup! Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Rename websocket dir to websocket_server * Don't remove enabled WebEngine apps from pending apps * Rework WebEngine device ID generation * Fix build after back merge * Fix get app properties (#3258) Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> * Remove unused vin_code variable Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> Co-authored-by: Andriy Byzhynar (GitHub) <AByzhynar@luxoft.com> Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com> Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
* | don't send onSystemRequest LOCK_SCREEN_ICON_URL to mobile if url is missing ↵Collin2020-02-261-6/+9
| | | | | | | | (#3257)
* | Merge pull request #2713 from smartdevicelink/fix/update_supported_platformsJacob Keeler2020-02-262-1/+7
|\ \ | | | | | | Update supported environment and add to README
| * | Update supported environment and add to READMEfix/update_supported_platformsjacobkeeler2018-10-232-1/+7
| | |
* | | Add missing until param for enumeration elements (#3249)Yevhenii Dementieiev (GitHub)2020-02-261-0/+1
| | |
* | | Merge pull request #3255 from smartdevicelink/fix/issue_3254theresalech2020-02-251-7/+6
|\ \ \ | | | | | | | | update third_party.md for 2020 and json-cpp
| * | | update third_party.mdtheresalech2020-02-251-7/+6
| | | |
* | | | Add the ability to use IAP2 transport from build flags (#3219)Serhii Niukalov (GitHub)2020-02-256-11/+17
| | | |
* | | | Adapt fix #3203 for PROPRIETARY flow (#3242)Maksym Ked (GitHub)2020-02-209-6/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Adapt fix #3203 for PROPRIETARY flow * fixup! Adapt fix #3203 for PROPRIETARY flow Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com>
* | | | Merge pull request #3241 from smartdevicelink/fix/hash_id_rejected_paramsJacob Keeler2020-02-171-1/+2
|\ \ \ \ | | | | | | | | | | Properly populate rejectedParams for EndServiceNACK
| * \ \ \ Merge remote-tracking branch 'origin/develop' into fix/hash_id_rejected_paramsJackLivio2020-02-17100-625/+1399
| |\ \ \ \
| * | | | | Properly populate rejectedParams for EndServiceNACKfix/hash_id_rejected_paramsjacobkeeler2020-02-101-1/+2
| | | | | |
* | | | | | Merge pull request #3214 from smartdevicelink/fix/3rd_party_build_issuesJacob Keeler2020-02-171-23/+34
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Fix issue where building the logger would rebuild all other 3rd party libraries
| * | | | | Merge remote-tracking branch 'origin/develop' into fix/3rd_party_build_issuesfix/3rd_party_build_issuesJackLivio2020-02-17416-19604/+4924
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Fix LastState methods thread safe access (#2626)Ira Lytvynenko (GitHub)2020-02-1494-604/+1368
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix LastState instance thread safe access Fix LastState instance thread safe access and update dictionary usages in app launch and resumption. There was implemented LastStateWrapper class for providing exclusive thread safe access to LastState instance from all places in the program. Also passing LastState object was replaced with LastStateWrapper object to avoid direct access to LastState instance from another components. Thus there were a small updates in architecture of AM and TM classes. * Fixed mocks and unit tests related to LastState class * Add LastStateWrapper interface and LastStateWrapperPtr typedef * Fix tests after adding LastStateWrapper interface * Deprecate methods with changed signature * Adapt RCConsentManager according to LastState functionality There are some deprecated methods in LastState that are used by RCConsentManager. In addition, LastState::dictionary method returns reference to dictionary no more - only copy of latter. * Adapt AppServiceManager to new LastState usage * Adapt transport manager to new LastState usage * Adapt RPCPlugin to new LastState usage * Adapt AppServiceRPCPlugin to new LastState usage * Adapt RCRPCPlugin to new LastState usage * Adapt SDLRPCPlugin to new LastState usage * Adapt VehicleInfoPlugin to new LastState usage * Adapt existing unit tests * Fix ENABLE_LOG off build failure * Replace old-style loops with range based * Fix potential mutex deadlocks in resumption storage * Add Mutable Data Accessor. The entity that provides the thread-safe mutable access to data. * Fix submodule issues after merge Co-authored-by: Alexander Kutsan (GitHub) <akutsan@luxoft.com> Co-authored-by: Yaroslav Mamykin (GitHub) <33784535+YarikMamykin@users.noreply.github.com> Co-authored-by: Igor Gapchuk (GitHub) <41586842+IGapchuk@users.noreply.github.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | | | | | Fix core crash on accesing the application pointer. (#3194)Igor Gapchuk (GitHub)2020-02-122-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix core crash on accesing the application pointer. The issue will occur when the state controller gets an application collection from the application manager and tries to apply a functor to each application. One of the application's pointers could be uninitialized and the state controller should check if pointer is valid. * fixup! Fix core crash on accesing the application pointer.
* | | | | | Prevent creation of SSL context during certificate updating (#2777)Stanislav Kobziev (GitHub)2020-02-112-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Prevent creation of SSL context during certificate updating Added sync primitive into CryptoManagerImpl as class member and added lock into OnCertificateUpdated, CreateSSLContext methods for preventing race conditions * fixup! Prevent creation of SSL context during certificate updating Co-authored-by: Yevhenii Dementieiev (GitHub) <57259850+ydementieiev@users.noreply.github.com>
* | | | | | Fix ApplicationSet reference variables are not lock-protected (#3230)Jim-Nexty2020-02-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix for SDL Core crash after quickly and repeatedly connect/disconnect USB cable * modify code style
* | | | | | Fix for Bug:Deadlock happens during video streaming (#3231)Jim-Nexty2020-02-101-12/+16
| |/ / / / |/| | | | | | | | | | | | | | Co-authored-by: Collin <iCollin@users.noreply.github.com>
* | | | | Fix for No mechanism for managing the switching sequence(Start/StopSt… (#3217)Jim-Nexty2020-02-071-0/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix for No mechanism for managing the switching sequence(Start/StopStreaming) * change the code style * change the code style * Update src/components/application_manager/src/application_manager_impl.cc Co-Authored-By: Collin <iCollin@users.noreply.github.com> * Update src/components/application_manager/src/application_manager_impl.cc Co-Authored-By: Collin <iCollin@users.noreply.github.com> * change to cpp11 based loop and remove the useless else Co-authored-by: Collin <iCollin@users.noreply.github.com>
* | | | | fix warning in compiling core (#3236)Collin2020-02-061-2/+1
| | | | | | | | | | | | | | | remove reference to deprecated StyledStreamWriter
* | | | | #3211 [SDL 0234] Proxy Library RPC Generation (#3213)Vladyslav Mustafin2020-02-0636-2493/+1148
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * #3211 [SDL 0234] Proxy Library RPC Generation * Split existing `InterfaceGenerator` into `InterfaceParser` and `InterfaceGenerator` * Moved InterfaceParser into `smartdevicelink/rpc_spec` * Rejoined `InterfaceParser` as `tools/rpc_spec` Git submodule from `smartdevicelink/rpc_spec` * Refactored `InterfaceGenerator` to use Parser from `tools/rpc_spec` Git submodule and be compatible with Python 3.5 * Replaced url SSH to HTTPS in submodule * refactoring according to comments in pull/202 * move common parsers to rpc_spec repo * change cmake argument * fix cmake argument list * fix cmake argument list * fix cmake argument list * small refactoring as requested in code review * adding *.xsd * adding *.xsd * xmlschema dependency added for python interface generator * align changes from parser rpc_spec * align changes from parser rpc_spec * align with rpc_spec * moved xmlschema python dependency installation to build script * installing all python requirements * Corrected requirements file * Additional dependencies for requirements * Correcting requirements * adding jsoncpp submodule * fixing unit tests * fixing unit tests * rename CodeFormatAndQuality * updated rpc_spec reference Co-authored-by: Aleksandr Mishchenko <amishchenko@luxoft.com> Co-authored-by: Kostiantyn Sologubov <ksologubov@luxoft.com>
* | | | | Fix potential deadlock in application manager (#3215)Mykola Korniichuk (GitHub)2020-02-051-14/+18
| | | | |
* | | | | Merge pull request #3229 from smartdevicelink/fix/issue_3228theresalech2020-02-051-1/+1
|\ \ \ \ \ | | | | | | | | | | | | update license