summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix invalid iterator usagefix/invalid_iterator_clustermodesjacobkeeler2022-01-191-2/+1
|
* Cyclic UpdateDeviceList and UpdateAppList in case device is connected (#3835)RomanReznichenkoLuxoft2022-01-132-10/+37
| | | * Added a check to make the script does not work when there is not device
* SDL doesn't send up_to_date (#3834)Olha Vorobiova (GitHub)2022-01-132-0/+3
| | | | | * Correct UpdateStatusManager behavior after kOnValidUpdateReceived * Added an initialization of flags in external proprietary mode
* Convert Common_SamplingRate and Common_BitsPerSample enums to uint (#3837)Olha Vorobiova (GitHub)2022-01-113-22/+63
|
* fix/sdl_did_not_read_correctly_value_of_hmicapabilities_from_hmicapabilities ↵RomanReznichenkoLuxoft2022-01-119-10/+139
| | | | | | | | | | | cachefile (#3820) * sdl_read_value_navigation_and_phonecall_from_hmicapabilities_and_did_not_from_systemcapabilities * Update src/appMain/hmi_capabilities.json Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Fix JSON validation for QUERY_APPS (#3827)Vadym Luchko (GitHub)2022-01-111-31/+41
| | | fix validation of synonyms in QUERY_APPS system request
* changed the way you add soft buttons in the subscription method (#3839)RomanReznichenkoLuxoft2022-01-114-6/+2
|
* use files from the rps_spec folder without copying to the sdl_core (#3778)RomanReznichenkoLuxoft2022-01-105-12/+9
|
* Replace clusterModeStatus with clusterModes and vise versa (#3830)Yana Chernysheva (GitHub)2022-01-073-6/+19
|
* state_controller subscription (#3836)Vadym Luchko (GitHub)2022-01-061-5/+12
|
* Fix rare crash during streaming switching (#3833)Olha Vorobiova (GitHub)2021-12-221-2/+3
|
* Ensure valid application pointer in RAI::CheckLanguage and ↵Collin2021-11-232-5/+17
| | | | | | | | | | | FinishSendingResponseToMobile (#3815) * don't use null application ptr in RAI::CheckLanguage or FinishSendingResponseToMobile * prevent application nullptr deref in SendRegisterAppInterfaceResponseToMobile * check application valid in ApplicationDataShouldBeResumed * restore ResumeCtrlImpl DCHECKs
* added an ontimeout method to handle a timeout request (#3803)RomanReznichenkoLuxoft2021-11-102-0/+10
|
* Do not modify application list while iterating it (#3806)Collin2021-11-0910-109/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * do not modify applications array while iterating it * remove unnecessary and dangerous iterator++ * fixup! do not modify applications array while iterating it restore sending on language change to mobile * deref app ptr while holding app list lock * SendNotificationToMobile can also invalidate apps list iterator by calling unregister application * apply fix to TTS and VR on language change * Revert "Fix early IsRegistered() state of application (#3796)" This reverts commit 0ed38e8d2f7cb3a61a303cca2806a06ce9a1d58d. * revert #3799 * prevent crash with null app in rai response * do not deactivate app before unregistering in case of vr language change * make copy of ApplicationSet instead of pushing app_ids to vector * address failure of 3797_3798 atf test in extprop policy mode * fixup! address failure of 3797_3798 atf test in extprop policy mode only send NO_APPS_REGISTERED when no apps are registered * fix ext prop unit test and APPLICATION_NOT_REGISTERED log message * fixup! fix ext prop unit test and APPLICATION_NOT_REGISTERED log message fix style * simplify code copying applicationset
* Fix ThreadedSocket disconnect logic (#3566)Andrii Kalinich (GitHub)2021-11-092-25/+46
| | | | | | | | | | | | | | | | | | | | | | | | | * Fix ThreadedSocket disconnect logic There was noticed an issue with ThreadedSocket connection which often closes connection like an "unexpected disconnect" calling `ConnectionAborted()` every time even if it is handled disconnect. Also, there were no any events raised to Transport Manager for rare cases when disconnect is expected. To fix that, flow has been separated for handling expected and unexpected disconnect. Expected disconnect will be handled in case when external component calls `Disconnect()` and socket thread is alive. In that case should be called `DisconnectDone()` when thread is stopped. Unexpected disconnect will be handled in case when internal thread has been aborted and `Abort()` was called. In that case internal thread `ConnectionAborted()` will be called from internal thread to notify Transport Manager that physical disconnect has happened. This issue is pretty hard to detect just because business logic handles both disconnect types in the same way for now, but this might be changed in the future. * Update Boost Download URL Co-authored-by: JackLivio <jack@livio.io>
* Reset display_capabilities_ pointer after merging capabilities (#3812)Jacob Keeler2021-11-081-3/+5
|
* Fix unstable policy handler test (#3810)Andrii Kalinich (GitHub)2021-11-081-29/+25
| | | | | | | | | | | | * Fix unstable policy handler unit tests Looks like there was a missing async waiter in some unit tests so Async thread is still working when unit test is already finalized. That causes a core crashes and random unit tests failures. Was added `UnloadPolicyLibrary()` call to stop the async thread before finalizing the unit test. * Increase timeout for tests
* Fix unstable unit test (#3809)Andrii Kalinich (GitHub)2021-11-051-0/+4
| | | | | | | Looks like we have to properly shutdown message queue in the unit test which emulates data sending over the secured websocket session. Otherwise, unit test might be terminated earlier and data sending will be failed which causes a core crash.
* Update minimum value of MaxSupportedProtocolVersion to 2 (#3801)Jacob Keeler2021-11-042-3/+3
| | | If this value is set to 1, no apps can register because SDL Core responds with UNSUPPORTED_VERSION to protocol V1 messages (besides the initial StartService)
* Merge remote-tracking branch 'origin/master' into developJackLivio2021-10-271-0/+0
|\
| * Merge pull request #3775 from smartdevicelink/release/8.0.08.0.0JackLivio2021-10-27620-10863/+10778
| |\ | | | | | | Release 8.0.0
| | * Update rpc spec commitrelease/8.0.0JackLivio2021-10-271-0/+0
| | |
* | | Merge branch 'release/8.0.0' into developcollin2021-10-2646-234/+482
|\ \ \ | | |/ | |/|
| * | Fix issues with web app activation (#3799)8.0.0-RC2Andrii Kalinich (GitHub)2021-10-214-41/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add initial states for pending applications This would prevent crashes for cases when app will be attempted to be activated. * Fix UpdateAppList content * Fix checks in SDL.ActivateApp * Fix unit tests
| * | Removed the unit that interrupted the sequence of closing the connect… (#3785)RomanReznichenkoLuxoft2021-10-151-49/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Removed the unit that interrupted the sequence of closing the connection to the device via usb * Update logic for USB in transfer * fixup! Update logic for USB in transfer Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
| * | Fix early IsRegistered() state of application (#3796)Andrii Kalinich (GitHub)2021-10-148-39/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix early IsRegistered state of application Mark application as registered only when app registration was finalized and all corresponding requests were sent to HMI. This prevents data races in case when language has been changed by HMI and application is in intermediate registration state yet. * fixup! Fix early IsRegistered state of application
| * | Fix/crash after ptu for another app hmi type (#3795)Andrii Kalinich (GitHub)2021-10-1427-121/+186
| | | | | | | | | | | | | | | | | | | | | * Added RC plugin extension after PTU * Add new event `kAppHmiTypesChanged` Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>
| * | Fix VR.ChangeRegistration issue (#3794)Andrii Kalinich (GitHub)2021-10-131-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | There was found a misprint for a VR interface in `ChangeRegistration` request. Because of that, there might be a situations when HMI responds to one part of request faster than another part was actually sent. All required ordering and checks were updated.
| * | Fix wrong behavior of RCOnRemoteControlSettingsNotification (#3792)Andrii Kalinich (GitHub)2021-10-124-20/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix wrong behavior of RCOnRemoteControlSettingsNotification Looks like `kAllowed` parameter was swithing on/off the RC functionality even if it was not present and previous value should be taken. Processing of `kAllowed` and `kAccessMode` was split on two separate and independent functions make it really isolated. Processing of both parameters was aligned, so now core does not perform extra actions if one of parameter is missing.
| * | Fix SDL build with USE_COTIRE=OFF (#3791)Andrii Kalinich (GitHub)2021-10-115-2/+15
| | |
| * | Check specifically for invalid HMI level when suspending notifications (#3784)Jacob Keeler2021-10-061-2/+4
| | | | | | | | | | | | | | | * Check specifically for invalid HMI level before suspending notifications Checking for main window ID caused a very rare race condition where the notification was not suspended when necessary
* | | Changed clang-format version from 6 to 8 (#3777)Andrii Kalinich (GitHub)2021-10-151-1/+1
| | | | | | | | | Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>
* | | Send a request when the policy table is disabled. (#3767)RomanReznichenkoLuxoft2021-10-151-0/+8
| | |
* | | Added python packages' check (#3776)Andrii Kalinich (GitHub)2021-10-153-6/+17
| | | | | | | | | Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>
* | | Remove unused policy table fields (#3771)Andrii Kalinich (GitHub)2021-10-1419-289/+231
| | | | | | | | | | | | | | | | | | | | | * Removes 'memory_kb' * Removes 'device_certificates' Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>
* | | Fix applying functional group consent for all applications (#3770)Andrii Kalinich (GitHub)2021-10-121-5/+1
| | | | | | | | | Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>
* | | Added build path to lcov command (#3786)Andrii Kalinich (GitHub)2021-10-111-1/+1
| | | | | | | | | Co-authored-by: OlhaVorobiova <olha.vorobiova@dxc.com>
* | | Prevent restoring resumption-related data after MASTER_RESET (#3287)Mykhailo Vorobiov (GitHub)2021-10-111-1/+0
| | | | | | | | | Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* | | print to console on crash from signal handler (#3789)Collin2021-10-071-0/+2
|/ /
* | Fix descriptions for AudioControlCapabilities and SeatControlCapabilities ↵8.0.0-RC1Jacob Keeler2021-09-291-2/+2
| | | | | | | | (#3782)
* | Prevent HMI commands processing while SDL is stopping (#3781)VladSemenyuk2021-09-282-1/+4
| |
* | Add missing internal error codes to security manager (#3773)Jacob Keeler2021-09-147-16/+139
| | | | | | | | | | | | | | | | | | | | | | * Add missing internal error codes to security manager * Add internal error notification to SSL handshake failure * Remove unused handshake result * Add unit tests for new error codes Co-authored-by: JackLivio <jack@livio.io>
* | fix WebSocketServerTransportAdapter::Store write to last state (#3772)Collin2021-09-101-1/+4
| | | | | | | | | | * WebSocketServerTransportAdapter::Store write to last state * hold lock until we set dict or decide not to
* | Clear Parent Reference to Begin State When it is Erased (#3769)Collin2021-09-091-1/+6
| | | | | | | | | | | | | | | | | | * clear any parent reference to the state being erased even when it is the begin state * Apply suggestions from code review Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Fix stopping video without audio streaming (#3752)Andrii Kalinich (GitHub)2021-08-276-144/+289
| | | | | | | | | | | | | | | | | | | | * fix defect with stoping video without audio streaming * Isolate audio and video streaming * Remove app unregistration if EndServiceAck not received Also, application should not be switched to NONE in case when at least one streaming is already approved and active
* | Fix/ccb 3141 change command request inheritance structure (#3591)VladSemenyuk2021-08-27290-2276/+3047
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Change command request inheritance structure. Fix data races during requests event processing. * Change commands according to new inheritance structure. * Change unit tests according new inheritance structure. * Fix review comments * Fix build after merge * Fix format style * Fix recursion in SetGlobalProperties * Add delay before request releasing That gives to event dispatcher some time to figure out that event should not be rasied for a finalized request and this request will be released soon. Also, this allows to avoid calling some virtual functions on pointer to invalidated object. * Fix data races in EventDispatcher Now reference counter is increased indirectly by event dispatcher before calling `HandleOnEvent()` of specific observer. This will guarantee that during `HandleOnEvent` the command object is still be alive. * Revert changes for SetGlobalProperties Co-authored-by: v-seme12 <vsemenyuk@kiev.luxoft.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* | Send REQUEST type and generated sequence number in SendHandshakeData (#3761)Jacob Keeler2021-08-274-20/+38
| | | | | | | | | | * Send REQUEST type and generated sequence number in SendHandshakeData * Update query type in tests
* | Fix build failure when EXTENDED_MEDIA_MODE=ON (#3766)Jacob Keeler2021-08-271-4/+0
| |
* | Add method for delete empty message (#3751)Andrii Kalinich (GitHub)2021-08-256-0/+79
| | | | | | | | | | | | | | * Add method for delete empty message * Add WARNINGS code when some parameters were cut off Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Remove language code ES-EN and EN-IE from the project (#3757)Collin2021-08-256-831/+0
| | | | | | | | | | | | | | * remove invalid language code es-en from preloaded pt * remove es-en from other pt files * remove en-ie language