summaryrefslogtreecommitdiff
path: root/src/components/application_manager/src
Commit message (Collapse)AuthorAgeFilesLines
* Address review commentsfeature/deprecated_method_macrojacobkeeler2018-01-173-5/+6
| | | | | | Remove C style casts Add comments for pragma directives Remove redundant DEPRECATED macro usages
* Add DEPRECATED macro, and fix resulting deprecated warningsjacobkeeler2017-12-044-12/+10
|
* Create correct structure of SubscriveVehicleData ResponseAlexander Kutsan2017-11-271-2/+15
| | | | | Convert to string keys of already subscribed vehicle data Add data type of already subscribed vehicle data
* Use VehicleDataType from MOBILE APi xml imstead of hardcoded valuesAlexander Kutsan2017-11-278-41/+69
| | | | | | Delete include of application_manager/vehicle_info_data.h Fix unit tests
* Merge pull request #1855 from ↵Jacob Keeler2017-11-222-12/+20
|\ | | | | | | | | AKalinich-Luxoft/fix/fix_streaming_retry_sequence_logic Fix application start streaming retry sequence
| * Fix application start streaming retry sequenceAKalinich-Luxoft2017-11-152-12/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a problem with retry sequence which is triggered when user rejecets/ignores prompt regarding starting audio streaming on HMI. The problem is when user clicks Cancel then SDL sends new request in the sequence and not removes old one from queue. As a result we have two identical requests and each of them could trigger next iteration of retry sequence at the same time. As a result, next try could be started earlier than expected. For example if streaming retry sequence has 3 retries with 1 second timeout: - MOB -> SDL Request to start audio streaming - SDL -> HMI Prompt user to start streaming for active app (request 1) - User clicks "No" during 1 sec - HMI -> SDL User has clicked No (request 1 still in queue!) - SDL starts streaming retry sequence - SDL -> HMI First retry and waiting for result during 1 sec (request 2) - No answer from user during 1 sec - Tiemout from request 1: trird retry - Tiemout from request 2: retry limit reached. Streaming not allowed In this update was added request termination in case user rejects or accepts the request.
* | Optimize using of CheckResultCodeAlexander Kutsan2017-11-151-5/+8
| | | | | | | | Move additional checks from PrepareResultForMobileResponse to CheckResultCode
* | Process multiple HMI interfaces of change registration requestAlexander Kutsan2017-11-131-44/+108
| | | | | | | | Chage registration
* | Process result codes and infos from multiple HMI interfacesAlexander Kutsan2017-11-139-132/+217
| | | | | | | | | | | | | | Created ResponseParams structure with couple of help functions to merge result codes from HMI, infos from HMI and generate success for mobile response Unit tests for checking Is state is available
* | Common functionality awaiting of certain HMI requestsAlexander Kutsan2017-11-1335-25/+155
|/ | | | | | | | Add private methods in CommandImpl: - StartAwaitForInterface - EndAwaitForInterface - IsInterfaceAwaited Add usage of this methods across of commands that splited to multiple HMI interfaces
* Merge pull request #1627 from ↵Jacob Keeler2017-11-021-7/+25
|\ | | | | | | | | LuxoftAKutsan/fix/SDL_responds_GENERIC_ERROR_instead_of_INVALID_DATA_when_soft_button_has_Type_is_Image_or_Both Fix issue with incorrect behaviour in AlertManeuver
| * Fix typosAndriy Byzhynar (GitHub)2017-09-081-3/+3
| |
| * fixup! Fix issue with incorrect behaviour in AlertManeuverAlex Kutsan2017-06-221-12/+11
| | | | | | | | | | | | Review changes : Changes Unappropriate variables names Add using definitions
| * Fix issue with incorrect behaviour in AlertManeuverokozlovlux2017-06-191-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | - fixed issue when in AlertManeuver SDL responds GENERIC_ERROR instead of INVALID_DATA when soft button has Type is Image or Both and Text is whitespace or \t or \n or empty - fixed failed UTs - added DCHECK condition - used local variable Related to Issue-980
* | Merge pull request #1625 from LuxoftAKutsan/fix/system_request_with_filename_IVSJacob Keeler2017-11-021-13/+2
|\ \ | | | | | | Fix SystemRequest with filename=IVSU but w/o binary data
| * | Fix SystemRequest with filename=IVSU but w/o binary dataIvo Stoilov (GitHub)2017-06-241-13/+2
| |/ | | | | | | The fix removes legacy support for 'IVSU' files.
* | Merge remote-tracking branch 'dev-gh/fix/Memory_leaks' into developjacobkeeler2017-11-023-5/+19
|\ \
| * | Replaces raw member pointer with utils::SharedPtrAndrey Oleynik2017-09-081-0/+14
| | |
| * | Fix minor memory leaksSergey Levchenko (GitHub)2017-09-083-8/+6
| | |
* | | Fixes responses 'success' value in case of UNSUPPORTED_RESOURCE (#1576)Andrey Oleynik (GitHub)2017-11-023-16/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fixes 'success' value in case of UNSUPPORTED_RESOURCE There is only one case for 'success' to have 'false' with UNSUPPORTED_RESOURCE - when there is single-interface RPC comes and that specific interface is not available i.e. <interface>.IsReady returned 'false' Changes done for base class and unit tests with wrong expectations. * Fix response to mobile result Fixed result to mobile in case of GENERIC_ERROR from hmi and iface does not response * Fix ut tests according to code changes * Fix regression
* | | Fix case sensitive app name and id comparison (#1614)Andrii Kalinich (GitHub)2017-11-023-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add COLLATE NOCASE property for application_id and nickname columns and indices Added COLLATE NOCASE property for application_id and nickname columns and indices related to them in order to make them case insensitive for query select/insert/update. Changed policy id case to lower. Because of case sensitive file path all files and directories which contains policy id of related application, will be saved in lower case to keep SDL applications path case insensitive. * Fix loading preloaded PT from JSON file There was additional case when policy table is loading from preloaded JSON file. In this case there was case sensitive loading of app groups.
* | | Merge pull request #1611 from ↵JackLivio2017-11-021-2/+12
|\ \ \ | | | | | | | | | | | | | | | | AKalinich-Luxoft/fix/fix_subscribevehicledata_subscriptions Fix SubscribeVehicleData request subscriptions
| * | | Fix SubscribeVehicleData request subscriptionsAKalinich-Luxoft2017-06-141-2/+12
| | |/ | |/| | | | | | | | | | | | | The main idea here is to perform subscriptions only after SDL receives successful result from HMI. In case of erroneous result code SDL should not subscribe to requested VehicleData.
* | | RC capabilities is set in RC.GetCapabilities, not UI.GetCapabilitiesfix/rc_capabilitiesjacobkeeler2017-10-123-15/+13
| | | | | | | | | Also make sure to set rc_supported based on the result of this RPC
* | | Reject invalid enum values in video paramsfix/validate_video_params_enumsjacobkeeler2017-10-061-14/+20
| | | | | | | | | Fixes issues where invalid enum values are ignored but still reciprocated in the StartSessionACK
* | | Fix compilation warning #1789JackLivio2017-09-292-9/+9
| | | | | | | | | | | | Changes made in #1789 + compilation fix. Original author @shoamano83
* | | Revert "fix: build break with ENABLE_LOG=OFF"revert-1789-fix/build_break_without_logJackLivio2017-09-282-9/+9
| | |
* | | Merge pull request #1789 from shoamano83/fix/build_break_without_logJackLivio2017-09-282-9/+9
|\ \ \ | | | | | | | | fix: build break with ENABLE_LOG=OFF
| * | | Remove temporary value app_idSho Amano2017-09-281-7/+5
| | | | | | | | | | | | | | | | Reflecting review comment.
| * | | fix: build break with ENABLE_LOG=OFFSho Amano2017-09-282-4/+6
| | |/ | |/|
* | | Add `remoteControl` to HMICapability struct in Mobile APIfix/remote_control_supportedJacob Keeler2017-09-264-0/+26
| | |
* | | Merge pull request #1775 from smartdevicelink/fix/update_mobile_api_4.4.0Jacob Keeler2017-09-261-3/+0
|\ \ \ | | | | | | | | Update MOBILE_API.xml to match `rpc_spec` repo
| * | | Update MOBILE_API.xml to match `rpc_spec` repofix/update_mobile_api_4.4.0jacobkeeler2017-09-221-3/+0
| | | | | | | | | | | | Includes fixes to build issues resulting from this update.
* | | | Merge pull request #1776 from JackLivio/fix/haptic_data_nav_onlyJackLivio2017-09-251-1/+16
|\ \ \ \ | | | | | | | | | | Require nav or projection app for SendHapticData
| * | | | Require nav or projection app for SendHapticDataJackLivio2017-09-251-1/+16
| |/ / /
* | | | Merge pull request #1763 from ↵JackLivio2017-09-251-0/+9
|\ \ \ \ | |/ / / |/| | | | | | | | | | | shoamano83/fix/enable_system_capabilities_from_file Fix/enable system capabilities from file
| * | | Remove unnecessary set_xxx_supported() callsSho Amano2017-09-221-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These calls are not needed unless load_capabilities_from_file() is called multiple times. Unit test cases are also updated so that the function is called only once. Reflecting review comment.
| * | | fix: update supported flags of system capabilities when reading from fileSho Amano2017-09-131-0/+12
| |/ /
* | | Fix style issuesfix/coverity_issues_4.4.0jacobkeeler2017-09-211-3/+3
| | |
* | | Fix resource leaks introduced in RC baselinejacobkeeler2017-09-212-9/+4
| | | | | | | | | Fixed CIDs 174941 and 174934
* | | Fix SDL crash on exit/unregistering of non-RC applicationAKalinich-Luxoft2017-09-182-2/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SDL plugin manager is receiving notifications from application manager when any application was deactivated or unregistered. This notification will be transfered from plugin manager to RC plugin. However RC plugin processes events from any application so when it try to process event from non-RC application, SDL crashes. RC plugin should process events only from applications with RC functionality. Also there is another problem when application is unregistering its app_id() is removing from applications list in AM before OnApplicationEvent() call so when some of plugins will try to get shared_ptr using app_id, it will receive null pointer, however in AM still exists shared_ptr to this app. So it will be better to pass shared_ptr of application instead of accessing to it every time from plugins using app_id parameter. Moreover, some of plugins could require more information about application in future. Following changes were done: - Updated OnApplicationEvent() with application shared_ptr param for plugin manager and all related plugins - RC plugin now triggers OnApplicationEvent only for events from RC applications
* | Merge pull request #1746 from ChrisB-Elektrobit/feature/metadata_taggingJacob Keeler2017-09-072-2/+62
|\ \ | | | | | | Feature/metadata tagging
| * | - performed renamings suggested in smartdevicelink/sdl_evolution#239ChrisB-Elektrobit2017-08-172-8/+7
| | |
| * | - changing Show Request metadata but no data warning result code from ↵ChrisB-Elektrobit2017-08-171-1/+1
| | | | | | | | | | | | IGNORED to WARNINGS
| * | - adding warning result code and info message to ShowResponse to handleChrisB-Elektrobit2017-08-141-4/+18
| | | | | | | | | | | | | | | the case where metadata tags are provided without a corresponding mainField entry.
| * | - removed some extraneous logging to clean up the code a bitChrisB-Elektrobit2017-08-111-12/+4
| | |
| * | - added new ShowRequest::HandleMetadata function for the Show RPC toChrisB-Elektrobit2017-08-082-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | handle mapping metadata values from incoming mobile protocol to outgoing HMI protocol - hooked HandleMetadata() into ShowRequest::run() for the four mainFields - added new metadata json string entries to smart_object_keys.h/.cc
* | | Merge pull request #1620 from AByzhynar/fix/FixFactoryDefaultsJacob Keeler2017-09-072-5/+47
|\ \ \ | | | | | | | | Clear persistent data of all registered applications after FACTORY_DEFAULTS and MASTER_RESET
| * | | Fix SDL behavior in case of MASTER_RESET & FACTORY_DEFAULTSVeronica Veremjova2017-06-212-5/+47
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | After SDL receives - BC.OnExitAllApplications(MASTER_RESET) : SDL should clear stored persistent data of all registered applications and revert local PT to preloaded state. - BC.OnExitAllApplications(FACTORY_DEFAULTS): SDL should clear stored persistent data of all registered applications and remove all user consents from local PT.
* | | Merge pull request #1634 from ↵Jacob Keeler2017-09-061-2/+5
|\ \ \ | | | | | | | | | | | | | | | | LitvinenkoIra/fix/SDL_sends_BC.UpdateDeviceList_without_of_upper_bound_size_of_deviceList Add limitation of size for deviceList in BC.UpdateDeviceList RPC
View Lorry Controller Status