summaryrefslogtreecommitdiff
path: root/src/components/protocol_handler
Commit message (Collapse)AuthorAgeFilesLines
* Added logic related to certificate savingfix/fix_certificate_saving_after_ptuAKalinich-Luxoft2018-06-182-103/+4
| | | | Also was removed redundant logic
* Add correct certificate expiration handlingAndriy Byzhynar2018-06-181-7/+1
|
* Fix decrypted multiframe message handlingAndriy Byzhynar2018-06-184-7/+31
| | | | | Fixed SDL behavior in case when FIRST_FRAME received from mobile was encrypted
* Add handling of wrong force protection settings in ini fileAndriy Byzhynar2018-06-181-0/+6
|
* Merge pull request #2105 from smartdevicelink/feature/get_system_timeJacob Keeler2018-06-185-26/+93
|\ | | | | Feature/get system time
| * Move out unrelated to feature changesAKalinich-Luxoft2018-06-042-3/+94
| | | | | | | | | | | | There was included some changes related to certificate processing. They will be included into related pull request
| * Additional fixes after ATF testingAKalinich-Luxoft2018-05-314-108/+17
| | | | | | | | | | | | | | | | | | Fixed OnCertificateUpdated notification callback for empty certificate Fixed GetSystemTime triggering Fixed handshake resuming on system time arrived Fixed wrong logic in case system time is not ready Removed redundant logic for non-navi applications Removed PTU triggerring for navi on empty certificate in DB
| * Implement fully functional GetSystemTime featureAndriy Byzhynar2018-04-065-25/+92
| | | | | | | | | | | | Implemented fully working GetSystemTime feature Fixed UT in the security manager due to code changes Disable randomly failed test
* | Fix protocol handler unit testIra Lytvynenko (GitHub)2018-06-121-2/+4
|/
* Fix build issues and test failures when building with ENABLE_SECURITY=OFFfix/security_off_buildjacobkeeler2018-03-213-15/+24
|
* Answer review commentsAKalinich-Luxoft2018-01-301-0/+3
|
* Fixed mocks and related unit testsAKalinich-Luxoft2018-01-291-147/+193
| | | | | | | | NotifySessionStartedResult function were renamed to NotifySessionStartedContext due to complexity of working with overloaded functions in unit test classes. Fixed protocol and connection handler unit tests. Fixed security manager tests.
* Minor refactoring in protocol and security managerAKalinich-Luxoft2018-01-293-10/+15
| | | | | | Added consts for some methods. Fixed typos in description. Renamed some non informative variables names.
* ProtocolHandlerImpl was extended with PolicyHandlerObserverAKalinich-Luxoft2018-01-292-6/+113
| | | | | | | ProtocolHandlerImpl was extended with PolicyHandlerObserver logic and added function with related implementation. Also was updated logic of NotifySessionStartedResult with case when PTU should be triggered.
* Refactoring in connection/protocol handlersAKalinich-Luxoft2018-01-292-50/+54
| | | | | | | | NotifySessionStartedResult function were updated to use StartingSessionContext class for accessing to needed data instead of tones of separate parameters. Also in protocol handler some raw pointer data were replaced with smart objects.
* Old StartSessionHandler class moved to a separate unitAKalinich-Luxoft2018-01-294-135/+343
| | | | | | | Old StartSessionHandler class moved to a separate unit and renamed to HandshakeHandler according to its logic. Also this class was updated to use StartingSessionContext and was updated OnHandshakeDone logic according to requirements.
* Address review commentsfeature/deprecated_method_macrojacobkeeler2018-01-171-1/+2
| | | | | | Remove C style casts Add comments for pragma directives Remove redundant DEPRECATED macro usages
* Add DEPRECATED macro, and fix resulting deprecated warningsjacobkeeler2017-12-042-14/+16
|
* Merge pull request #1769 from shoamano83/fix/deprecate_service_data_ackJacob Keeler2017-09-282-21/+78
|\ | | | | fix: send Service Data ACK frames only for version 2-4
| * fix: send Service Data ACK frames only for version 2-4Sho Amano2017-09-222-21/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | The protocol spec document https://github.com/smartdevicelink/protocol_spec says that the frame is deprecated. Looking at its commit history the frame has been marked as deprecated before introducing protocol version 5. Also, looking at the comment in protocol_handler_impl.cc the frame wasn't meant to send out in protocol version 1. Therefore this fix will limit the use of Service Data ACK for protocol version 2 through 4.
* | Validate outgoing video paramsfix/video_capabilities_validationjacobkeeler2017-09-251-3/+28
| | | | | | Reverts this section back to https://github.com/shoamano83/sdl_core/commit/f6ea1262c4b6a3d1e10dc89fa570720a6c85ea9d#diff-4a7a19ae471dc741759dcc42796f9fc3R1513
* | Fix style issuesfix/coverity_issues_4.4.0jacobkeeler2017-09-211-3/+6
| |
* | Fix coverity issues related to protocol changesjacobkeeler2017-09-213-7/+8
|/ | | Fixes CIDs 174942, 174939, 174936, 174936
* Merge remote-tracking branch ↵jacobkeeler2017-09-082-12/+21
|\ | | | | | | 'LuxoftAKutsan/fix/SDL_respond_ACK_with_protocol_version_4_for_video_and_audio_services_instead_of_negotiatied_version_protocol' into develop
| * fixup! Fix incorrect behaviour of SDL during respose ACK whenr video and ↵Alex Kutsan2017-06-232-5/+8
| | | | | | | | audio services starts
| * Fix incorrect behaviour of SDL during respose ACK whenr video and audio ↵okozlovlux2017-06-201-2/+5
| | | | | | | | | | | | | | | | | | | | services starts - added condition in SendStartSessionAck to avoid sending max supported protocol version when video or audio services start. SDL must send negotiated protocol_version from message from mobile app Related to Issue-1365
* | Merge remote-tracking branch 'origin/develop' into ↵Alexander Kutsan2017-08-221-6/+12
|\ \ | | | | | | | | | | | | | | | feature/sdl_remote_control_baseline For getting changes of protocol 5 version negotiation
| * | Fix version negotiation for pre-v5 appsfix/version_negotiation_pre_v5Jacob Keeler2017-08-181-6/+12
| | | | | | | | | The previous expected behavior was to send the maximum protocol version supported by Core in the first StartSessionACK. Now a hard limit of `PROTOCOL_VERSION_4` is set if the proxy doesn't support version 5, as v5 involves a change to the payload structure.
* | | Integration with develop fixesAlexander Kutsan2017-08-161-6/+9
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | Add dependecies for protocol packet Integraiton issues fix Add missed READ_ONLY Fixes after integration Fix policy handler remote unit tests Fix unit tests after integration
* | Merge pull request #1719 from shoamano83/fix/build_break_protocol_packet_testJacob Keeler2017-08-161-3/+6
|\ \ | | | | | | fix: build failure in protocol_packet_test.cc
| * | fix: build break in protocol_packet_test.ccSho Amano2017-08-121-3/+6
| | |
* | | Fix: deinitialize BSON objectjacobkeeler2017-08-141-0/+1
| | |
* | | Fix style issuesjacobkeeler2017-08-141-17/+15
| | |
* | | Fix crash related to previous refactoringjacobkeeler2017-08-141-2/+5
| | | | | | | | | The `protocolVersion` parameter was being read from `start_session_act_params`, which was not populated in the `RPC` service case. This change fixes this and adds a check to make sure that the parameter exists before constructing a version object from the payload.
* | | Refactoring of NotifySessionStartedResultjacobkeeler2017-08-141-50/+30
| | |
* | | fix: don't use local var for mock OnSessionStartedCallback() callSho Amano2017-08-121-26/+14
| | | | | | | | | | | | Reflecting review comments.
* | | Fix usage of StartSessionHandler to include payload params.jacobkeeler2017-08-111-6/+25
| | |
* | | Just copy the parameters from the original message rather than check and ↵jacobkeeler2017-08-111-28/+4
| | | | | | | | | | | | copy individually
* | | fix: missing deinit of temporary BSON objectSho Amano2017-08-111-0/+1
| | |
* | | Update SendStartSessionAck() to always receive paramsSho Amano2017-08-112-93/+55
| | | | | | | | | | | | | | | | | | | | | | | | SendStartSessionAck() now uses given BSON object instance to append generic parameters such as mtu, instead of creating another BSON instance. Reflecting review comments.
* | | Remove deprecated enable_protocol_5() method in test codeSho Amano2017-08-111-2/+2
| | | | | | | | | | | | Reflecting review comments.
* | | Add video related keys in bson_object_keys.ccSho Amano2017-08-112-25/+36
| | |
* | | Append video releated parameters in Start Service ACK packetSho Amano2017-08-113-8/+145
| | | | | | | | | | | | Reflecting review comments.
* | | Add unit test to simulate two video StartService packetsSho Amano2017-08-111-0/+172
| | |
* | | fix: session ID and hash ID may be notified to wrong proxySho Amano2017-08-113-38/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit includes following changes: - Add connection_id and session_id args in ProtocolHandler::NotifySessionStartedResult() - Use pair of connection_id and session_id to remember the request packet until NotifySessionStartedResult() is called Reflecting review comments.
* | | Deprecate OnSessionStartedCallback()Sho Amano2017-08-111-39/+57
| | | | | | | | | | | | Reflecting review comments.
* | | Deprecate HandleControlMessageStartSession()Sho Amano2017-08-112-0/+157
| | | | | | | | | | | | Reflecting review comments.
* | | fix: increase stack size of protocol handler threadsSho Amano2017-08-111-1/+1
| | | | | | | | | | | | | | | | | | | | | Since we have more method calls starting from OnSessionStartedCallback(), we may encounter a stack overflow issue (tested on Ubuntu 16.04 x86_64 box). The stack size is increased to avoid such issue.
* | | fix: avoid crash in bson_object_from_bytes() when data is NULLSho Amano2017-08-111-1/+6
| | |
* | | fix: build break in protocol_header_validator_test.ccSho Amano2017-08-111-4/+4
| | |
View Lorry Controller Status