Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix resource leakhotfix/resource_leak | jacobkeeler | 2017-06-22 | 1 | -1/+1 |
| | | | The `release` function for `auto_ptr` does not free the allocated memory, `reset` does. | ||||
* | Fix error caused by merge of `develop` into `coverity_fixes` branch | jacobkeeler | 2017-06-22 | 1 | -1/+0 |
| | |||||
* | Merge pull request #1641 from smartdevicelink/hotfix/4.3-RC_coverity_fixes | JackLivio | 2017-06-22 | 15 | -81/+86 |
|\ | | | | | 4.3 release candidate coverity fixes | ||||
| * | Fix for CID 171208hotfix/4.3-RC_coverity_fixes | jacobkeeler | 2017-06-22 | 1 | -2/+6 |
| | | | | | | Check return value for GetDeviceID | ||||
| * | Fix CID 171131 | jacobkeeler | 2017-06-22 | 3 | -3/+4 |
| | | | | | | Initialize variables in empty constructor for ExternalConsentStatusItem | ||||
| * | New fix for CID 171125, 171127, and 171128 | jacobkeeler | 2017-06-22 | 1 | -33/+31 |
| | | | | | | Removed the rpc_hmi_permissions and rpc_parameter_permissions variables and used the rpc accessors instead. Otherwise comparisons were being made from iterators made from two different variables | ||||
| * | Coverity Fixes in cache manager | JackLivio | 2017-06-22 | 2 | -1/+4 |
| | | |||||
| * | Fix for coverity 171199 | JackLivio | 2017-06-22 | 1 | -6/+0 |
| | | | | | | | | “SmartObjectToInt” is never actually used anywhere in the project… goodbye! | ||||
| * | Fix for 170753 & 170763 | JackLivio | 2017-06-21 | 4 | -5/+9 |
| | | |||||
| * | Fix for cov 171196 | JackLivio | 2017-06-21 | 5 | -13/+13 |
| | | | | | | | | + style fixes | ||||
| * | Fix for coverity issue 170752 | JackLivio | 2017-06-21 | 1 | -3/+7 |
| | | |||||
| * | Fixes for Coverity Issues: 170755, 170756, 170757, 170758, 170759 | JackLivio | 2017-06-20 | 1 | -22/+22 |
| | | | | | | | | Add mobile_apis scope to avoid ambigous naming. | ||||
| * | Fix for 170761 | JackLivio | 2017-06-20 | 1 | -1/+0 |
| | | | | | | | | Removed is_ready_ since it is never used by the telemetry monitor | ||||
| * | Fix for coverity issue 170762 | JackLivio | 2017-06-20 | 1 | -3/+4 |
| | | | | | | | | Add retry_index_ to Launcher initializer list. | ||||
| * | Fix coverity 171124 | JackLivio | 2017-06-19 | 1 | -1/+1 |
| | | | | | | | | Fix copy paste error | ||||
| * | Fix for 171126 | JackLivio | 2017-06-19 | 1 | -3/+0 |
| | | | | | | | | out_ap_permissions_changed is always a valid pointer and it is set to false prior to the SetUserPemissionsForApp function call. | ||||
| * | Fix for coverity issues 171128, 171127, 171125 | JackLivio | 2017-06-19 | 1 | -3/+3 |
| | | | | | | | | Removed const iterator since the permissions it is compared to is not a const object. | ||||
| * | Fix Coverity Issue 171129 | JackLivio | 2017-06-19 | 1 | -1/+1 |
| | | | | | | | | Current is an unsigned int so it can never be less than 0. I removed the condition that looks for current < 0 | ||||
* | | Merge pull request #1637 from smartdevicelink/coverity_fixes | Jacob Keeler | 2017-06-22 | 24 | -50/+152 |
|\ \ | |/ |/| | Coverity fixes | ||||
| * | Merge branch 'develop' | jacobkeeler | 2017-06-21 | 1355 | -106829/+165347 |
| |\ | |||||
| * | | Fix style issues | Jacob Keeler | 2016-09-21 | 14 | -36/+41 |
| | | | |||||
| * | | Merge branch 'master' | Jacob Keeler | 2016-09-20 | 1985 | -69360/+133242 |
| |\ \ | |||||
| * \ \ | Merge pull request #732 from smartdevicelink/hotfix/coverity_fix_mixed_enums | Jacob Keeler | 2016-08-03 | 4 | -22/+16 |
| |\ \ \ | | | | | | | | | | | Coverity fix unnecessary mixing of enums (CID 80023, 80024, 80026, 80028, 80030) | ||||
| | * | | | Fixed another Coverity issue involving mixed enums (CID 80028)hotfix/coverity_fix_mixed_enums | Jacob Keeler | 2016-07-29 | 2 | -7/+6 |
| | | | | | |||||
| | * | | | Fixed unnecessary mixing of enums (CID 80023, 80024, 80026, 80030) | Jacob Keeler | 2016-07-29 | 3 | -19/+14 |
| | | | | | |||||
| * | | | | Check return value of SQL exec (CID 79986) | Brad Pankow | 2016-07-28 | 1 | -1/+3 |
| | | | | | |||||
| * | | | | Check return of command init before running it (CID 79987) | Brad Pankow | 2016-07-28 | 1 | -3/+4 |
| | | | | | |||||
| * | | | | Check return values for profile file functions (CID 79994) | Brad Pankow | 2016-07-28 | 1 | -2/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit addresses the Coverity defect indicating that the remove() library function was unchecked. The first remove should no be there since rename will replace and remove the file already. If rename does not work, that file should also not be destroyed. The second remove has its return value checked and logged if an error exists. | ||||
| * | | | | Check return values for file functions (CIDs 79980, 79981, 79982, 79983, 79984) | Brad Pankow | 2016-07-28 | 1 | -7/+21 |
| | | | | | |||||
| * | | | | Check return values for tcp socket functions (CIDs 79989, 79990, 79991) | Brad Pankow | 2016-07-28 | 1 | -10/+30 |
| |/ / / | |||||
| * | | | Merge pull request #727 from BTPankow/hotfix/coverity_resource_leaks | Justin Dickow | 2016-07-27 | 1 | -9/+6 |
| |\ \ \ | | | | | | | | | | | Change socket close logic to prevent double close (CID 137866) | ||||
| | * | | | Change socket close logic to prevent double close (CID 137866) | Brad Pankow | 2016-07-27 | 1 | -9/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This simplifies the logic used to connect to bluetooth sockets. It prevents the rfcomm_socket from being closed twice or being left unclosed. | ||||
| * | | | | Merge pull request #714 from BTPankow/hotfix/coverity_resource_leaks | JackLivio | 2016-07-26 | 2 | -0/+4 |
| |\ \ \ \ | | |/ / / | | | | | | Fix Coverity resource leaks (CIDs 80039, 80040) | ||||
| | * | | | Close socket connection before returning from function (CID 80039) | Brad Pankow | 2016-07-21 | 1 | -0/+1 |
| | | | | | |||||
| | * | | | Free opened file before returning from function (CID 80040) | Brad Pankow | 2016-07-21 | 1 | -0/+3 |
| | | | | | |||||
| * | | | | Merge pull request #715 from BTPankow/hotfix/coverity_buffer_termination | JackLivio | 2016-07-26 | 1 | -1/+3 |
| |\ \ \ \ | | | | | | | | | | | | | Null terminate char buffer after strncpy (CID 79979) | ||||
| | * | | | | Null terminate char buffer after strncpy (CID 79979) | Brad Pankow | 2016-07-21 | 1 | -1/+3 |
| | |/ / / | |||||
| * | | | | Merge pull request #723 from BTPankow/hotfix/coverity_uninitialized | JackLivio | 2016-07-26 | 19 | -18/+72 |
| |\ \ \ \ | | | | | | | | | | | | | Fix uninitialized pointer and scalar fields (Coverity) | ||||
| | * | | | | Initialize binary_data_ to NULL (CID 80088) | Brad Pankow | 2016-07-26 | 1 | -1/+2 |
| | | | | | | |||||
| | * | | | | Initialize thread delegate to NULL before use (CID 80087) | Brad Pankow | 2016-07-26 | 1 | -0/+1 |
| | | | | | | |||||
| | * | | | | Initialize policy_table_type_ to INVALID_PT_TYPE for Optional template class ↵ | Brad Pankow | 2016-07-26 | 2 | -3/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | (CID 80046, 80047, 80048) | ||||
| | * | | | | Initialize protocol_version to V2 (CID 80051) | Brad Pankow | 2016-07-26 | 1 | -1/+3 |
| | | | | | | |||||
| | * | | | | Initialize Profile members to defaults (CID 80053) | Brad Pankow | 2016-07-26 | 1 | -0/+6 |
| | | | | | | |||||
| | * | | | | Initialize state_ctrl_ to constructor parameter (CID 80054) | Brad Pankow | 2016-07-26 | 1 | -1/+1 |
| | | | | | | |||||
| | * | | | | Initialize RequestInfo members, add new RequestType (CID 80058, 80066, 80067) | Brad Pankow | 2016-07-26 | 2 | -5/+17 |
| | | | | | | |||||
| | * | | | | Initialize is_ready_ before use in functions (CID 80072) | Brad Pankow | 2016-07-26 | 1 | -0/+1 |
| | | | | | | |||||
| | * | | | | Initialize is_persistent, is_download_complete, and file_type before use in ↵ | Brad Pankow | 2016-07-26 | 1 | -1/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | functions (CID 80073) | ||||
| | * | | | | Initialize max_block_size_ before use in functions (CID 80074) | Brad Pankow | 2016-07-26 | 1 | -1/+2 |
| | | | | | | |||||
| | * | | | | Initialize app_state_ and connection_id_ before use in functions (CID 80075) | Brad Pankow | 2016-07-26 | 1 | -1/+2 |
| | | | | | | |||||
| | * | | | | Initialize choice_set_id_ and is_timed_out_ before use in functions (CID 80076) | Brad Pankow | 2016-07-26 | 1 | -1/+3 |
| | | | | | |