| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
* Removed dependence on allowed when updating accessMode
* Update src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/hmi/rc_on_remote_control_settings_notification.cc
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
Co-authored-by: Roman Reznichenko <roman.reznichenko@dxc.com>
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix wrong requests order for recursive deletion
The issue which was observed is that SDL sends `DeleteSubMenu`
request to HMI for a "parent node" submenu and then sends
subsequent `DeleteSubMenu` requests recursively for all child
nodes starting from the bottom one. Such order confuses HMI
because deletion of parent node may automatically trigger
deletion of all its child nodes on HMI side so subsequent
requests from SDL for a child nodes might be rejected.
To make sure that HMI removes all the hierarchy properly,
SDL should start deletion sequence from the bottom nodes
and delete the parent node in the end.
To resolve that issue, DeleteSubMenu request logic was
updated. Currently, SDL recursively iterates through the
submenu and command nodes and collects them in a queue.
Once queue is ready, SDL sends requests one by one, waiting
for a HMI response for each sent request before sending the
subsequent. Once the responses to all requests are received,
SDL sends the final response to mobile app and finalizes the
command.
* Updated DeleteSubMenu unit tests to cover new logic
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added result processing and wrote a test for RC_SetGlobalProperties
* Apply suggestions from code review
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* Added result processing and wrote a test for RC_SetGlobalProperties
Co-authored-by: Roman Reznichenko <roman.reznichenko@dxc.com>
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Temporary commit with link to rpc_spec fork
* Indicate that the structure is included in the Common interface
* Mark the parameters as non mandatory
* Update link to rpc_spec fork
* Fix Message Helper linkage to VehicleInfoPlugin
* Fix versioning for TirePressure param
* Bump version up to 8.0
* Add link to rpc_spec fork
* Address review comments
Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
Co-authored-by: Yana Chernysheva <ychernysheva@luxoft.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
|
|
|
| |
systemCapabilities.displayCapabilities (#3746)
|
|
|
| |
* Suspend any notifications meant for mobile app until HMI state is properly established
|
|
|
|
|
|
|
| |
* Added methods get and set the menuLayout and added to the request on the HMI this field
* fixup! Added methods get and set the menuLayout and added to the request on the HMI this field
Co-authored-by: Roman Reznichenko <roman.reznichenko@dxc.com>
|
|
|
| |
Co-authored-by: Roman Reznichenko <roman.reznichenko@dxc.com>
|
|
|
| |
* Established the new policy for CMP0054 and added if and else for different Policy values
|
|
|
|
|
|
|
| |
* Remove deprecated methods
* Style
* Fix external policy build
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove references to ubuntu 16 in documentation
* Remove older ssl ciphers from crypto manager
* Fix style
* Change logs for unsupported protocols
* Update clang-format version to 8 and re-run style script
* Apply suggestions from code review
Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Drop support for openssl 1.0
* Remove some references to OPENSSL_1_1_VERSION
Co-authored-by: Collin <iCollin@users.noreply.github.com>
|
| |
|
|
|
|
| |
modes (#3723)
|
|
|
|
|
|
|
| |
* Add additional test cases
* Add additional test cases and fix style
* Address review comments
|
| |
|
|
|
|
|
|
|
| |
* remove references to ENABLE_HMI_PTU_DECRYPTION and USE_HMI_PTU_DECRYPTION
* merge policy manager parse and parsearray methods
* remove references from CMakeLists.txt
|
|
|
|
|
| |
* Fix invalid read in `send_response` callback
* Add check in FinalizeResumption that app is still registered
|
|
|
|
|
| |
* Fix boost logger on release build
* Exclude boost logger file when logs disabled
|
|
|
|
|
|
|
|
|
| |
* check for invalid enum result code in CommandRequestImpl::SendResponse
* Update src/components/application_manager/src/commands/command_request_impl.cc
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
|
|
|
| |
Co-authored-by: JackLivio <jack@livio.io>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Test github action
* Build Core
* Fix path
* Add submodules
* Move path
* Debug policy cmake paths
* Debug lines
* Change build directory
* Print sources
* Change core path
* ls debug
* Log cmake version
* Try ubuntu 18
* Set Cmake version
* Change cmake depdency
* Remove version wildcard
* Debug collect sources
* More debug messages
* Check filtered files
* Remove bad policy path exclude
* Try caching 3rd party
* Fix env var
* Update 3rd party path
* Fix path
* Remove env var
* Fix space
* Update path
* Update core path
* Fix boost install path
* Add 3rd party arch path
* Set LD_LIBRARY_PATH
* Add check style
* Fix cache path
* Update README badge status
* Move 3rd party build path
* Remove Travis
* Move cache call earlier
* Fix syntax
* Conditional mkdir
* Add debug line
* Add logs
* Fix syntax
* Fix syntax
* Remove log lines
* Use boost logger
* Update cache
* Remove -j
* Top level boost include
* Adjust boost includes
* Remove boost logger
* Invalidate cache
* Update CMakeLists.txt
* Update CMakeLists.txt
* Update CMakeLists.txt
* Update CMakeLists.txt
* Update sdl_core_github_ci.yml
* Update CMakeLists.txt
* Update CMakeLists.txt
* Update CMakeLists.txt
* Add pull request action
|
|
|
|
| |
the API without leaking memory (#3703)
|
|
|
| |
`EndpointProperty.version` is defined as an optional value, but was being used as a mandatory one. Also makes `service` property unique in `endpoint_properties` to prevent duplicate entries
|
|
|
|
|
| |
* when non-existant app sends request reply app not registered
* fix unit tests
|
|
|
| |
sliderPosition was set to 0 (an invalid value) in the mobile response if an ABORTED result was received from the HMI without this parameter.
|
|
|
|
|
|
|
| |
* only call Json::Value::operator[] if it is object type
* short object check
* validate value[data].isArray()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixed SDL sends appName in vrSynonyms and ttsName in case of lower and upper bound values in json file
* Update src/components/application_manager/src/application_manager_impl.cc
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* Update src/components/application_manager/src/application_manager_impl.cc
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* ttsName is defined as array
Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
Co-authored-by: yurii <ypostolov>
|
|
|
|
|
|
|
| |
* Deprecated redundant code
* Remove unit tests for deprecated methods
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add mobile responce with disallowed by user params
* Answer PR comments
* Answer PR comments
* Update fix according to new hierarchy
* fixup! Update fix according to new hierarchy
* fixup! Update fix according to new hierarchy
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
Co-authored-by: Dmitriy Boltovskiy <dboltovskyi@luxoft.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix core prematurely sends success for DeleteInteractionChoiceSet.
DeleteInteractionChoiceSetRequest was contain implementation, according
to that, SDL never not waits for HMI response and sends to Mobile response (success = true, resultCode = "SUCCESS").
This PR provides changes, that remove that implementation.
Also, according to requirements, when at-least on of HMI VR_DeleteCommand
response will contains any ERROR result code, except WARNINGS,
SDL has to send response with that error code and success_result as false.
And if on of HMI VR_DeleteCommand response will contains at-least one
WARNINGS resulst_code, SDL has to send to Mobile response with WARNINGS
and success_result as true.
* Address review comments
* fixup! Address review comments
* Update src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/delete_interaction_choice_set_request.cc
Co-authored-by: Collin <iCollin@users.noreply.github.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
Co-authored-by: Collin <iCollin@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Implement 3rd-party Boost logger
* Add boost log config file
* Implement log filtering and formatting for the different sinks
* Fix Timestamp calculation
* Fix function trace string
* Implement setting to disable particular sinks
* Add append option to file sinks
* Telnet logger configuration
* Add cmake flag to switch beetween loggers
* Remove log4cxx appender include
* Style fix
* Modify BoostLogConfig file for tests to match the log4cxx properties file
* Exclude log4cxx related libraries
* Address review comments
* Add changes to only install boost log if the correct LOGGER_NAME is set
* Fix implementation for removing disabled sinks
* Add note for isEnabledFor function
* Address review comment
* Fix smartobject linking error
* Address review comments
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* parse all values from one ini file open
* wrap ini_read_value to open file for ini_file_test.cc
* update profile tests, fix handle leak
* refactor ini_parse_line
* Apply suggestions from code review
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* parse ini file in to smart object
* remove ini_file changes
* fix style
* small optimization, parse key first
* restore open/close config functions
* deprecate ini_file
* Revert "restore open/close config functions"
This reverts commit a03c69403fe14790e6b6738a65820c1ae69e95c5.
* move ini parsing to Profile::ParseConfiguration
* add DEPREACTED to ini_file
* don't print deprecated warnings from test file that is dedicated to deprecated methods
* add macros to ini_file.cc
* check style
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* fix crash in libusb callback handling
* Answer review; removing redundant logger
* Respond review comment, fixed logger.
* Removed usb_connection.cc.orig
* Update src/components/transport_manager/src/usb/libusb/usb_connection.cc
Co-authored-by: Collin <iCollin@users.noreply.github.com>
* Update src/components/transport_manager/src/usb/libusb/usb_connection.cc
Co-authored-by: Collin <iCollin@users.noreply.github.com>
Co-authored-by: yurii <ypostolov>
Co-authored-by: Collin <iCollin@users.noreply.github.com>
|
|
|
|
|
|
|
| |
* fix: store app info JSON file in AppStorageFolder
* Update test cases to store app info JSON file in AppStorageFolder
Co-authored-by: Sho Amano <samano@xevo.com>
|
|
|
|
|
|
|
| |
* fix respond on SDL.GetListOfPermission request
* Error response in case when we could not collect permissions
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* SDL sends wrong OnHMIStatus for voice app in case of a phone call.
Once SDL received OnEventChanged(Phone_Call, true) from HMI, it should send
OnHMIStatusUpdate with new HMILevel. Expected HMILevel for voice
communication application is "LIMITED", but it is "FULL".
PhoneCallHmiState should take into account voice communication app
as an additional check.
* Fix for state_controller unit tests.
Due to changes in a logic for PhoneCallHmiState,
unit tests have to be updated as well.
ApplicationType enum is removed since it is not actual anymore.
As a result, PrepareHMIStateResults functions are modified according to
new application types and updated expected HMI states.
Tests for NaviStreaming HMI state are enabled.
NaviStreamingHmiState is used for these tests instead of VideoStreamingHmiState.
New tests for different application types are added.
* fix styling issues for state_controller_test
* Fix hmi state merge conflicts
* Revert test code
* Fix unit test
* Style
Co-authored-by: JackLivio <jack@livio.io>
|
|
|
|
|
|
|
| |
* replace applicable X++ with ++X
* replace applicable X-- with --X
* change for loop updates
|
|
|
|
|
|
|
| |
* SDL respond UNSUPPORTED_RESOURCE on SystemRequest (QUERY_APPS) if SDL is below version 4.0
* answer review comments
Co-authored-by: Collin <iCollin@users.noreply.github.com>
|
|
|
|
|
|
|
| |
* Update travis distro to 20.04
* Add cppcheck exclusions for false positives
* Fix cppcheck issues
|
|
|
| |
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
|
|
|
|
|
| |
kDefaultHeartBeatTimeout = 5000ms
Co-authored-by: Anna Pipko (GitHub) <APipko@luxoft.com>
|
|
|
|
|
|
|
|
|
|
|
| |
* Reduce some logs to TRACE level
Each time SDL Core receives a video packet from mobile, it
generates a large amount of logs. Instead of completely removing
them, this commit decreases their levels to TRACE.
Head unit systems with video streaming feature can set log
output level to DEBUG (or higher) to get rid of the logs.
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
|
|
|
|
|
| |
* Check waypoint subscription size in resumption
* Update modifiers
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add status check for bt scan
* Create separate thread to handle the paired device and hci inquiries
* Style fix
* Initialize inquiry thread in constructor and add thread start check
* Remove scan for unpaired devices
* Remove inquiry thread
* Add timeout, remove found_devices_with_sdl_, fix conflicts
* Prevent automatic cloud connections
* Fix bluetooth thread issues
* Fix style
* Remove new lines
* Fix threading issues
* Prevent deadlock on shutdown
* Rename CV Lock
* Style
Co-authored-by: JackLivio <jack@livio.io>
|
|
|
|
|
| |
* Configure security level in ini file
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with invalid data (#3647)
* Fix NACK sending for Start RPC service with invalid data in bson payload.
Fix memory leak with session after Start RPC service NACK.
Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode.
Fix NACK sending for Start any service with non-existent session id.
* fixup! Fix NACK sending for Start RPC service with invalid data in bson payload. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id.
* fixup! fixup! Fix NACK sending for Start RPC service with invalid data in bson payload. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id.
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
|
| |
|