summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* fixup! initialize app in non custom button path of on_button_press runfix/btn_press_limitedcollin2020-05-191-0/+1
| | | | fix unit tests with changes in run
* initialize app in non custom button path of on_button_press runcollin2020-05-191-3/+4
|
* Add RPCService unit tests (#3250)Yana Chernysheva (GitHub)2020-05-184-0/+900
| | | | | | | | | | | * Add RPCService unit tests * Add prerequisites for execution of unit tests * Rearrange and delete unused includes * Add minor changes Co-authored-by: JackLivio <jack@livio.io>
* Change reason to IGNITION_OFF only if reason wasn't defined before (#3274)Yana Chernysheva (GitHub)2020-05-181-2/+6
|
* Fix/issue 1951 (#3371)Collin2020-05-184-19/+56
| | | | | | | | | | | | | | | * remove deadlock danger when removing Connections from a ConnectionMap * fix style, use log debug instead of trace for singular messages * Revert "fix style, use log debug instead of trace for singular messages" This reverts commit c83288ec9fc9007e48044b09ad038edbf612e038. * fix style, use log debug instead of trace for singular messages * restore condition updates lost with merge of old versions Co-authored-by: Frank <fronneburg@xevo.com>
* Fix/Add Startup PTU trigger check (#3363)Shobhit Adlakha2020-05-189-0/+43
| | | | | | | * Add Startup PTU check * Reset Stop PTU etry when first app is registered * Address review comment
* Merge pull request #2553 from smartdevicelink/fix/start_stream_retry_countJacob Keeler2020-05-182-8/+8
|\ | | | | Fix Start Stream retry count
| * Fix Start Stream retry countfix/start_stream_retry_countjacobkeeler2018-08-292-8/+8
| |
* | ResetGlobalProperties doesn't reset HELPPROMPT and VRHELPITEMS to default ↵Collin2020-05-185-8/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | values (#3357) * Fix bug `ResetGlobalProperties` (#2337) Fix bug `ResetGlobalProperties` does't reset `HELPPROMPT` and `VRHELPITEMS` to default values Fix UT's after bugfixing - Fix `ResetGlobalPropertiesRequestTest` - Add mock function into `MockApplicationManagerSettings` Github issue #1306 Co-authored-by: v-malko4 <vmalkov@luxoft.com> * fix vr_help_title SO type, rename help_prompt_ in unit tests to so_help_prompt * fix style Co-authored-by: v-malko4 <vmalkov@luxoft.com>
* | only return if we are sure we are out of space (#3361)Collin2020-05-131-5/+0
| |
* | Revert "RAI reply DUPLICATE_NAME when app has same id and name as existing app"collin2020-05-133-69/+8
| | | | | | | | This reverts commit 236bdbaa283147044a6144f8c96cc43b82ff1014.
* | RAI reply DUPLICATE_NAME when app has same id and name as existing appcollin2020-05-133-8/+69
| |
* | Fix Compile Warnings (#3356)Collin2020-05-112-2/+5
| | | | | | | | | | | | | | * fix warning:maybe-uninitialized in CStringToEnum * fix out of buffer write warning in unit tests * Apply suggestions from code review
* | [SDL4.0]SDL does not create icons folder in case it was removed (#2649) (#3359)Collin2020-05-111-0/+8
| | | | | | | | | | | | | | | | The check for existence directory of app icons folder has been added to SetAppIconRequest. Co-authored-by: ValeriiMalkov <vmalkov@luxoft.com> Co-authored-by: ValeriiMalkov <vmalkov@luxoft.com>
* | Add missing ssl_context.h include in security_manager_listener (#2775)Stanislav Kobziev (GitHub)2020-05-111-0/+1
| |
* | Fixing problem with validation of array (#2669)Oleksandr Nyzhnyk (GitHub)2020-05-083-17/+47
| | | | | | * Fixing problem with validation of array
* | SDL crash during cleanup. (#2621)Mykola Korniichuk (GitHub)2020-05-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | * SDL crash during StopComponents() if StartComponents() failed. If resumption_storage_ in ResumeCtrlImpl is failed to initialize, SDL will try to stop components and exit with error code. At this time application manager tries to unregister all applications and call ResumeCtrlImpl::OnIgnitionOff() where resumption_storage_ is used. As a result, a crash will occur. As an example, if AppStorageFolder have no read/write access, resumption_storage_ fails to initialize. Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Update HMI_API.xml (#3354)Collin2020-05-071-1/+1
| | | | | | | | | | | | | | | | | | * Update HMI_API.xml * Update src/components/interfaces/HMI_API.xml Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Init usage_and_error_counts on startup (#3349)release/6.1.1JackLivio2020-04-301-0/+4
| |
* | do not retry ptu if no apps are connected (#3350)Collin2020-04-301-0/+4
| | | | | | | | | | * do not retry ptu if no apps are connected * no URL should be returned if there is no app to do PTU
* | Add permission checking for all messages to and from mobile (#3344)6.1.0_RC2Jacob Keeler2020-04-2712-107/+152
| | | | | | * Add permission checking for all messages to and from mobile
* | Fix capability window update when window_id is missing (#3342)JackLivio2020-04-221-9/+16
| | | | | | | | | | | | | | | | | | | | | | * Fix capability window update when window_id is missing * Refactor comments * Update src/components/application_manager/src/application_data_impl.cc Co-Authored-By: Collin <iCollin@users.noreply.github.com> Co-authored-by: Collin <iCollin@users.noreply.github.com>
* | Fix result code generic error while subscribing to vehicle data (#3264)Yana Chernysheva (GitHub)2020-04-222-12/+31
| | | | | | | | | | | | | | | | | | * Fix iteration on set with possible erase * Add and process set with skiped result codes * fixup! Add and process set with skiped result codes * fixup! Add and process set with skiped result codes
* | Merge pull request #3341 from smartdevicelink/fix/external_policy_buildJacob Keeler2020-04-216-87/+75
|\ \ | | | | | | Move cached app logic to ChoosePTUApplication
| * | Move cached app logic to ChoosePTUApplicationfix/external_policy_buildjacobkeeler2020-04-216-87/+75
| | | | | | | | | | | | Also add macro guards for uses of last_ptu_app_id_
* | | Fix UpdateAppList/UpdateDeviceList spam (#3339)Andrii Kalinich (GitHub)2020-04-214-10/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix UpdateAppList/UpdateDeviceList spam There was noticed a continuous spam of update app and device list requests from SDL to HMI even if thre is no any devices connected and apps registered. After analysis, there was found a couple of places where logic should be updated: - In OnHMIStartedCooperation don't send update app list after refreshing cloud app information as this function able to trigger the same request itself when needed - When update app list timer is expired, don't send update app list if no any apps were registered or unregistered while timer was running - In transport manager, don't raise OnDeviceListUpdated event if no any devices were added/removed - When WebEngine device is created, it makes sense to connect it automatically and set its status to CONNECTED as its internal communication between SDL and HMI - In transport adapter, don't notify listeners via OnConnectionStatusUpdated() callbacks if device connection status was not actually changed All these actions together prevents all possible reasons of UpdateAppList/UpdateDeviceList spam observed before fix. * fixup! Fix UpdateAppList/UpdateDeviceList spam * fixup! fixup! Fix UpdateAppList/UpdateDeviceList spam * fixup! fixup! fixup! Fix UpdateAppList/UpdateDeviceList spam
* | | StartEndStreamTimer in StopNaviService (#3325)Collin2020-04-211-1/+1
|/ /
* | Fix PROPRIETARY and HTTP retry sequences (#3329)Jacob Keeler2020-04-2012-178/+253
| | | | | | | | | | | | | | | | | | | | | | | | * Fix PROPRIETARY and HTTP retry sequences For PROPRIETARY policy updates, Core is responsible for the retry sequence and cycling through update URLs. This fixes the PROPRIETARY flow with a few specific changes: 1. Apps for PTU are chosen randomly using the existing process, but after an application is chosen, all URLs that are associated with that application will be attempted before moving onto the next application. 2. When an OnSystemRequest(PROPRIETARY) is received from the HMI, Core will ignore the `appID` and `url` properties and populate them itself. This is because Core is responsible for providing these fields in PROPRIETARY mode. * Add caching for PTU URLs if provided by HMI * Fix bug in HTTP mode
* | Do not send two END_SERVICE requests during streaming switching between apps ↵Ira Lytvynenko (GitHub)2020-04-202-31/+58
| | | | | | | | | | | | | | | | | | | | | | (#3334) * Protect navi_app_to_stop_ * Prevent EndService double sending Remove app_id from navi_service_status_ before unregistering the app in case EndServiceAck did not come for at least one of the services, in order to avoid sending the EndService again during unregistration
* | Hotfix/3327 sdl sends generic error if vehicle data not available (#3335)Yaroslav Mamykin (GitHub)2020-04-172-43/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix response message structure of GetVehicleData request In case of GetVehicleData error response from HMI, SDL put only part of message to event. This way event was not processed properly and GENERIC_ERROR was sent to HMI. This commit fixes error response message structure. * Update existing unit tests * fixup! Update existing unit tests Co-authored-by: YarikMamykin <ymamykin@gmail.com>
* | Fix/Deadlock during transport re-connect via USB (#3332)Serhii Niukalov (GitHub)2020-04-172-49/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rework the use of AbortConnection for a usb connection Sometimes we get a deadlock because we use the same lock in the same thread. The situation is possible when calling the SendData, OnOutTransfer or AbortConnection functions. They block the mutex at the start. If in the PostOutTransfer function, which is called in SendData or indirectly in OnOutTransfer via PopOutMessage, we get the error LIBUSB_ERROR_NO_DEVICE, this will call AbortConnection. Which will cause a deadlock. * fixup! Rework the use of AbortConnection for a usb connection Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | Fix/Send OnAppPropertiesChange in case one of nicknames is removed (#3336)Serhii Niukalov (GitHub)2020-04-162-5/+29
| | | | | | | | | | | | | | * Update compare for the nicknames * UTs update Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | fix APTDisplayText covert bug (#3291)Jim-Nexty2020-04-071-4/+6
| | | | | | Co-authored-by: xiatian <xiatian@iauto.com>
* | Fix SDL doesn't send EndService for Video/Audio Service upon IGNITION_OFF ↵Yurii Postolov2020-04-061-0/+2
| | | | | | | | | | #1409 (#2425) * Fix SDL doesn't send EndService for Video/Audio Service upon IGNITION_OFF
* | Fix remove_if in ClearTimerPool (#3322)JackLivio2020-04-031-6/+11
| |
* | Fix for video stream failed by switched of connection via BT+WIFI (#3290)Jim-Nexty2020-04-032-5/+35
| | | | | | | | Co-authored-by: jiazhouyang <jiazhouyang@iauto.com> Co-authored-by: JackLivio <jack@livio.io>
* | Remove redundant GetSystemInfo sending (#3305)Ira Lytvynenko (GitHub)2020-04-0321-128/+0
| |
* | Update path to smartDeviceLink.ini (#3310)Serhii Niukalov (GitHub)2020-04-021-1/+2
| | | | | | Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | Fix/Create generic handler in sample policy manager for different system ↵6.1.0_RCShobhit Adlakha2020-03-301-26/+84
| | | | | | | | | | | | | | request types (#3315) * Create a generic handler to handle different system request types * Change function name from crypt to encrypt
* | Update KMS count last update took place at (#3311)JackLivio2020-03-271-0/+1
| |
* | Fix/Cloud and Web-engine apps disappear after refreshing the page (#3308)Shobhit Adlakha2020-03-261-0/+1
| | | | | | | | | | * Send updateapplist when hmi cooperation starts * Remove extraneous logs
* | maintain signature for GetLockScreenIconUrl (#3303)Collin2020-03-232-2/+2
| |
* | Update start_external_proprietary.sh (#3299)Collin2020-03-231-3/+5
| | | | | | | | | | | | | | | | | | * Update start_external_proprietary.sh * Update src/appMain/start_external_proprietary.sh Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* | Fix sdl crash when policies disabled (#3292)Yaroslav Mamykin (GitHub)2020-03-232-50/+267
| | | | | | | | | | | | | | * Fix usage non-valid policy_manager pointer in case of EnablePolicy=false * Add unit tests for modified methods Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Fix/Checking PTU triggers when no apps are registered in regular policy mode ↵Shobhit Adlakha2020-03-191-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#3294) * Trigger PTExchange when Device consent is enabled * Move StartPTExchange call to BC.OnReady * StartPTExchange is a protected function. Add TriggerPTUIfNeeded to the policy_manager as well * Fixed GetPolicyHandler call in BC.OnReady * Add mock definitions * Fix failed ut * Handle PolicyUpdate error response * Add reset retry sequence * Revert "Move StartPTExchange call to BC.OnReady" This reverts commit 7c53978b2e7a42ed51cb856d054dce88e040e8ea. Co-authored-by: JackLivio <jack@livio.io>
* | Fix/consider timeouts during streaming switching (#3293)Serhii Niukalov (GitHub)2020-03-196-9/+79
| | | | | | | | | | * Consider video and audio status before send end of service Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | Fix OnSystemRequest(LOCK_SCREEN_ICON_URL) sending (#3271) (#3289)Collin2020-03-1632-228/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was noticed an issue that sometimes Policy Manager component is returning an empty url for lock screen icon. The root cause of that is the data races between thread which is sending OnSystemRequest notification and backupper thread which overwrites data in the database. As these two threads may have an intersection, there could be a possible situation that backuper thread erased data from `endpoints` table and another thread is using SQL query to select the data from the same table. As a result, second thread receives an empty result as the data was erased and the new one was not inserted yet by backupper thread. After that, SDL just does not send OnSystemRequest as the URL is empty. To fix that issue, policy component has been updated to use internal policy cache instead of direct access to policy database each time to get URL. This will guarantee that a sending thread will get an up-to-date infromation required for OnSystemRequest notification. Also, code cleanup has been done in order to remove all functions which become unused after this fix. Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
* | fix/Move AppProperties struct to the Common interface (#3286)Shobhit Adlakha2020-03-121-61/+35
| | | | | | | | | | | | | | | | | | * Move AppProperties struct to the Common interface * Remove unnecessary response params from SetAppProperties and GetAppProperties response * Add missing description tag * Fix description tag in last commit
* | Fix/Perform hash check before copying over mobile api files (#3288)Shobhit Adlakha2020-03-121-2/+6
| | | | | | | | | | | | | | * Compare MOBILE_API files in the submodule directory against the ones in the interfaces directory before copying * Use cmake copy_if_different command instead of cmp * Remove trailing whitespace
* | Fix/SDL does not send BC.PolicyUpdate to HMI if no apps are registered (#3280)Shobhit Adlakha2020-03-117-2/+34
| | | | | | | | | | | | | | | | | | * Temporary fix for allowing core to send the policyupdate rpc * Remove CanUpdate call in PolicyManagerImpl::StartPTExchange and restore CanUpdate behavior * Fix regular policy unit tests * Fix extern policy unit tests
View Lorry Controller Status