summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused iteratorfix/unused_iteratorJacob Keeler2018-02-011-1/+1
|
* Fix RC unit testfix/rc_unit_test_failureJacob Keeler2018-01-291-1/+0
|
* Move MaxSupportedProtocolVersion to correct sectionhotfix/move_ini_protocol_versionJacob Keeler2017-11-081-2/+2
| | | It was in the `Main` section, but belongs in (and is read from) the `ProtocolHandler` section of the INI file
* Activate app sent at wrong time for RC appshotfix/rc_sends_activate_app_at_wrong_timeJackLivio2017-11-031-1/+0
| | | | This function call will cause BC.ActivateApp to be sent to the hmi when a RC app is connected for the first time.
* Update HMI API interface versionsfeature/update_hmi_api_versionjacobkeeler2017-10-201-6/+6
|
* RC capabilities is set in RC.GetCapabilities, not UI.GetCapabilitiesfix/rc_capabilitiesjacobkeeler2017-10-127-123/+92
| | | Also make sure to set rc_supported based on the result of this RPC
* Reject invalid enum values in video paramsfix/validate_video_params_enumsjacobkeeler2017-10-061-14/+20
| | | Fixes issues where invalid enum values are ignored but still reciprocated in the StartSessionACK
* Update sdl_preloaded_pt.jsonJackLivio2017-10-041-1/+1
|
* Remove Remote Control Policies From DefaultJackLivio2017-10-041-5/+1
|
* Merge pull request #1804 from smartdevicelink/developJackLivio2017-10-042-5/+8
|\ | | | | Merge Develop Fixes
| * fix: media_managet_test fails if EXTENDED_MEDIA_MODE is enabledSho Amano2017-10-041-0/+2
| |
| * Merge pull request #1691 from ↵JackLivio2017-10-031-5/+6
| |\ | | | | | | | | | | | | shoamano83/fix/memory_issue_in_from_mic_to_file_recorder fix: memory issue in FromMicToFileRecorderThread
| | * fix: memory issue in FromMicToFileRecorderThreadSho Amano2017-07-191-5/+6
| | | | | | | | | | | | | | | | | | Strings were not copied properly, instead pointers to buffers were copied. One of the buffer was released immediately, causing memory access through a dangling pointer.
* | | Merge pull request #1690 from ↵Jacob Keeler2017-10-032-10/+27
|\ \ \ | | | | | | | | | | | | | | | | shoamano83/fix/memory_leak_in_from_mic_to_file_recorder fix: memory leak in FromMicToFileRecorderThread
| * | | fix coding style using check_style.shSho Amano2017-08-031-1/+1
| | | |
| * | | fix: memory leak in FromMicToFileRecorderThreadSho Amano2017-07-192-10/+27
| | |/ | |/|
* | | fix: invalid memory access in websocket_handler (#1687)Sho Amano2017-10-031-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * fix: invalid memory access in websocket_handler * Revert "fix: invalid memory access in websocket_handler" This reverts commit 120c087d92fac3e3c950f1e689461aafd2fa459c. * fix: (again) invalid memory access in websocket_handler Previous commit was incomplete; we need to shift the whole buffer.
* | | Fix/1701 (#1702)fronneburg2017-10-036-1/+20
| | | | | | | | | | | | proper socket streamer cleanup
* | | Merge pull request #1779 from ↵Jacob Keeler2017-10-038-72/+136
|\ \ \ | | | | | | | | | | | | | | | | AKalinich-Luxoft/hotfix/fix_default_app_policies_update_after_ptu Fix PTU applying for "default" app policies
| * | | Fix unit test expectationAKalinich-Luxoft2017-09-271-1/+1
| | | |
| * | | Fix PTU applying for default app policy sectionAKalinich-Luxoft2017-09-277-71/+135
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a problem with applying changes for applications which is registered with "default" policies and this policy group was updated after PTU. In this case permissions for already registered applications which is using these groups still have permissions as before update. Also default policy section was not updated after PTU with changes in this section. This issue is reproduced on EXTERNAL_PROPRIETARY flow only. To fix this issue there was removed code in CacheManager, which incorrectly assigns default policies to apps with "default" policies. Also there was a redundant code because default policies is unwrapped in PTU before its applying, so all specific application policies is already have actual new default policy permissions. In this case it is correct to assign to every app his own policies from PTU. Also there was updated logic in ProcessAppPolicyCheckResults() to perform all needed actions once per app, because its possible that results could contain sever results for one app_id.
* | | | Remove ifdefJackLivio2017-09-291-4/+1
| | | | | | | | | | | | | | | | clearner approach to handling warning as error.
* | | | Fix compilation warning #1789JackLivio2017-09-294-9/+12
| | | | | | | | | | | | | | | | Changes made in #1789 + compilation fix. Original author @shoamano83
* | | | Revert "fix: build break with ENABLE_LOG=OFF"revert-1789-fix/build_break_without_logJackLivio2017-09-283-10/+9
| | | |
* | | | Merge pull request #1789 from shoamano83/fix/build_break_without_logJackLivio2017-09-283-9/+10
|\ \ \ \ | | | | | | | | | | fix: build break with ENABLE_LOG=OFF
| * | | | Remove temporary value app_idSho Amano2017-09-281-7/+5
| | | | | | | | | | | | | | | | | | | | Reflecting review comment.
| * | | | fix: build break with ENABLE_LOG=OFFSho Amano2017-09-283-4/+7
| | |_|/ | |/| |
* | | | Merge pull request #1786 from smartdevicelink/fix/remote_control_supportedJacob Keeler2017-09-2811-0/+172
|\ \ \ \ | | | | | | | | | | Add `remoteControl` to HMICapability struct in Mobile API
| * | | | Add `remoteControl` to HMICapability struct in Mobile APIfix/remote_control_supportedJacob Keeler2017-09-2611-0/+172
| | | | |
* | | | | Merge pull request #1793 from smartdevicelink/pr/1674JackLivio2017-09-281-17/+11
|\ \ \ \ \ | | | | | | | | | | | | Pr/1674
| * | | | | Style & remove unused codeJackLivio2017-09-281-14/+2
| | | | | |
| * | | | | Remove lock release. Change already existsJackLivio2017-09-281-1/+0
| | | | | | | | | | | | | | | | | | That change was added by #1517
| * | | | | fixing mistake in previous check-inMadhu Yaduguri2017-07-201-0/+1
| | | | | |
| * | | | | Fix PR issues.David Switzer2017-07-201-1/+0
| | | | | |
| * | | | | Fix for sending wrong app handle to RemoveFinalizedConnection() due to erase ↵David Switzer2017-07-201-6/+13
| | |_|_|/ | |/| | | | | | | | | | | | | in map iterator loop.
* | | | | Merge pull request #1769 from shoamano83/fix/deprecate_service_data_ackJacob Keeler2017-09-282-21/+78
|\ \ \ \ \ | | | | | | | | | | | | fix: send Service Data ACK frames only for version 2-4
| * | | | | fix: send Service Data ACK frames only for version 2-4Sho Amano2017-09-222-21/+78
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The protocol spec document https://github.com/smartdevicelink/protocol_spec says that the frame is deprecated. Looking at its commit history the frame has been marked as deprecated before introducing protocol version 5. Also, looking at the comment in protocol_handler_impl.cc the frame wasn't meant to send out in protocol version 1. Therefore this fix will limit the use of Service Data ACK for protocol version 2 through 4.
* | | | | Merge pull request #1791 from BrandonHe/hotfix/connection_list_lock_releaseJackLivio2017-09-281-0/+2
|\ \ \ \ \ | |_|_|/ / |/| | | | hotfix connection list lock is not released
| * | | | hotfix connection list lock is not releasedBrandonHe2017-04-281-0/+2
| | | | |
* | | | | Merge pull request #1775 from smartdevicelink/fix/update_mobile_api_4.4.0Jacob Keeler2017-09-262-6150/+6049
|\ \ \ \ \ | | | | | | | | | | | | Update MOBILE_API.xml to match `rpc_spec` repo
| * | | | | Update MOBILE_API.xml to match `rpc_spec` repofix/update_mobile_api_4.4.0jacobkeeler2017-09-222-6150/+6049
| | | | | | | | | | | | | | | | | | Includes fixes to build issues resulting from this update.
* | | | | | Merge pull request #1784 from smartdevicelink/fix/video_capabilities_validationJacob Keeler2017-09-261-3/+28
|\ \ \ \ \ \ | | | | | | | | | | | | | | Validate outgoing video params
| * | | | | | Validate outgoing video paramsfix/video_capabilities_validationjacobkeeler2017-09-251-3/+28
| | | | | | | | | | | | | | | | | | | | | Reverts this section back to https://github.com/shoamano83/sdl_core/commit/f6ea1262c4b6a3d1e10dc89fa570720a6c85ea9d#diff-4a7a19ae471dc741759dcc42796f9fc3R1513
* | | | | | | Merge pull request #1781 from APCVSRepo/fix/core-cannot-find-app-via-btJacob Keeler2017-09-261-0/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix/core cannot find app via bt
| * | | | | | | fix core cannot find app via bt.panliang012017-09-121-0/+1
| | |_|_|/ / / | |/| | | | |
* | | | | | | Merge pull request #1774 from ↵JackLivio2017-09-262-2/+8
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | AKalinich-Luxoft/hotfix/fix_cache_manager_hmi_types_getter Fix DISALLOWED response when app has specifically defined policies
| * | | | | | Fix DISALLOWED response when app has specifically defined policiesAKalinich-Luxoft2017-09-222-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This problem mostly related to RC functionality. When SDL receives any RC request, it checks is sending app have REMOTE_CONTROL HMI type. If app does not have such HMI type, SDL disallows such RPC for it. The problem was in CacheManager::GetHMITypes() function, which returns appHMIType array even if it was not initialized(param is not present in policy) so SDL tries to find HMI type in an empty array and that always evaluates to false so SDL decides that current app is not RC app. If appHMITypes is not specified in policies, SDL should search HMI type in array of HMI types, provided by application on its registration. This check works correctly if application has default policies. To fix that problem there was added check in GetHMITypes() to avoid returning of uninitialized array.
* | | | | | | Merge pull request #1776 from JackLivio/fix/haptic_data_nav_onlyJackLivio2017-09-252-1/+37
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Require nav or projection app for SendHapticData
| * | | | | | | Require nav or projection app for SendHapticDataJackLivio2017-09-252-1/+37
| | |_|/ / / / | |/| | | | |
* | | | | | | Merge pull request #1763 from ↵JackLivio2017-09-255-0/+122
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | shoamano83/fix/enable_system_capabilities_from_file Fix/enable system capabilities from file
View Lorry Controller Status