From 08b875d51fcb835ff1d157115f2f94d8927d8ddb Mon Sep 17 00:00:00 2001 From: Shobhit Adlakha Date: Mon, 14 Mar 2022 08:59:17 -0400 Subject: Remove empty check in SaveConsumerFriendlyMessages to clear messages when core receives PTU with no consumer messages(with key defined) (#3879) --- src/components/policy/policy_external/src/sql_pt_representation.cc | 4 +--- src/components/policy/policy_regular/src/sql_pt_representation.cc | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/components/policy/policy_external/src/sql_pt_representation.cc b/src/components/policy/policy_external/src/sql_pt_representation.cc index 1570675cf9..5bee09773d 100644 --- a/src/components/policy/policy_external/src/sql_pt_representation.cc +++ b/src/components/policy/policy_external/src/sql_pt_representation.cc @@ -1611,9 +1611,7 @@ bool SQLPTRepresentation::SaveConsumerFriendlyMessages( utils::dbms::SQLQuery query(db()); bool delete_query_exec_result = true; - if (!messages.messages->empty()) { - delete_query_exec_result = query.Exec(sql_pt::kDeleteMessageString); - } + delete_query_exec_result = query.Exec(sql_pt::kDeleteMessageString); if (!delete_query_exec_result) { SDL_LOG_WARN("Failed to delete messages from DB."); diff --git a/src/components/policy/policy_regular/src/sql_pt_representation.cc b/src/components/policy/policy_regular/src/sql_pt_representation.cc index 0496896b60..f2254d7752 100644 --- a/src/components/policy/policy_regular/src/sql_pt_representation.cc +++ b/src/components/policy/policy_regular/src/sql_pt_representation.cc @@ -1575,9 +1575,7 @@ bool SQLPTRepresentation::SaveConsumerFriendlyMessages( utils::dbms::SQLQuery query(db()); bool delete_query_exec_result = true; - if (!messages.messages->empty()) { - delete_query_exec_result = query.Exec(sql_pt::kDeleteMessageString); - } + delete_query_exec_result = query.Exec(sql_pt::kDeleteMessageString); if (!delete_query_exec_result) { SDL_LOG_WARN("Failed to delete messages from DB."); -- cgit v1.2.1