diff options
| author | justingluck93 <47197545+justingluck93@users.noreply.github.com> | 2019-09-27 11:41:46 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-09-27 11:41:46 -0400 |
| commit | 1ecc597fe0c06a97f2fe416bb0570c1d652fb834 (patch) | |
| tree | 1d9f21b84bbbed10e6a0f32763c702e849b19585 | |
| parent | 285dc95d09ed364b3f1837d87ffff355ed7188fa (diff) | |
| download | sdl_ios-1ecc597fe0c06a97f2fe416bb0570c1d652fb834.tar.gz | |
Apply suggestions from code reviewbug/issue-1404-SliderScrollableNotSupportedAlert
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
| -rw-r--r-- | Example Apps/Example ObjC/MenuManager.m | 2 | ||||
| -rw-r--r-- | Example Apps/Example Swift/MenuManager.swift | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/Example Apps/Example ObjC/MenuManager.m b/Example Apps/Example ObjC/MenuManager.m index 7745fbb9e..fc97ceb24 100644 --- a/Example Apps/Example ObjC/MenuManager.m +++ b/Example Apps/Example ObjC/MenuManager.m @@ -148,7 +148,7 @@ NS_ASSUME_NONNULL_BEGIN SDLScrollableMessage *messageRPC = [[SDLScrollableMessage alloc] initWithMessage:@"This is a scrollable message\nIt can contain many lines" timeout:10000 softButtons:nil cancelID:5]; [manager sendRequest:messageRPC withResponseHandler:^(__kindof SDLRPCRequest * _Nullable request, __kindof SDLRPCResponse * _Nullable response, NSError * _Nullable error) { if(![response.resultCode isEqualToEnum:SDLResultSuccess]) { - [manager sendRequest: [AlertManager alertWithMessageAndCloseButton:@"Scrollable Message could not be displayed" textField2:nil iconName:nil]]; + [manager sendRequest:[AlertManager alertWithMessageAndCloseButton:@"Scrollable Message could not be displayed" textField2:nil iconName:nil]]; } }]; }]; diff --git a/Example Apps/Example Swift/MenuManager.swift b/Example Apps/Example Swift/MenuManager.swift index c3aeaec1c..bb7c5cb20 100644 --- a/Example Apps/Example Swift/MenuManager.swift +++ b/Example Apps/Example Swift/MenuManager.swift @@ -181,7 +181,7 @@ private extension MenuManager { return SDLMenuCell(title: ACSliderMenuName, icon: nil, voiceCommands: [ACSliderMenuName], handler: { _ in let slider = SDLSlider(numTicks: 3, position: 1, sliderHeader: "Select a letter", sliderFooters: ["A", "B", "C"], timeout: 3000) manager.send(request: slider, responseHandler: { (request, response, error) in - guard response?.resultCode == .success else { + guard let response = response, response.resultCode == .success else { manager.send(AlertManager.alertWithMessageAndCloseButton("Slider could not be displayed")) return } @@ -193,7 +193,7 @@ private extension MenuManager { return SDLMenuCell(title: ACScrollableMessageMenuName, icon: nil, voiceCommands: [ACScrollableMessageMenuName], handler: { _ in let scrollableMessage = SDLScrollableMessage(message: "This is a scrollable message\nIt can contain many lines", timeout: 10000, softButtons: nil) manager.send(request: scrollableMessage, responseHandler: { (request, response, error) in - guard response?.resultCode == .success else { + guard let response = response, response.resultCode == .success else { manager.send(AlertManager.alertWithMessageAndCloseButton("Scrollable could not be displayed")) return } |