summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjustingluck93 <47197545+justingluck93@users.noreply.github.com>2019-09-27 13:23:36 -0400
committerGitHub <noreply@github.com>2019-09-27 13:23:36 -0400
commit94e2eaeae5cd03d2ca2d85966633af3dd5d1570d (patch)
tree5a43d392f89a8f2530fbf57baaa9a0d92ddb6522
parente444d578896e8060f5cdcf063d0163120c562a77 (diff)
downloadsdl_ios-94e2eaeae5cd03d2ca2d85966633af3dd5d1570d.tar.gz
Apply suggestions from code review
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
-rw-r--r--SmartDeviceLink/SDLStreamingVideoLifecycleManager.m2
-rw-r--r--SmartDeviceLinkTests/DevAPISpecs/SDLStreamingVideoLifecycleManagerSpec.m2
2 files changed, 2 insertions, 2 deletions
diff --git a/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m b/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m
index 3296829c1..202d1f1d9 100644
--- a/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m
+++ b/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m
@@ -565,7 +565,7 @@ typedef void(^SDLVideoCapabilityResponseHandler)(SDLVideoStreamingCapability *_N
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated"
if ([SDLGlobals.sharedGlobals.rpcVersion isGreaterThanOrEqualToVersion:[[SDLVersion alloc] initWithMajor:4 minor:5 patch:0]]) {
- _streamingSupported = registerResponse.hmiCapabilities.videoStreaming ? registerResponse.hmiCapabilities.videoStreaming.boolValue : registerResponse.displayCapabilities.graphicSupported.boolValue;
+ _streamingSupported = registerResponse.hmiCapabilities.videoStreaming.boolValue;
} else {
_streamingSupported = YES;
}
diff --git a/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingVideoLifecycleManagerSpec.m b/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingVideoLifecycleManagerSpec.m
index 9e57c4995..5a2c3d7a1 100644
--- a/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingVideoLifecycleManagerSpec.m
+++ b/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingVideoLifecycleManagerSpec.m
@@ -218,7 +218,7 @@ describe(@"the streaming video manager", ^{
[NSThread sleepForTimeInterval:0.1];
});
- it(@"should support streaming", ^{
+ it(@"should support streaming even though hmiCapabilities.videoStreaming is nil", ^{
expect(@(streamingLifecycleManager.isStreamingSupported)).to(equal(@YES));
});
});