diff options
| author | NicoleYarroch <nicole@livio.io> | 2020-07-09 13:33:28 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-07-09 13:33:28 -0400 |
| commit | 1eee47ab8c124445f739f0931486c7c1825bd045 (patch) | |
| tree | 910b4f43d388ada9cbeaacd838a178f05926e35f | |
| parent | ff9a3f3eb4b8b8fea0065ded3ca487e59bcce880 (diff) | |
| download | sdl_ios-1eee47ab8c124445f739f0931486c7c1825bd045.tar.gz | |
Apply suggestions from code review
Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
| -rw-r--r-- | SmartDeviceLink/SDLH264VideoEncoder.m | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/SmartDeviceLink/SDLH264VideoEncoder.m b/SmartDeviceLink/SDLH264VideoEncoder.m index 12c86f582..b97793d9e 100644 --- a/SmartDeviceLink/SDLH264VideoEncoder.m +++ b/SmartDeviceLink/SDLH264VideoEncoder.m @@ -342,7 +342,7 @@ void sdl_videoEncoderOutputCallback(void * CM_NULLABLE outputCallbackRefCon, voi return (status == noErr); } -/// Validates the video encoder properties. +/// Validates the properties set by the developer into the encoder settings dictionary. If any are not available for use, the session will be cancelled. /// @param compressionSession The compression session on which the video encoder properties will be set /// @param error Error set if the video encoder properties are not valid /// @return True if the video encoder properties are valid; false if not @@ -359,7 +359,7 @@ void sdl_videoEncoderOutputCallback(void * CM_NULLABLE outputCallbackRefCon, voi return NO; } - NSArray* videoEncoderKeys = self.videoEncoderSettings.allKeys; + NSArray<NSString *> *videoEncoderKeys = self.videoEncoderSettings.allKeys; for (NSString *key in videoEncoderKeys) { if (CFDictionaryContainsKey(supportedProperties, (__bridge CFStringRef)key) == false) { if (error != NULL) { |