diff options
| author | Joel Fischer <joeljfischer@gmail.com> | 2020-07-09 13:27:58 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-07-09 13:27:58 -0400 |
| commit | a8a9aedaa1043b7e8588ede76169ff7aa329e8d3 (patch) | |
| tree | 7a6cc6d5a0426b91f54c1d56d4e4d64eab9ac551 | |
| parent | 25a8cc2decbc9e49826e02ed974044584e2616bc (diff) | |
| download | sdl_ios-a8a9aedaa1043b7e8588ede76169ff7aa329e8d3.tar.gz | |
Apply suggestions from code review
Co-authored-by: NicoleYarroch <nicole@livio.io>
| -rw-r--r-- | Example Apps/Example ObjC/RPCPermissionsManager.m | 2 | ||||
| -rw-r--r-- | SmartDeviceLink/SDLPermissionFilter.h | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/Example Apps/Example ObjC/RPCPermissionsManager.m b/Example Apps/Example ObjC/RPCPermissionsManager.m index 9fe9d75e8..6898707da 100644 --- a/Example Apps/Example ObjC/RPCPermissionsManager.m +++ b/Example Apps/Example ObjC/RPCPermissionsManager.m @@ -30,7 +30,7 @@ NS_ASSUME_NONNULL_BEGIN NSArray<SDLPermissionElement *> *menuRPCPermissions = @[addCommandPermissionElement, createInteractionPermissionElement, performInteractionPermissionElement]; [self sdlex_checkCurrentGroupPermissionsWithManager:manager permissionElements:menuRPCPermissions]; - // Set up an observer for permissions changes to media template releated RPCs. Since the `groupType` is set to all allowed, this block is called when the group permissions changes from all allowed. This block is called immediately when created. + // Set up an observer for permissions changes to media template releated RPCs. Since the `groupType` is set to all allowed, this block is called when the group permissions changes to all-allowed or from all-allowed to some-not-allowed. SDLPermissionElement *setMediaClockPermissionElement = [[SDLPermissionElement alloc] initWithRPCName:SDLRPCFunctionNameSetMediaClockTimer parameterPermissions:nil]; SDLPermissionElement *subscribeButtonPermissionElement = [[SDLPermissionElement alloc] initWithRPCName:SDLRPCFunctionNameSubscribeButton parameterPermissions:nil]; NSArray<SDLPermissionElement *> *mediaTemplateRPCPermissions = @[setMediaClockPermissionElement, subscribeButtonPermissionElement]; diff --git a/SmartDeviceLink/SDLPermissionFilter.h b/SmartDeviceLink/SDLPermissionFilter.h index 93cf4d2fd..e733d2331 100644 --- a/SmartDeviceLink/SDLPermissionFilter.h +++ b/SmartDeviceLink/SDLPermissionFilter.h @@ -58,9 +58,9 @@ NS_ASSUME_NONNULL_BEGIN /** * Create a new permission filter group with a SDLRPCPermissionStatusChangedHandler. * - * @param rpcNames The names of the RPCs to watch permissions of. + * @param rpcNames The names of the RPCs to watch permissions of. * @param groupType The type of notifications to be sent for this filter group. - * @param permissionStatusHandler The block observer to be called when changes occur. + * @param permissionStatusHandler The block observer to be called when changes occur. * * @return An instance of `SDLPermissionFilter`. */ @@ -76,7 +76,7 @@ NS_ASSUME_NONNULL_BEGIN - (BOOL)isEqualToFilter:(SDLPermissionFilter *)otherFilter; /** - * Converts an array of SDLPermissionElement objects to and array of SDLPermissionRPCName objects + * Converts an array of SDLPermissionElement objects to an array of SDLPermissionRPCName objects * * @param permissionElements The permission elements to convert. * |