summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Fischer <joeljfischer@gmail.com>2020-07-09 13:24:56 -0400
committerGitHub <noreply@github.com>2020-07-09 13:24:56 -0400
commit25a8cc2decbc9e49826e02ed974044584e2616bc (patch)
tree890ff8e340916ff4f76bc9cda865620a5145c836
parent553b66900714c8fbcc279e4d8a59f89d969f8a96 (diff)
downloadsdl_ios-25a8cc2decbc9e49826e02ed974044584e2616bc.tar.gz
Apply suggestions from code review
Co-authored-by: NicoleYarroch <nicole@livio.io>
-rw-r--r--SmartDeviceLink/SDLPermissionConstants.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/SmartDeviceLink/SDLPermissionConstants.h b/SmartDeviceLink/SDLPermissionConstants.h
index 4cfb4d500..9a6a5d533 100644
--- a/SmartDeviceLink/SDLPermissionConstants.h
+++ b/SmartDeviceLink/SDLPermissionConstants.h
@@ -70,7 +70,7 @@ typedef NS_ENUM(NSUInteger, SDLPermissionGroupStatus) {
typedef void (^SDLPermissionsChangedHandler)(NSDictionary<SDLPermissionRPCName, NSNumber *> *_Nonnull change, SDLPermissionGroupStatus status);
/**
- * The PermissionObserver is a block that is passed in to some methods that will be stored and called when specified permissions change. // to do update
+ * A block that will be called when specified permissions change. It will return whether each RPC and its parameters are allowed as well as the permission group status of all the RPCs.
*
* @param change A dictionary of permission changes containing <key(String): SDLPermissionRPCName, object(SDLRPCPermissionStatus)>
* @param status The change made to all of the RPCs in the changedDict. Allowed, if all RPCs are now allowed, Disallowed if all RPCs are now disallowed, or Mixed if some are allowed, and some are disallowed
@@ -78,7 +78,7 @@ typedef void (^SDLPermissionsChangedHandler)(NSDictionary<SDLPermissionRPCName,
typedef void (^SDLRPCPermissionStatusChangedHandler)(NSDictionary<SDLRPCFunctionName, SDLRPCPermissionStatus *> *_Nonnull change, SDLPermissionGroupStatus status);
/**
- * The SDLObservedPermissionsChangedHandler is a block that is passed in to subscribeToRPCNames:groupType:withHandler: that will be stored and called when specified permissions change.
+ * A block that will be called when specified permissions change. It will return whether each RPC is allowed as well as the permission group status of all the RPCs.
*
* @param change A dictionary of permission changes containing <key(SDLRPCFunctionName): RPC Name, object(BOOL): YES if the RPC is allowed, NO if it is not allowed>
* @param status The change made to all of the RPCs in the changedDict. Allowed, if all RPCs are now allowed, Disallowed if all RPCs are now disallowed, or Mixed if some are allowed, and some are disallowed