summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicoleYarroch <nicole@livio.io>2020-07-14 11:13:12 -0400
committerGitHub <noreply@github.com>2020-07-14 11:13:12 -0400
commit550c5a4d8926df51f7fbe83809f5de906e0867e5 (patch)
treeb6d2b2b41f8a72b9c34f671be4f073a1390667ff
parent54bb8cefc1933d27a3061468608f326871d693ed (diff)
downloadsdl_ios-550c5a4d8926df51f7fbe83809f5de906e0867e5.tar.gz
Apply suggestions from code review
Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
-rw-r--r--SmartDeviceLink/SDLSystemCapabilityManager.m7
1 files changed, 3 insertions, 4 deletions
diff --git a/SmartDeviceLink/SDLSystemCapabilityManager.m b/SmartDeviceLink/SDLSystemCapabilityManager.m
index 3eaabb222..b0aaac339 100644
--- a/SmartDeviceLink/SDLSystemCapabilityManager.m
+++ b/SmartDeviceLink/SDLSystemCapabilityManager.m
@@ -93,7 +93,7 @@ typedef NSString * SDLServiceID;
}
if (@available(iOS 10.0, *)) {
- _readWriteQueue = dispatch_queue_create_with_target("com.sdl.lifecycle.responseDispatcher", DISPATCH_QUEUE_SERIAL, [SDLGlobals sharedGlobals].sdlProcessingQueue);
+ _readWriteQueue = dispatch_queue_create_with_target("com.sdl.systemCapabilityManager.readWriteQueue", DISPATCH_QUEUE_SERIAL, [SDLGlobals sharedGlobals].sdlProcessingQueue);
} else {
_readWriteQueue = [SDLGlobals sharedGlobals].sdlProcessingQueue;
}
@@ -462,9 +462,8 @@ typedef NSString * SDLServiceID;
- (void)sdl_saveAppServicesCapabilitiesUpdate:(SDLAppServicesCapabilities *)newCapabilities {
SDLLogV(@"Saving app services capability update with new capabilities: %@", newCapabilities);
for (SDLAppServiceCapability *capability in newCapabilities.appServices) {
-
// If the capability has been removed, delete the saved capability; otherwise just update with the new capability
- SDLAppServiceCapability *newcapability = [capability.updateReason isEqualToEnum:SDLServiceUpdateRemoved] ? nil : capability;
+ SDLAppServiceCapability *newCapability = [capability.updateReason isEqualToEnum:SDLServiceUpdateRemoved] ? nil : capability;
[self sdl_runSyncOnQueue:^{
self.appServicesCapabilitiesDictionary[capability.updatedAppServiceRecord.serviceID] = newcapability;
}];
@@ -817,7 +816,7 @@ typedef NSString * SDLServiceID;
}
- (NSMutableDictionary<SDLSystemCapabilityType, NSNumber<SDLBool> *> *)subscriptionStatus {
- __block NSMutableDictionary<SDLSystemCapabilityType, NSNumber<SDLBool> *> *dict = nil;
+ __block NSMutableDictionary<SDLSystemCapabilityType, NSNumber<SDLBool> *> *dict = nil;
[self sdl_runSyncOnQueue:^{
dict = self->_subscriptionStatus;
}];