diff options
| author | Joel Fischer <joeljfischer@gmail.com> | 2020-07-09 13:24:07 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-07-09 13:24:07 -0400 |
| commit | 553b66900714c8fbcc279e4d8a59f89d969f8a96 (patch) | |
| tree | 28ba796c1f535359f69e892df9f2a73ab709fb79 | |
| parent | eb8a991078f0b0accd6fc807a2a5ec42f29aac45 (diff) | |
| download | sdl_ios-553b66900714c8fbcc279e4d8a59f89d969f8a96.tar.gz | |
Apply suggestions from code review
Co-authored-by: NicoleYarroch <nicole@livio.io>
| -rw-r--r-- | Example Apps/Example Swift/RPCPermissionsManager.swift | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Example Apps/Example Swift/RPCPermissionsManager.swift b/Example Apps/Example Swift/RPCPermissionsManager.swift index 9a320247a..efb60f529 100644 --- a/Example Apps/Example Swift/RPCPermissionsManager.swift +++ b/Example Apps/Example Swift/RPCPermissionsManager.swift @@ -26,7 +26,7 @@ class RPCPermissionsManager { let menuRPCPermissions = [addCommandPermissionElement, createInteractionPermissionElement, performInteractionPermissionElement] _ = checkCurrentGroupPermissions(with: manager, permissionElements: menuRPCPermissions) - // Set up an observer for permissions changes to media template releated RPCs. Since the `groupType` is set to all allowed, this block is called when the group permissions changes from all allowed. This block is called immediately when created. + // Set up an observer for permissions changes to media template releated RPCs. Since the `groupType` is set to all allowed, this block is called when the group permissions changes to all-allowed or from all-allowed to some-not-allowed. let setMediaClockPermissionElement = SDLPermissionElement(rpcName: SDLRPCFunctionName.setMediaClockTimer, parameterPermissions: nil) let subscribeButtonPermissionElement = SDLPermissionElement(rpcName: SDLRPCFunctionName.subscribeButton, parameterPermissions: nil) let mediaTemplatePermissions = [setMediaClockPermissionElement, subscribeButtonPermissionElement] @@ -62,7 +62,7 @@ private extension RPCPermissionsManager { return isRPCAllowed } - /// Checks if all the RPCs need to create menus are allowed right at this moment + /// Checks if a group of RPCs are currently allowed. /// /// - Parameter manager: The SDL Manager /// - Returns: The rpc names, the group permission status and the permission status for each rpc in the group |