diff options
| author | Joel Fischer <joeljfischer@gmail.com> | 2020-09-02 08:57:14 -0400 |
|---|---|---|
| committer | Joel Fischer <joeljfischer@gmail.com> | 2020-09-02 08:57:14 -0400 |
| commit | ffd33227a8bd8e2f616489b4101090c31eb9a466 (patch) | |
| tree | 651086b15d65f0c53d022d2aad48a0444c19eac6 | |
| parent | 9af1986dfeff42daa11d088a14b37ea2d0fa3762 (diff) | |
| parent | ba06f247c43c1b6d01ac2f81c9dc261fa5e11243 (diff) | |
| download | sdl_ios-ffd33227a8bd8e2f616489b4101090c31eb9a466.tar.gz | |
Merge branch 'master' into develop
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4b6a829de..a980c7629 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_ios/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Once this PR is ready for review, please request one from @smartdevicelink/ios. +[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_ios/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Please create the PR as a draft until it is ready for review. Once this PR is ready for review, please request one from @smartdevicelink/ios and mark the PR as ready for review. Also, remember that all new public file headers should be added as public in the `File Inspector / Target Membership` pane, added to `SmartDeviceLink.h` and to *both* `.podspec` files. @@ -6,8 +6,6 @@ Delete the above section when you've read it.] Fixes #[issue number] -This PR is **[ready / not ready]** for review. - ### Risk This PR makes **[no / minor / major]** API changes. |