diff options
| author | Frank Elias <francois.elias@livio.io> | 2021-01-12 17:33:32 -0500 |
|---|---|---|
| committer | Frank Elias <francois.elias@livio.io> | 2021-01-12 17:33:32 -0500 |
| commit | b0e439ffadf746710d8a93808d3a3abe69e45796 (patch) | |
| tree | b4237718bab266d3e3c0c5cb0fe83e806f445b30 | |
| parent | 6998432ce33ab1d2bfdf0da6b33c616015ac92c4 (diff) | |
| download | sdl_ios-b0e439ffadf746710d8a93808d3a3abe69e45796.tar.gz | |
Comment review
| -rw-r--r-- | SmartDeviceLink/public/SDLSetMediaClockTimer.h | 6 | ||||
| -rw-r--r-- | SmartDeviceLink/public/SDLSetMediaClockTimer.m | 10 |
2 files changed, 4 insertions, 12 deletions
diff --git a/SmartDeviceLink/public/SDLSetMediaClockTimer.h b/SmartDeviceLink/public/SDLSetMediaClockTimer.h index d050181ae..2e5343245 100644 --- a/SmartDeviceLink/public/SDLSetMediaClockTimer.h +++ b/SmartDeviceLink/public/SDLSetMediaClockTimer.h @@ -87,7 +87,7 @@ NS_ASSUME_NONNULL_BEGIN @param playPauseIndicator An optional audio indicator to change the play/pause button @return An object of SetMediaClockTimer */ -+ (instancetype)updatePauseWithNewStartTimeInterval:(NSTimeInterval)startTime endTimeInterval:(NSTimeInterval)endTime playPauseIndicator:(nullable SDLAudioStreamingIndicator)playPauseIndicator NS_SWIFT_NAME(pause(newStart:newEnd:playPauseIndicator:)) __deprecated_msg("Use initWithUpdateMode:startTime:endTime:audioStreamingIndicator:countRate: instead"); ++ (instancetype)updatePauseWithNewStartTimeInterval:(NSTimeInterval)startTime endTimeInterval:(NSTimeInterval)endTime playPauseIndicator:(nullable SDLAudioStreamingIndicator)playPauseIndicator NS_SWIFT_NAME(pause(newStart:newEnd:playPauseIndicator:)); /** Update a pause time (or pause and update the time) on a media clock timer @@ -97,7 +97,7 @@ NS_ASSUME_NONNULL_BEGIN @param playPauseIndicator An optional audio indicator to change the play/pause button @return An object of SetMediaClockTimer */ -+ (instancetype)updatePauseWithNewStartTime:(SDLStartTime *)startTime endTime:(SDLStartTime *)endTime playPauseIndicator:(nullable SDLAudioStreamingIndicator)playPauseIndicator NS_SWIFT_NAME(pause(newStart:newEnd:playPauseIndicator:)) __deprecated_msg("Use initWithUpdateMode:startTime:endTime:audioStreamingIndicator:countRate: instead"); ++ (instancetype)updatePauseWithNewStartTime:(SDLStartTime *)startTime endTime:(SDLStartTime *)endTime playPauseIndicator:(nullable SDLAudioStreamingIndicator)playPauseIndicator NS_SWIFT_NAME(pause(newStart:newEnd:playPauseIndicator:)); /** Resume a paused media clock timer. It resumes at the same time at which it was paused. @@ -113,7 +113,7 @@ NS_ASSUME_NONNULL_BEGIN @param playPauseIndicator An optional audio indicator to change the play/pause button @return An object of SetMediaClockTimer */ -+ (instancetype)clearWithPlayPauseIndicator:(nullable SDLAudioStreamingIndicator)playPauseIndicator NS_SWIFT_NAME(clear(playPauseIndicator:)) __deprecated_msg("Use initWithUpdateMode:startTime:endTime:audioStreamingIndicator:countRate: instead"); ++ (instancetype)clearWithPlayPauseIndicator:(nullable SDLAudioStreamingIndicator)playPauseIndicator NS_SWIFT_NAME(clear(playPauseIndicator:)); /** * @param updateMode - updateMode diff --git a/SmartDeviceLink/public/SDLSetMediaClockTimer.m b/SmartDeviceLink/public/SDLSetMediaClockTimer.m index edadeda48..cf576919a 100644 --- a/SmartDeviceLink/public/SDLSetMediaClockTimer.m +++ b/SmartDeviceLink/public/SDLSetMediaClockTimer.m @@ -32,15 +32,7 @@ NS_ASSUME_NONNULL_BEGIN } - (instancetype)initWithUpdateMode:(SDLUpdateMode)updateMode startTime:(nullable SDLStartTime *)startTime endTime:(nullable SDLStartTime *)endTime playPauseIndicator:(nullable SDLAudioStreamingIndicator)playPauseIndicator { - self = [self init]; - if (!self) { return nil; } - - self.updateMode = updateMode; - self.startTime = startTime; - self.endTime = endTime; - self.audioStreamingIndicator = playPauseIndicator; - - return self; + return [self initWithUpdateMode:updateMode startTime:startTime endTime:endTime audioStreamingIndicator:playPauseIndicator countRate:nil]; } - (instancetype)initWithUpdateMode:(SDLUpdateMode)updateMode startTime:(nullable SDLStartTime *)startTime endTime:(nullable SDLStartTime *)endTime audioStreamingIndicator:(nullable SDLAudioStreamingIndicator)audioStreamingIndicator countRate:(nullable NSNumber<SDLFloat> *)countRate { |