diff options
| author | Joel Fischer <joeljfischer@gmail.com> | 2018-10-30 18:08:13 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-10-30 18:08:13 -0400 |
| commit | d2fc40d831a752b709b3bdc4c148b177b66b9046 (patch) | |
| tree | 72b88037b99fdbee564560fdc7c1e447ab0fd5e7 | |
| parent | 7ede32259a8229fea6804eccbc76cb2b9d528833 (diff) | |
| parent | ba5fe539e7e09da59c54784c3aaa4cfd323ac10b (diff) | |
| download | sdl_ios-d2fc40d831a752b709b3bdc4c148b177b66b9046.tar.gz | |
Merge pull request #1121 from smartdevicelink/hotfix/pull_request_template
Add best practices link and review info to template
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 995262c63..adb218337 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_ios/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA. +[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_ios/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Once this PR is ready for review, please request one from @smartdevicelink/ios. Also, remember that all new public file headers should be added as public in the `File Inspector / Target Membership` pane, added to `SmartDeviceLink.h` and to *both* `.podspec` files. |