diff options
author | NicoleYarroch <nicole@livio.io> | 2020-04-01 09:30:41 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-04-01 09:30:41 -0400 |
commit | 1af928220ffe9c980b54b2dd8a88f8e15acd0bb7 (patch) | |
tree | be01a8f151c193128d3b7d2014ae885c7c74888b | |
parent | 4e41d9f7e41a7a5ae6246f7ae1c718550bed4e38 (diff) | |
download | sdl_ios-1af928220ffe9c980b54b2dd8a88f8e15acd0bb7.tar.gz |
Apply suggestions from code review
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
-rw-r--r-- | SmartDeviceLink/SDLChoiceSetManager.m | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/SmartDeviceLink/SDLChoiceSetManager.m b/SmartDeviceLink/SDLChoiceSetManager.m index 98c21d47a..029188fd1 100644 --- a/SmartDeviceLink/SDLChoiceSetManager.m +++ b/SmartDeviceLink/SDLChoiceSetManager.m @@ -260,7 +260,7 @@ UInt16 const ChoiceCellCancelIdMin = 1; // Check if the manager has shutdown because the list of uploaded and pending choices should not be updated if ([strongSelf.currentState isEqualToString:SDLChoiceManagerStateShutdown]) { - SDLLogD(@"The manager has shutdown"); + SDLLogD(@"Cancelling preloading choices because the manager is shut down"); return; } @@ -326,7 +326,7 @@ UInt16 const ChoiceCellCancelIdMin = 1; // Check if the manager has shutdown because the list of uploaded choices should not be updated if ([strongSelf.currentState isEqualToString:SDLChoiceManagerStateShutdown]) { - SDLLogD(@"The manager has shutdown"); + SDLLogD(@"Cancelling deleting choices because manager is shut down"); return; } @@ -351,7 +351,7 @@ UInt16 const ChoiceCellCancelIdMin = 1; return; } - if (self.pendingPresentationSet != nil && self.pendingPresentOperation.isFinished == NO) { + if (self.pendingPresentationSet != nil && !self.pendingPresentOperation.isFinished) { SDLLogW(@"A choice set is pending: %@. We will try to cancel it in favor of presenting a different choice set: %@. If it's already on screen it cannot be cancelled", self.pendingPresentationSet, choiceSet); [self.pendingPresentOperation cancel]; } |