diff options
author | NicoleYarroch <nicole@livio.io> | 2020-03-19 07:39:30 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-03-19 07:39:30 -0400 |
commit | 8b357dfc4312cb93db78411ad26e114d24ac9297 (patch) | |
tree | 1dd0244fad76f6b0a4b2014c26c5cf266f3ecb9c | |
parent | ea063fff4f479426c8260e38843e08143f001a8a (diff) | |
download | sdl_ios-8b357dfc4312cb93db78411ad26e114d24ac9297.tar.gz |
Apply suggestions from code review
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
4 files changed, 6 insertions, 4 deletions
diff --git a/SmartDeviceLink/SDLStreamingAudioLifecycleManager.m b/SmartDeviceLink/SDLStreamingAudioLifecycleManager.m index 36ebef147..6bc8fb8ac 100644 --- a/SmartDeviceLink/SDLStreamingAudioLifecycleManager.m +++ b/SmartDeviceLink/SDLStreamingAudioLifecycleManager.m @@ -305,7 +305,7 @@ NS_ASSUME_NONNULL_BEGIN } - (BOOL)isStreamingSupported { - return self.systemCapabilityManager != nil ? [self.systemCapabilityManager isCapabilitySupported:SDLSystemCapabilityTypeVideoStreaming] : YES; + return (self.systemCapabilityManager != nil) ? [self.systemCapabilityManager isCapabilitySupported:SDLSystemCapabilityTypeVideoStreaming] : YES; } @end diff --git a/SmartDeviceLink/SDLStreamingVideoLifecycleManager.h b/SmartDeviceLink/SDLStreamingVideoLifecycleManager.h index 365c7b5b4..0ed5e1c7e 100644 --- a/SmartDeviceLink/SDLStreamingVideoLifecycleManager.h +++ b/SmartDeviceLink/SDLStreamingVideoLifecycleManager.h @@ -61,7 +61,7 @@ NS_ASSUME_NONNULL_BEGIN @property (weak, nonatomic, nullable) id<SDLStreamingMediaManagerDataSource> dataSource; /// Whether or not video/audio streaming is supported -/// @discussion If connected to a module pre-SDL v4.5 there is no way to check if streaming is supported so `YES` is returned by default even though the module may NOT support video/audio streaming. +/// @discussion If connected to a module pre-SDL v4.5 there is no way to check if streaming is supported so `YES` is returned by default even though the module may not support video/audio streaming. @property (assign, nonatomic, readonly, getter=isStreamingSupported) BOOL streamingSupported; /** diff --git a/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m b/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m index 9af332265..dcd02e7a8 100644 --- a/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m +++ b/SmartDeviceLink/SDLStreamingVideoLifecycleManager.m @@ -572,7 +572,7 @@ typedef void(^SDLVideoCapabilityResponseHandler)(SDLVideoStreamingCapability *_N } SDLLogD(@"Received Register App Interface"); - SDLRegisterAppInterfaceResponse *registerResponse = (SDLRegisterAppInterfaceResponse*)notification.response; + SDLRegisterAppInterfaceResponse *registerResponse = (SDLRegisterAppInterfaceResponse *)notification.response; #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wdeprecated" @@ -827,7 +827,7 @@ typedef void(^SDLVideoCapabilityResponseHandler)(SDLVideoStreamingCapability *_N } - (BOOL)isStreamingSupported { - return self.systemCapabilityManager != nil ? [self.systemCapabilityManager isCapabilitySupported:SDLSystemCapabilityTypeVideoStreaming] : YES; + return (self.systemCapabilityManager != nil) ? [self.systemCapabilityManager isCapabilitySupported:SDLSystemCapabilityTypeVideoStreaming] : YES; } @end diff --git a/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingAudioLifecycleManagerSpec.m b/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingAudioLifecycleManagerSpec.m index b82c3078e..69e9cea80 100644 --- a/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingAudioLifecycleManagerSpec.m +++ b/SmartDeviceLinkTests/DevAPISpecs/SDLStreamingAudioLifecycleManagerSpec.m @@ -23,7 +23,9 @@ #import "TestConnectionManager.h" @interface SDLStreamingAudioLifecycleManager() + @property (copy, nonatomic) NSString *connectedVehicleMake; + @end QuickSpecBegin(SDLStreamingAudioLifecycleManagerSpec) |