diff options
| author | Joel Fischer <joeljfischer@gmail.com> | 2020-03-11 12:12:06 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-11 12:12:06 -0400 |
| commit | f4796302d97357bbc24fa50407dc7e1d0692a36e (patch) | |
| tree | b44ba2b0d70d18cc9592cc1fa898efae552c7051 | |
| parent | 4c7900e48a416209b76c60c24ce5c2eadb11d950 (diff) | |
| download | sdl_ios-f4796302d97357bbc24fa50407dc7e1d0692a36e.tar.gz | |
Apply suggestions from code review
Co-Authored-By: NicoleYarroch <nicole@livio.io>
| -rw-r--r-- | SmartDeviceLink/SDLSoftButtonManager.m | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/SmartDeviceLink/SDLSoftButtonManager.m b/SmartDeviceLink/SDLSoftButtonManager.m index 244e72c47..96b230b28 100644 --- a/SmartDeviceLink/SDLSoftButtonManager.m +++ b/SmartDeviceLink/SDLSoftButtonManager.m @@ -116,7 +116,7 @@ NS_ASSUME_NONNULL_BEGIN - (void)setSoftButtonObjects:(NSArray<SDLSoftButtonObject *> *)softButtonObjects { // Only update if something changed. This prevents, for example, an empty array being reset if (_softButtonObjects == softButtonObjects) { - SDLLogD(@"Set soft button objects are equivalent to existing soft button objects, skipping..."); + SDLLogD(@"New soft button objects are equivalent to existing soft button objects, skipping..."); return; } @@ -139,7 +139,7 @@ NS_ASSUME_NONNULL_BEGIN _softButtonObjects = softButtonObjects; - // We assume that all soft button capabilities are the same, so we only need to send one + // We only need to pass the first `softButtonCapabilities` in the array due to the fact that all soft button capabilities are the same (i.e. there is no way to assign a `softButtonCapabilities` to a specific soft button). SDLSoftButtonReplaceOperation *op = [[SDLSoftButtonReplaceOperation alloc] initWithConnectionManager:self.connectionManager fileManager:self.fileManager capabilities:self.windowCapability.softButtonCapabilities[0] softButtonObjects:_softButtonObjects mainField1:self.currentMainField1]; if (self.isBatchingUpdates) { |