diff options
author | Nicole Yarroch <nicole@livio.io> | 2021-04-07 11:22:21 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-07 11:22:21 -0400 |
commit | a13f2ecacb10684dec64bf042ff511c61a71e30a (patch) | |
tree | 0473059aff4f0e1356fc3cdd9cb3e166b70aac45 | |
parent | fea71f955b483b08c44faacbd1173e5e414c8e45 (diff) | |
download | sdl_ios-a13f2ecacb10684dec64bf042ff511c61a71e30a.tar.gz |
Apply suggestions from code review
Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
-rw-r--r-- | SmartDeviceLink/private/SDLStreamingVideoLifecycleManager.m | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/SmartDeviceLink/private/SDLStreamingVideoLifecycleManager.m b/SmartDeviceLink/private/SDLStreamingVideoLifecycleManager.m index 5a6100b83..c1b54b83e 100644 --- a/SmartDeviceLink/private/SDLStreamingVideoLifecycleManager.m +++ b/SmartDeviceLink/private/SDLStreamingVideoLifecycleManager.m @@ -1131,12 +1131,12 @@ typedef void(^SDLVideoCapabilityResponseHandler)(SDLVideoStreamingCapability *_N // Apply customEncoderSettings here. Note that value from HMI (such as maxBitrate) will be overwritten by custom settings // (Exception: ExpectedFrameRate, AverageBitRate) for (id key in self.customEncoderSettings.keyEnumerator) { - // do NOT override framerate or average bitrate if custom setting is higher than current setting. + // Do *not* override framerate or average bitrate if custom setting is higher than current setting. // See SDL 0323 (https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0323-align-VideoStreamingParameter-with-capability.md) for details. if (([(NSString *)key isEqualToString:(__bridge NSString *)kVTCompressionPropertyKey_ExpectedFrameRate] && capability.preferredFPS != nil) || ([(NSString *)key isEqualToString:(__bridge NSString *)kVTCompressionPropertyKey_AverageBitRate] && capability.maxBitrate != nil)) { - NSNumber *customEncoderSettings = (NSNumber *)[self.customEncoderSettings valueForKey:key]; - NSNumber *videoEncoderSettings = (NSNumber *)[self.videoEncoderSettings valueForKey:key]; + NSNumber *customEncoderSettings = (NSNumber *)self.customEncoderSettings[key]; + NSNumber *videoEncoderSettings = (NSNumber *)self.videoEncoderSettings[key]; if (customEncoderSettings.doubleValue < videoEncoderSettings.doubleValue) { self.videoEncoderSettings[key] = customEncoderSettings; } |