diff options
author | yLeonid <YLokhmatov@luxoft.com> | 2019-09-29 23:12:32 +0300 |
---|---|---|
committer | yLeonid <YLokhmatov@luxoft.com> | 2019-09-29 23:12:32 +0300 |
commit | a34f760252f948e44450c97b214a9a7d4c54a552 (patch) | |
tree | c96d391236d3fbe306417a07c6af045322a8d9a5 | |
parent | fa0bd0367552f9d95aff167d600caa8ab370c052 (diff) | |
download | sdl_ios-a34f760252f948e44450c97b214a9a7d4c54a552.tar.gz |
1386_manager_update_display_capability : fix SDLSoftButtonManager and its test
https://github.com/smartdevicelink/sdl_ios/pull/1390/files/ce156b1ace4685978e90941ac3870910f9913242#r324800071
-rw-r--r-- | SmartDeviceLink/SDLSoftButtonManager.m | 12 | ||||
-rw-r--r-- | SmartDeviceLinkTests/DevAPISpecs/SDLSoftButtonManagerSpec.m | 6 |
2 files changed, 9 insertions, 9 deletions
diff --git a/SmartDeviceLink/SDLSoftButtonManager.m b/SmartDeviceLink/SDLSoftButtonManager.m index 8bf5ce1cb..17020b766 100644 --- a/SmartDeviceLink/SDLSoftButtonManager.m +++ b/SmartDeviceLink/SDLSoftButtonManager.m @@ -45,7 +45,7 @@ NS_ASSUME_NONNULL_BEGIN @property (strong, nonatomic) NSOperationQueue *transactionQueue; -@property (strong, nonatomic, nullable) SDLWindowCapability *defaultMainWindowCapability; +@property (strong, nonatomic, nullable, readonly) SDLWindowCapability *windowCapability; @property (copy, nonatomic, nullable) SDLHMILevel currentLevel; @property (strong, nonatomic) NSMutableArray<SDLAsynchronousOperation *> *batchQueue; @@ -76,7 +76,7 @@ NS_ASSUME_NONNULL_BEGIN _softButtonObjects = @[]; _currentMainField1 = nil; _currentLevel = nil; - _defaultMainWindowCapability = nil; + _windowCapability = nil; [_transactionQueue cancelAllOperations]; self.transactionQueue = [self sdl_newTransactionQueue]; @@ -120,7 +120,7 @@ NS_ASSUME_NONNULL_BEGIN _softButtonObjects = softButtonObjects; - SDLSoftButtonReplaceOperation *op = [[SDLSoftButtonReplaceOperation alloc] initWithConnectionManager:self.connectionManager fileManager:self.fileManager capabilities:self.defaultMainWindowCapability.softButtonCapabilities.firstObject softButtonObjects:_softButtonObjects mainField1:self.currentMainField1]; + SDLSoftButtonReplaceOperation *op = [[SDLSoftButtonReplaceOperation alloc] initWithConnectionManager:self.connectionManager fileManager:self.fileManager capabilities:self.windowCapability.softButtonCapabilities.firstObject softButtonObjects:_softButtonObjects mainField1:self.currentMainField1]; if (self.isBatchingUpdates) { [self.batchQueue removeAllObjects]; @@ -132,7 +132,7 @@ NS_ASSUME_NONNULL_BEGIN } - (void)sdl_transitionSoftButton:(SDLSoftButtonObject *)softButton { - SDLSoftButtonTransitionOperation *op = [[SDLSoftButtonTransitionOperation alloc] initWithConnectionManager:self.connectionManager capabilities:self.defaultMainWindowCapability.softButtonCapabilities.firstObject softButtons:self.softButtonObjects mainField1:self.currentMainField1]; + SDLSoftButtonTransitionOperation *op = [[SDLSoftButtonTransitionOperation alloc] initWithConnectionManager:self.connectionManager capabilities:self.windowCapability.softButtonCapabilities.firstObject softButtons:self.softButtonObjects mainField1:self.currentMainField1]; if (self.isBatchingUpdates) { for (SDLAsynchronousOperation *sbOperation in self.batchQueue) { @@ -191,11 +191,11 @@ NS_ASSUME_NONNULL_BEGIN - (void)sdl_displayCapabilityUpdate:(SDLSystemCapability *)systemCapability { // we won't use the object in the parameter but the convenience method of the system capability manager - self.defaultMainWindowCapability = _systemCapabilityManager.defaultMainWindowCapability; + _windowCapability = _systemCapabilityManager.defaultMainWindowCapability; // Auto-send an updated Show to account for changes to the capabilities if (self.softButtonObjects.count > 0) { - SDLSoftButtonReplaceOperation *op = [[SDLSoftButtonReplaceOperation alloc] initWithConnectionManager:self.connectionManager fileManager:self.fileManager capabilities:self.defaultMainWindowCapability.softButtonCapabilities.firstObject softButtonObjects:self.softButtonObjects mainField1:self.currentMainField1]; + SDLSoftButtonReplaceOperation *op = [[SDLSoftButtonReplaceOperation alloc] initWithConnectionManager:self.connectionManager fileManager:self.fileManager capabilities:self.windowCapability.softButtonCapabilities.firstObject softButtonObjects:self.softButtonObjects mainField1:self.currentMainField1]; [self.transactionQueue addOperation:op]; } } diff --git a/SmartDeviceLinkTests/DevAPISpecs/SDLSoftButtonManagerSpec.m b/SmartDeviceLinkTests/DevAPISpecs/SDLSoftButtonManagerSpec.m index b3feea183..f5a80725f 100644 --- a/SmartDeviceLinkTests/DevAPISpecs/SDLSoftButtonManagerSpec.m +++ b/SmartDeviceLinkTests/DevAPISpecs/SDLSoftButtonManagerSpec.m @@ -34,7 +34,7 @@ @property (strong, nonatomic) NSOperationQueue *transactionQueue; -@property (strong, nonatomic, nullable) SDLWindowCapability *defaultMainWindowCapability; +@property (strong, nonatomic, nullable, readonly) SDLWindowCapability *windowCapability; @property (copy, nonatomic, nullable) SDLHMILevel currentLevel; @property (strong, nonatomic) NSMutableArray<SDLAsynchronousOperation *> *batchQueue; @@ -84,7 +84,7 @@ describe(@"a soft button manager", ^{ expect(testManager.softButtonObjects).to(beEmpty()); expect(testManager.currentMainField1).to(beNil()); - expect(testManager.defaultMainWindowCapability).to(beNil()); + expect(testManager.windowCapability).to(beNil()); expect(testManager.transactionQueue).toNot(beNil()); }); @@ -245,7 +245,7 @@ describe(@"a soft button manager", ^{ expect(testManager.currentMainField1).to(beNil()); expect(testManager.transactionQueue.operationCount).to(equal(0)); expect(testManager.currentLevel).to(beNil()); - expect(testManager.defaultMainWindowCapability).to(beNil()); + expect(testManager.windowCapability).to(beNil()); }); }); }); |