diff options
| author | Oleksandr Lavrushko <olavrushko@sygic.com> | 2017-05-02 16:29:59 +0200 |
|---|---|---|
| committer | Oleksandr Lavrushko <olavrushko@sygic.com> | 2017-05-02 16:29:59 +0200 |
| commit | ff834e9ca5e140691ee1d47269d8a6505384f66c (patch) | |
| tree | 0b4285f6ac410d6b2ea6da38427598ebf29349f6 | |
| parent | 732ed0ebdabbac49fb21ff851d40a41e5dfd8ae3 (diff) | |
| download | sdl_ios-ff834e9ca5e140691ee1d47269d8a6505384f66c.tar.gz | |
Remarks after code review.
| -rw-r--r-- | SmartDeviceLink/SDLStreamingMediaManager.m | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/SmartDeviceLink/SDLStreamingMediaManager.m b/SmartDeviceLink/SDLStreamingMediaManager.m index 45e9c8841..3bf380522 100644 --- a/SmartDeviceLink/SDLStreamingMediaManager.m +++ b/SmartDeviceLink/SDLStreamingMediaManager.m @@ -416,7 +416,7 @@ void sdl_videoEncoderOutputCallback(void * CM_NULLABLE outputCallbackRefCon, voi if (status != noErr) { // TODO: Log the error - if (error != nil) { + if (error != NULL) { *error = [NSError errorWithDomain:SDLErrorDomainStreamingMediaVideo code:SDLStreamingVideoErrorConfigurationCompressionSessionCreationFailure userInfo:@{ @"OSStatus": @(status) }]; } @@ -430,7 +430,7 @@ void sdl_videoEncoderOutputCallback(void * CM_NULLABLE outputCallbackRefCon, voi CFDictionaryRef supportedProperties; status = VTSessionCopySupportedPropertyDictionary(self.compressionSession, &supportedProperties); if (status != noErr) { - if (error != nil) { + if (error != NULL) { *error = [NSError errorWithDomain:SDLErrorDomainStreamingMediaVideo code:SDLStreamingVideoErrorConfigurationCompressionSessionSetPropertyFailure userInfo:@{ @"OSStatus": @(status) }]; } @@ -439,7 +439,7 @@ void sdl_videoEncoderOutputCallback(void * CM_NULLABLE outputCallbackRefCon, voi for (NSString *key in self.videoEncoderSettings.allKeys) { if (CFDictionaryContainsKey(supportedProperties, (__bridge CFStringRef)key) == false) { - if (error != nil) { + if (error != NULL) { NSString *description = [NSString stringWithFormat:@"\"%@\" is not a supported key.", key]; *error = [NSError errorWithDomain:SDLErrorDomainStreamingMediaVideo code:SDLStreamingVideoErrorConfigurationCompressionSessionSetPropertyFailure userInfo:@{NSLocalizedDescriptionKey: description}]; } @@ -455,7 +455,7 @@ void sdl_videoEncoderOutputCallback(void * CM_NULLABLE outputCallbackRefCon, voi status = VTSessionSetProperty(self.compressionSession, (__bridge CFStringRef)key, (__bridge CFTypeRef)value); if (status != noErr) { - if (error != nil) { + if (error != NULL) { *error = [NSError errorWithDomain:SDLErrorDomainStreamingMediaVideo code:SDLStreamingVideoErrorConfigurationCompressionSessionSetPropertyFailure userInfo:@{ @"OSStatus": @(status) }]; } |