diff options
| author | Joel Fischer <joeljfischer@gmail.com> | 2022-03-30 10:36:51 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-30 10:36:51 -0400 |
| commit | faab4b4cec01fbcbccbb53bdb0d4bf02ad6ec9c7 (patch) | |
| tree | 004a393f1f0913ebf1662d122319367727463bcc | |
| parent | 285b2d7f4ac433c73b5f1bafd7ffc722745613a9 (diff) | |
| parent | 40c88670afa302cea21fd3a05e4544c6bc86b6ae (diff) | |
| download | sdl_ios-faab4b4cec01fbcbccbb53bdb0d4bf02ad6ec9c7.tar.gz | |
Merge pull request #2076 from smartdevicelink/bugfix/issue-2075-warning-logs-removing-voice-commands
Add warning logs when voice commands are auto-removed
6 files changed, 9 insertions, 5 deletions
diff --git a/SmartDeviceLink-iOS.xcodeproj/project.pbxproj b/SmartDeviceLink-iOS.xcodeproj/project.pbxproj index 937b94e29..659729b26 100644 --- a/SmartDeviceLink-iOS.xcodeproj/project.pbxproj +++ b/SmartDeviceLink-iOS.xcodeproj/project.pbxproj @@ -7970,7 +7970,7 @@ attributes = { CLASSPREFIX = SDL; LastSwiftUpdateCheck = 0710; - LastUpgradeCheck = 1310; + LastUpgradeCheck = 1330; ORGANIZATIONNAME = smartdevicelink; TargetAttributes = { 5D4019AE1A76EC350006B0C2 = { diff --git a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-ObjC.xcscheme b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-ObjC.xcscheme index 0594d7cad..f2d358c8b 100644 --- a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-ObjC.xcscheme +++ b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-ObjC.xcscheme @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <Scheme - LastUpgradeVersion = "1310" + LastUpgradeVersion = "1330" version = "1.3"> <BuildAction parallelizeBuildables = "YES" diff --git a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-Swift.xcscheme b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-Swift.xcscheme index 590cc3654..5eae7fd7f 100644 --- a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-Swift.xcscheme +++ b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink-Example-Swift.xcscheme @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <Scheme - LastUpgradeVersion = "1310" + LastUpgradeVersion = "1330" version = "1.3"> <BuildAction parallelizeBuildables = "YES" diff --git a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink.xcscheme b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink.xcscheme index b5dda18cd..4e8db5cd0 100644 --- a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink.xcscheme +++ b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink.xcscheme @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <Scheme - LastUpgradeVersion = "1310" + LastUpgradeVersion = "1330" version = "1.3"> <BuildAction parallelizeBuildables = "YES" diff --git a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLinkSwift.xcscheme b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLinkSwift.xcscheme index 5bca151a1..5ad001267 100644 --- a/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLinkSwift.xcscheme +++ b/SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLinkSwift.xcscheme @@ -1,6 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> <Scheme - LastUpgradeVersion = "1310" + LastUpgradeVersion = "1330" version = "1.3"> <BuildAction parallelizeBuildables = "YES" diff --git a/SmartDeviceLink/private/SDLVoiceCommandManager.m b/SmartDeviceLink/private/SDLVoiceCommandManager.m index b4990b263..999ff7a22 100644 --- a/SmartDeviceLink/private/SDLVoiceCommandManager.m +++ b/SmartDeviceLink/private/SDLVoiceCommandManager.m @@ -175,11 +175,15 @@ UInt32 const VoiceCommandIdMin = 1900000000; // Updates voice command strings array by only adding ones that are not empty(e.g. "", " ", ...) if (trimmedString.length > 0) { [voiceCommandStrings addObject:voiceCommandString]; + } else { + SDLLogW(@"Empty or whitespace only voice command string: \"%@\" removed from voice command: %@", voiceCommandString, voiceCommand); } } if (voiceCommandStrings.count > 0) { voiceCommand.voiceCommands = voiceCommandStrings; [validatedVoiceCommands addObject:voiceCommand]; + } else { + SDLLogW(@"A voice command with no valid strings was removed: %@", voiceCommand); } } return [validatedVoiceCommands copy]; |