From d1daa830445cf4873f66d522233ce2e4c8022d2d Mon Sep 17 00:00:00 2001 From: Victor Costan Date: Mon, 14 Dec 2020 09:38:48 +0000 Subject: Remove inline qualifier from static variables. This feature requires C++17. Fortunately, inline is useful for header declarations, which may be included in multiple compilation units. The declarations modified by this CL occur in a single compilation unit. PiperOrigin-RevId: 347338760 --- snappy.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/snappy.cc b/snappy.cc index 8449b6e..a886a69 100644 --- a/snappy.cc +++ b/snappy.cc @@ -260,8 +260,8 @@ MakePatternMaskBytesTable(int index_offset, // This is an array of shuffle control masks that can be used as the source // operand for PSHUFB to permute the contents of the destination XMM register // into a repeating byte pattern. -alignas(16) inline constexpr std::array, - 16> pattern_generation_masks = +alignas(16) constexpr std::array, + 16> pattern_generation_masks = MakePatternMaskBytesTable( /*index_offset=*/0, /*pattern_sizes_minus_one=*/make_index_sequence<16>()); @@ -271,8 +271,8 @@ alignas(16) inline constexpr std::array, // Basically, pattern_reshuffle_masks is a continuation of // pattern_generation_masks. It follows that, pattern_reshuffle_masks is same as // pattern_generation_masks for offsets 1, 2, 4, 8 and 16. -alignas(16) inline constexpr std::array, - 16> pattern_reshuffle_masks = +alignas(16) constexpr std::array, + 16> pattern_reshuffle_masks = MakePatternMaskBytesTable( /*index_offset=*/16, /*pattern_sizes_minus_one=*/make_index_sequence<16>()); -- cgit v1.2.1