summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEugene Syromyatnikov <evgsyr@gmail.com>2021-12-09 01:22:28 +0100
committerEugene Syromyatnikov <evgsyr@gmail.com>2021-12-13 13:23:54 +0100
commitf3dfb99068d998487a0451b9f85440b26619047f (patch)
tree7791de7b36a277f7e3944379ea6cb42c31481433
parentd9d5e4b10d7730b9d4e8861ad61e0dda4cf7d57b (diff)
downloadstrace-f3dfb99068d998487a0451b9f85440b26619047f.tar.gz
net: simplify print_icmp_filter size check
The general print_getsockopt code already handles the case of non-positive len, so this check in print_icmp_filter is superficial. * src/net.c (print_icmp_filter): Change len type from int to usigned int. Do not check if len is less or equal zero.
-rw-r--r--src/net.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/src/net.c b/src/net.c
index 532ceb88f..4cd48e72e 100644
--- a/src/net.c
+++ b/src/net.c
@@ -898,16 +898,13 @@ print_tpacket_stats(struct tcb *const tcp, const kernel_ulong_t addr,
#include "xlat/icmpfilterflags.h"
static void
-print_icmp_filter(struct tcb *const tcp, const kernel_ulong_t addr, int len)
+print_icmp_filter(struct tcb *const tcp, const kernel_ulong_t addr,
+ unsigned int len)
{
struct icmp_filter filter = {};
- if (len > (int) sizeof(filter))
+ if (len > sizeof(filter))
len = sizeof(filter);
- else if (len <= 0) {
- printaddr(addr);
- return;
- }
if (umoven_or_printaddr(tcp, addr, len, &filter))
return;