1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
/*
* sqlite-test.c -- test the stream functions
*
* ====================================================================
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
* ====================================================================
*/
#include "private/svn_sqlite.h"
#include "../svn_test.h"
static svn_error_t *
open_db(svn_sqlite__db_t **sdb,
const char **db_abspath_p,
const char *db_name,
const char *const *statements,
apr_int32_t timeout,
apr_pool_t *pool)
{
const char *db_dir, *db_abspath;
SVN_ERR(svn_dirent_get_absolute(&db_dir, "sqlite-test-tmp", pool));
SVN_ERR(svn_io_remove_dir2(db_dir, TRUE, NULL, NULL, pool));
SVN_ERR(svn_io_make_dir_recursively(db_dir, pool));
svn_test_add_dir_cleanup(db_dir);
db_abspath = svn_dirent_join(db_dir, db_name, pool);
SVN_ERR(svn_sqlite__open(sdb, db_abspath, svn_sqlite__mode_rwcreate,
statements, 0, NULL, timeout, pool, pool));
if (db_abspath_p)
*db_abspath_p = db_abspath;
return SVN_NO_ERROR;
}
static svn_error_t *
error_second(svn_sqlite__context_t *sctx,
int argc,
svn_sqlite__value_t *values[],
void *baton)
{
static int i = 0;
if (++i == 2)
svn_sqlite__result_error(sctx, "fake error", 0);
else
svn_sqlite__result_int64(sctx, 1);
return SVN_NO_ERROR;
}
static svn_error_t *
test_sqlite_reset(apr_pool_t *pool)
{
svn_sqlite__db_t *sdb;
svn_sqlite__stmt_t *stmt;
svn_boolean_t have_row;
const char *value;
static const char *const statements[] = {
"CREATE TABLE reset ("
" one TEXT NOT NULL PRIMARY KEY,"
" two TEXT"
");"
"INSERT INTO reset(one, two) VALUES ('foo', 'bar');"
"INSERT INTO reset(one, two) VALUES ('zig', 'zag')",
"SELECT one FROM reset WHERE two IS NOT NULL AND error_second(one) "
"ORDER BY one",
NULL
};
SVN_ERR(open_db(&sdb, NULL, "reset", statements, 0, pool));
SVN_ERR(svn_sqlite__create_scalar_function(sdb, "error_second",
1, FALSE /* deterministic */,
error_second, NULL));
SVN_ERR(svn_sqlite__exec_statements(sdb, 0));
SVN_ERR(svn_sqlite__get_statement(&stmt, sdb, 1));
/* First step is OK. */
SVN_ERR(svn_sqlite__step(&have_row, stmt));
SVN_TEST_ASSERT(have_row);
value = svn_sqlite__column_text(stmt, 0, NULL);
SVN_TEST_ASSERT(value && !strcmp(value, "foo"));
/* Second step fails. */
SVN_TEST_ASSERT_ERROR(svn_sqlite__step(&have_row, stmt),
SVN_ERR_SQLITE_ERROR);
/* The svn_sqlite__step wrapper calls svn_sqlite__reset when step
fails so the reset call here is a no-op. The first step can be
repeated. */
SVN_ERR(svn_sqlite__reset(stmt));
SVN_ERR(svn_sqlite__step(&have_row, stmt));
SVN_TEST_ASSERT(have_row);
value = svn_sqlite__column_text(stmt, 0, NULL);
SVN_TEST_ASSERT(value && !strcmp(value, "foo"));
SVN_ERR(svn_sqlite__reset(stmt));
return SVN_NO_ERROR;
}
static svn_error_t *
test_sqlite_txn_commit_busy(apr_pool_t *pool)
{
svn_sqlite__db_t *sdb1;
svn_sqlite__db_t *sdb2;
const char *db_abspath;
svn_error_t *err;
static const char *const statements[] = {
"CREATE TABLE test (one TEXT NOT NULL PRIMARY KEY)",
"INSERT INTO test(one) VALUES ('foo')",
"SELECT one from test",
NULL
};
/* Open two db connections.
Use a small busy_timeout of 250ms, since we're about to receive an
SVN_ERR_SQLITE_BUSY error, and retrying for the default 10 seconds
would be a waste of time. */
SVN_ERR(open_db(&sdb1, &db_abspath, "txn_commit_busy",
statements, 250, pool));
SVN_ERR(svn_sqlite__open(&sdb2, db_abspath, svn_sqlite__mode_readwrite,
statements, 0, NULL, 250, pool, pool));
SVN_ERR(svn_sqlite__exec_statements(sdb1, 0));
/* Begin two deferred transactions. */
SVN_ERR(svn_sqlite__begin_transaction(sdb1));
SVN_ERR(svn_sqlite__exec_statements(sdb1, 1 /* INSERT */));
SVN_ERR(svn_sqlite__begin_transaction(sdb2));
SVN_ERR(svn_sqlite__exec_statements(sdb2, 2 /* SELECT */));
/* Try to COMMIT the first write transaction; this should fail due to
the concurrent read transaction that holds a shared lock on the db. */
err = svn_sqlite__finish_transaction(sdb1, SVN_NO_ERROR);
SVN_TEST_ASSERT_ERROR(err, SVN_ERR_SQLITE_BUSY);
/* We failed to COMMIT the first transaction, but COMMIT-ting the
second transaction through a different db connection should succeed.
Upgrade it to a write transaction by executing the INSERT statement,
and then commit. */
SVN_ERR(svn_sqlite__exec_statements(sdb2, 1 /* INSERT */));
SVN_ERR(svn_sqlite__finish_transaction(sdb2, SVN_NO_ERROR));
SVN_ERR(svn_sqlite__close(sdb2));
SVN_ERR(svn_sqlite__close(sdb1));
return SVN_NO_ERROR;
}
static int max_threads = 1;
static struct svn_test_descriptor_t test_funcs[] =
{
SVN_TEST_NULL,
SVN_TEST_PASS2(test_sqlite_reset,
"sqlite reset"),
SVN_TEST_PASS2(test_sqlite_txn_commit_busy,
"sqlite busy on transaction commit"),
SVN_TEST_NULL
};
SVN_TEST_MAIN
|
