| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Used wrong variable.
Reported-By: Patrick Masotta <masottaus@yahoo.com>
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
| |
Some machines don't like UseDefaultAddress; fallback to manually
configuring. HP EFI servers like DL160 Gen9 are affected.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
| |
Wrong translation type used.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
OBJ directory creation changed from a .PHONY target to a real target
used through an order-only dependency.
A target depending on another target marked .PHONY is always rebuilt,
thus forcing all the .o files to be rebuilt everytime.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Reviewed-by: Paulo Alcantara <pcacjr@zytor.com>
|
|
|
|
|
|
|
| |
Missing */ at the end of a comment.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Reviewed-by: Paulo Alcantara <pcacjr@zytor.com>
|
|\
| |
| |
| |
| |
| | |
Merge git://github.com/Celelibi/syslinux.git branch 'fix/efi/cleanup'
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
The assignment looks suspicious but is actually legit since it is
protected by the type check.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
The function efi_get_MAC was given a pointer to array instead of a
simple pointer, generating a warning with gcc.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Syslinux 6.03 (efi64) fails to boot a 32-bit kernel. The way Syslinux
leaves long mode in kernel_jump assembly routine does not follow AMD64
specifications. More precisely:
1. After setting a new GADT, `cs` has to be refresh by doing a long
jump, but it is not
2. Other segments have to be updated, but they are not
3. Disabling paging has to be done before disabling long mode, but the
implementation does the opposite
In most cases, a computer that tries to execute the kernel_jump routine
reboot (it can also hangs). This patch fixes the kernel_jump routine.
Signed-off-by: Thomas Letan <thomas.letan@ssi.gouv.fr>
Tested-by: Patrick Masotta <masottaus@yahoo.com>
Tested-by: Celelibi <celelibi@gmail.com>
|
|/
|
|
|
|
|
| |
PCs without keyboards may hang as they might return a status other than
EFI_NOT_READY.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
| |
If LibLocateHandle() returns success and either 0 handles or we find no
matching handles, treat it the same.
Originally-By: Patrick Masotta <masottaus@yahoo.com>
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
| |
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
| |
Extracts a MAC address from a device path
Originally-By: Patrick Masotta <masottaus@yahoo.com>
[gene.cumm@gmail.com: Respace]
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
| |
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
| |
Unnecessary. On some systems, opens NIC in promiscuous mode or
breaks UseDefaultAddress.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
| |
There are more unsuccessful returns that are ignored. Restructure to
allow for trapping other values.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
| |
This clause closes the protocol before creating the child
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
| |
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Store and reuse handle found with EFI_LOADED_IMAGE_PROTOCOL for
EFI_PXE_BASE_CODE_PROTOCOL and EFI_UDP4_SERVICE_BINDING_PROTOCOL
This caused machines with multiple NICs to not reliably attach to the
correct NIC handle.
gnu-efi LoadedImageProtocol PxeBaseCodeProtocol Udp4ServiceBindingProtocol
Reported-By: Holger Baust <holger.baust@freenet.ag>
Reported-By: Michael Glasgow <glasgow@beer.net>
Reported-By: Da Shi Cao <dscao999@gmail.com>
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
| |
Add packet type so we can eventually only grab certain data elements from
the DHCP packets appropriately
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
|
| |
parse_dhcp() does this also, seeming to set a bad value for some clients.
Fixes some deaf clients.
Signed-off-by: Patrick Masotta <masottaus@yahoo.com>
[gene.cumm@gmail.com: Just move existing code]
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
EFI allows us to have access to more DHCP-related packets. Choose the
packet with the highest priority for the third to parse.
Signed-off-by: Patrick Masotta <masottaus@yahoo.com>
[gene.cumm@gmail.com: Only change the third parsing iteration;
reflow to better fit code standards; don't reparse DhcpAck]
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
| |
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
|
| |
The build would be failed and exit if build-gnu-efi.sh is failed, so
we'd better not suppress the output of build-gnu-efi.sh, which is good
for debugging.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
| |
efi/clean-gnu-efi.sh presumes it's in a git repo. Test first.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
| |
efi/build-gnu-efi.sh presumes it's in a git repo. Test first.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 415d571 ("adv: Remove double defintion") introduced a regression
for the EFI boot loader. The commit is correct, but should have tagged
the __syslinux_adv_ptr and __syslinux_adv_size data objects in the EFI
core as __export.
This change is required because symbols in the EFI code are not global
by default, and so, when ldlinux.{e32,e64} tries to bind to the adv
symbols it fails.
The following demonstrates the ELF symbol changes,
Before:
659: 0000000000034f40 8 OBJECT LOCAL DEFAULT 16 __syslinux_adv_ptr
After:
957: 0000000000036fe0 8 OBJECT GLOBAL DEFAULT 16 __syslinux_adv_ptr
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
|
|
|
|
|
|
|
|
| |
For EFI, rather than mucking with the PECOFF or ELF headers (we have
both!) just use a fixed-size buffer embedded in the image with a large
magic number that can be scanned for safely.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove the last bits of the comapi interfaces completely. This does
not install stub handlers for the INT 20-3Fh handlers, as we don't
support loading old COMBOOT/COM32/COM32R images anymore.
We could put those back if we really need them.
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Actually get the shuffler size sanely. At least for now, we are BIOS
only, so stub out the functions on EFI (they shouldn't even be
compiled for EFI; this stuff should be moved into some kind of
BIOS-only directory.)
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This eliminates the forking and pushes the build under the efi32/ and
efi64/ object directories eliminating a build race and preventing the
build from breaking as gnu-efi takes a few seconds to complete.
Depends on gnu-efi commit 52d88dd
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There is no need to have a relocation section that nothing points at.
The image is still seen as relocatable as long as the Characteristics of
the FileHeader do not say otherwise.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
PE headers code_sz and image_sz indicate more or less, the size of the
file and the size of the in-memory image. They are now given the right
value.
In the ELF format, only the program headers are reliable to determine
the actually needed part of the file and the in-memory size.
The .bss section should always be marked as NOLOAD for ld since its
content shouldn't be included into the binary file.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
OVMF and probably other UEFI implementation refuse a file with a
relocation entry inside the headers. And since the dummy relocation
wasn't used at all, better remove it.
Moreover, the field base_relocation_table wasn't initialized properly,
leading to unpredictable bugs.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the generated PE file, the section header for the .text section used
to address more than the whole file. Starting at offset 0 (before the
end of the headers) is illegal and is rejected by OVMF. Giving a size
greater than the actual file size is also illegal and rejected.
Moreover, the body of the PE file have to be aligned to at least 512
bytes. Hence, .text need to be aligned as well.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
|/
|
|
|
|
|
|
|
| |
The value of the field rva_and_sizes_nr is used by OVMF to check the
consistency of the PE file with respect to the field optional_hdr_sz. It
now have the right value.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
It could happen on 32 bits architecture that the memory size really allocated
could be less than required. On 64 bits, allocate_pages may be called
more times than needed.
This closes bug #39.
Signed-off-by: Sylvain Gault <sylvain.gault@gmail.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
|
|
|
|
|
|
| |
&>foo is a bashism, use >foo 2>&1 instead.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
|
|\
| |
| |
| | |
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
|
| |
| |
| |
| | |
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
This should help hardware that doesn't return EFI_SUCCESS immediately.
Reported-by: Jason Matthews <jason.david.matthews@gmail.com>
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
| |
| |
| |
| |
| |
| | |
udata.AcceptAnyPort caused the udata.StationPort to return as 0.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
We don't need to re-inform EFI what IPv4 address and subnet mask to use.
This change should help to re-use the exising routes.
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
core_udp_open() obtained a port allocation. Continue using it.
Author: Celelibi <celelibi@gmail.com>
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|/
|
|
|
|
|
|
| |
core_udp_open() should obtain a UDP port allocation and save it for
core_udp_connect() and core_udp_sendto() to reuse.
Author: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Gene Cumm <gene.cumm@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not all distributions point /bin/sh at /bin/bash, so remove some
bashisms (pushd/popd) and require that build-gnu-efi.sh be run from the
Syslinux object directory.
Also, swap realpath(1) for readlink(1) because the former isn't
available on Debian.
Reported-by: Ferenc Wagner <wferi@niif.hu>
Reported-by: Celelibi <celelibi@gmail.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
firmware
Pull date fix for EFI from Gene Cumm,
* 'efi-date-for-mfleming' of git://github.com/geneC/syslinux:
efi/: Fix displayed version; add DATE
|