diff options
| author | Frantisek Sumsal <frantisek@sumsal.cz> | 2020-07-08 14:42:43 +0200 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2020-07-08 22:09:55 +0200 |
| commit | 2e7090e94d0c8b31d418555ab2f6a9b75318f6a4 (patch) | |
| tree | 0dc45f1dc2c6ecad57cc77bf7823b60b8a328380 | |
| parent | 24e2494407cb5a88ee81fc238195687e5e0b8a09 (diff) | |
| download | systemd-2e7090e94d0c8b31d418555ab2f6a9b75318f6a4.tar.gz | |
test: bump the TEST-47 sleeps once again
Several recent failed runs show that the test is still racy in two ways:
1) Sometimes it takes a while before the PID file is created, leading
to:
```
[ 10.950540] testsuite-47.sh[308]: ++ cat /leakedtestpid
[ 10.959712] testsuite-47.sh[308]: cat: /leakedtestpid: No such file or directory
[ 10.959824] testsuite-47.sh[298]: + leaked_pid=
```
2) Again, sometimes we check the leaked PID before the unit is actually
stopped, leading to a false negative:
```
[ 18.099599] testsuite-47.sh[346]: ++ cat /leakedtestpid
[ 18.116462] testsuite-47.sh[333]: + leaked_pid=342
[ 18.117101] testsuite-47.sh[333]: + systemctl stop testsuite-47-repro
...
[ 20.033907] testsuite-47.sh[333]: + ps -p 342
[ 20.080050] testsuite-47.sh[351]: PID TTY TIME CMD
[ 20.080050] testsuite-47.sh[351]: 342 ? 00:00:00 sleep
[ 20.082040] testsuite-47.sh[333]: + exit 42
```
| -rwxr-xr-x | test/units/testsuite-47.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/units/testsuite-47.sh b/test/units/testsuite-47.sh index 97f86140f1..50034cf3d9 100755 --- a/test/units/testsuite-47.sh +++ b/test/units/testsuite-47.sh @@ -6,13 +6,13 @@ systemd-analyze log-level debug systemd-analyze log-target console systemctl start testsuite-47-repro -sleep 1 +sleep 4 systemctl status testsuite-47-repro leaked_pid=$(cat /leakedtestpid) systemctl stop testsuite-47-repro -sleep 1 +sleep 4 # Leaked PID will still be around if we're buggy. # I personally prefer to see 42. |